Breaking Change - Removed ApiVersion parameter from Az.Resources deployments cmdlets and changed the output type of Get-AzResourceGroupDeploymentOperations (#13112)

* Remove ApiVersion Parameter from deployments

* update changelog

* Delete ApiVersion param

* Switch to SDK use in ResourceGroup Deployments cmdlets

* Include review fixes

* Changed help file to reflect new output type

* Rollback breaking changes from PR #12141

* Change Get-AzResourceGroupDeploymentOperation implementation to use SDK

* Update help

* Rollback changes to help files of untouched cmdlets

* Suppress breaking change issues

* remove subscriptionId param

* Update breakingchanges csv

* Suppress breaking changes

* Review fixes + breaking change suppression

* Add missed breaking change issue to fix static analysis failure

* Update ChangeLog.md

Co-authored-by: Yeming Liu <[email protected]>

Author: Xynoclafe

src/Resources/ResourceManager/Implementation/CmdletBase/ResourceManagerCmdletBase.cs

@@ -25,15 +25,13 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     using Microsoft.Azure.Commands.ResourceManager.Cmdlets.RestClients;
     using Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkClient;
     using Microsoft.Rest.Azure;
-    using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
     using Newtonsoft.Json.Linq;
     using System;
     using System.Collections.Generic;
     using System.Linq;
     using System.Management.Automation;
     using System.Runtime.ExceptionServices;
     using System.Threading;
-    using System.Threading.Tasks;
 
     /// <summary>
     /// The base class for resource manager cmdlets.
@@ -66,14 +64,6 @@ protected CancellationToken? CancellationToken
         /// </summary>
         private SubscriptionSdkClient subscriptionSdkClient;
 
-        /// <summary>
-        /// Gets or sets the API version.
-        /// </summary>
-        [CmdletParameterBreakingChange("ApiVersion", ChangeDescription = "Parameter is being deprecated without being replaced")]
-        [Parameter(Mandatory = false, HelpMessage = "When set, indicates the version of the resource provider API to use. If not specified, the API version is automatically determined as the latest available.")]
-        [ValidateNotNullOrEmpty]
-        public virtual string ApiVersion { get; set; }
-
         /// <summary>
         /// Gets or sets the switch that indicates if pre-release API version should be considered.
         /// </summary>
@@ -223,42 +213,6 @@ protected virtual void OnStopProcessing()
             // no-op
         }
 
-        /// <summary>
-        /// Determines the API version.
-        /// </summary>
-        /// <param name="resourceId">The resource Id.</param>
-        /// <param name="pre">When specified, indicates if pre-release API versions should be considered.</param>
-        protected Task<string> DetermineApiVersion(string resourceId, bool? pre = null)
-        {
-            return string.IsNullOrWhiteSpace(this.ApiVersion)
-                ? ApiVersionHelper.DetermineApiVersion(
-                    context: DefaultContext,
-                    resourceId: resourceId,
-                    cancellationToken: this.CancellationToken.Value,
-                    pre: pre ?? this.Pre,
-                    cmdletHeaderValues: this.GetCmdletHeaders())
-                : Task.FromResult(this.ApiVersion);
-        }
-
-        /// <summary>
-        /// Determines the API version.
-        /// </summary>
-        /// <param name="providerNamespace">The provider namespace.</param>
-        /// <param name="resourceType">The resource type.</param>
-        /// <param name="pre">When specified, indicates if pre-release API versions should be considered.</param>
-        protected Task<string> DetermineApiVersion(string providerNamespace, string resourceType, bool? pre = null)
-        {
-            return string.IsNullOrWhiteSpace(this.ApiVersion)
-                ? ApiVersionHelper.DetermineApiVersion(
-                    DefaultContext,
-                    providerNamespace: providerNamespace,
-                    resourceType: resourceType,
-                    cancellationToken: this.CancellationToken.Value,
-                    pre: pre ?? this.Pre,
-                    cmdletHeaderValues: this.GetCmdletHeaders())
-                : Task.FromResult(this.ApiVersion);
-        }
-
         /// <summary>
         /// Gets a new instance of the <see cref="ResourceManagerRestRestClient"/>.
         /// </summary>

src/Resources/ResourceManager/Implementation/CmdletBase/ResourceManagerCmdletBaseWithAPiVersion.cs

@@ -13,16 +13,63 @@
 // ----------------------------------------------------------------------------------
 
 using System.Management.Automation;
+using System.Threading.Tasks;
+using System.Collections.Generic;
 
 namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
 {
-    public abstract class ResourceManagerCmdletBaseWithAPiVersion : ResourceManagerCmdletBase
+    public abstract class ResourceManagerCmdletBaseWithApiVersion : ResourceManagerCmdletBase
     {
         /// <summary>
         /// Gets or sets the API version.
         /// </summary>
         [Parameter(Mandatory = false, HelpMessage = "When set, indicates the version of the resource provider API to use. If not specified, the API version is automatically determined as the latest available.")]
         [ValidateNotNullOrEmpty]
-        public override string ApiVersion { get; set; }
+        public string ApiVersion { get; set; }
+
+        private Dictionary<string, string> GetCmdletHeaders()
+        {
+            return new Dictionary<string, string>
+            {
+                {"ParameterSetName", this.ParameterSetName },
+                {"CommandName", this.CommandRuntime.ToString() }
+            };
+        }
+
+        /// <summary>
+        /// Determines the API version.
+        /// </summary>
+        /// <param name="resourceId">The resource Id.</param>
+        /// <param name="pre">When specified, indicates if pre-release API versions should be considered.</param>
+        protected Task<string> DetermineApiVersion(string resourceId, bool? pre = null)
+        {
+            return string.IsNullOrWhiteSpace(this.ApiVersion)
+                ? Components.ApiVersionHelper.DetermineApiVersion(
+                    context: DefaultContext,
+                    resourceId: resourceId,
+                    cancellationToken: this.CancellationToken.Value,
+                    pre: pre ?? this.Pre,
+                    cmdletHeaderValues: this.GetCmdletHeaders())
+                : Task.FromResult(this.ApiVersion);
+        }
+
+        /// <summary>
+        /// Determines the API version.
+        /// </summary>
+        /// <param name="providerNamespace">The provider namespace.</param>
+        /// <param name="resourceType">The resource type.</param>
+        /// <param name="pre">When specified, indicates if pre-release API versions should be considered.</param>
+        protected Task<string> DetermineApiVersion(string providerNamespace, string resourceType, bool? pre = null)
+        {
+            return string.IsNullOrWhiteSpace(this.ApiVersion)
+                ? Components.ApiVersionHelper.DetermineApiVersion(
+                    DefaultContext,
+                    providerNamespace: providerNamespace,
+                    resourceType: resourceType,
+                    cancellationToken: this.CancellationToken.Value,
+                    pre: pre ?? this.Pre,
+                    cmdletHeaderValues: this.GetCmdletHeaders())
+                : Task.FromResult(this.ApiVersion);
+        }
     }
 }

src/Resources/ResourceManager/Implementation/CmdletBase/ResourceManipulationCmdletBase.cs

@@ -23,7 +23,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     /// <summary>
     /// The base class for manipulating resources.
     /// </summary>
-    public abstract class ResourceManipulationCmdletBase : ResourceManagerCmdletBaseWithAPiVersion
+    public abstract class ResourceManipulationCmdletBase : ResourceManagerCmdletBaseWithApiVersion
     {
         /// <summary>
         /// The subscription level parameter set.

src/Resources/ResourceManager/Implementation/Locations/GetAzureLocationCmdlet.cs

@@ -28,7 +28,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     /// Get all locations with the supported providers.
     /// </summary>
     [Cmdlet(VerbsCommon.Get, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "Location"), OutputType(typeof(PSResourceProviderLocation))]
-    public class GetAzureLocationCmdlet : ResourceManagerCmdletBaseWithAPiVersion
+    public class GetAzureLocationCmdlet : ResourceManagerCmdletBaseWithApiVersion
     {
         /// <summary>
         /// Executes the cmdlet

src/Resources/ResourceManager/Implementation/Lock/ResourceLockManagementCmdletBase.cs

@@ -26,7 +26,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     /// <summary>
     /// Base class for resource lock management cmdlets.
     /// </summary>
-    public abstract class ResourceLockManagementCmdletBase : ResourceManagerCmdletBaseWithAPiVersion
+    public abstract class ResourceLockManagementCmdletBase : ResourceManagerCmdletBaseWithApiVersion
     {
         /// <summary> 
         /// The Id parameter set. 

src/Resources/ResourceManager/Implementation/ManagedApplications/ManagedApplicationCmdletBase.cs

@@ -32,7 +32,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     /// <summary>
     /// Base class for policy assignment cmdlets.
     /// </summary>
-    public abstract class ManagedApplicationCmdletBase : ResourceManagerCmdletBaseWithAPiVersion
+    public abstract class ManagedApplicationCmdletBase : ResourceManagerCmdletBaseWithApiVersion
     {
         /// <summary>
         /// Gets the next set of resources using the <paramref name="nextLink"/>

src/Resources/ResourceManager/Implementation/Policy/GetAzurePolicyAliasCmdlet.cs

@@ -27,7 +27,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     /// Get an existing resource.
     /// </summary>
     [Cmdlet(VerbsCommon.Get, AzureRMConstants.AzureRMPrefix + "PolicyAlias"), OutputType(typeof(PsResourceProviderAlias))]
-    public class GetAzurePolicyAlias : ResourceManagerCmdletBaseWithAPiVersion
+    public class GetAzurePolicyAlias : ResourceManagerCmdletBaseWithApiVersion
     {
         /// <summary>
         /// Gets or sets the provider namespace match string

src/Resources/ResourceManager/Implementation/Policy/PolicyCmdletBase.cs

@@ -32,7 +32,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     /// <summary>
     /// Base class for policy cmdlets.
     /// </summary>
-    public abstract class PolicyCmdletBase : ResourceManagerCmdletBaseWithAPiVersion
+    public abstract class PolicyCmdletBase : ResourceManagerCmdletBaseWithApiVersion
     {
         public enum ListFilter
         {

src/Resources/ResourceManager/Implementation/Providers/GetAzureProviderCmdlet.cs

@@ -29,7 +29,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     /// Get an existing resource.
     /// </summary>
     [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ResourceProvider", DefaultParameterSetName = GetAzureProviderCmdlet.ListAvailableParameterSet), OutputType(typeof(PSResourceProvider))]
-    public class GetAzureProviderCmdlet : ResourceManagerCmdletBaseWithAPiVersion
+    public class GetAzureProviderCmdlet : ResourceManagerCmdletBaseWithApiVersion
     {
         /// <summary>
         /// The individual provider parameter set name

src/Resources/ResourceManager/Implementation/Providers/RegisterAzureProviderCmdlet.cs

@@ -24,7 +24,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
     /// Register the previewed features of a certain azure resource provider.
     /// </summary>
     [Cmdlet("Register", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ResourceProvider", SupportsShouldProcess = true), OutputType(typeof(PSResourceProvider))]
-    public class RegisterAzureProviderCmdlet : ResourceManagerCmdletBaseWithAPiVersion
+    public class RegisterAzureProviderCmdlet : ResourceManagerCmdletBaseWithApiVersion
     {
         /// <summary>
         /// Gets or sets the provider namespace