Fix PartnerServerName check in GetAzureSqlDatabaseReplicationLink.cs (#13433)

* Fix PartnerServerName check

Fix check for PartnerServerName param check to look for string literal instead of value of variable.

* Update ChangeLog.md

* Use nameof to avoid magic string

Co-authored-by: Yeming Liu <[email protected]>

Co-authored-by: Yeming Liu <[email protected]>

Author: alecbain

src/Sql/Sql/ChangeLog.md

@@ -20,6 +20,7 @@
 ## Upcoming Release
 * Fixed issues where Set-AzSqlDatabaseAudit were not support Hyperscale database and database edition cannot be determined
 * Added MaintenanceConfigurationId to 'New-AzSqlInstance' and 'Set-AzSqlInstance'
+* Fixed a bug in GetAzureSqlDatabaseReplicationLink.cs where PartnerServerName parameter was being checked for by value instead of key
 
 ## Version 2.11.1
 * Fixed issue where New-AzSqlDatabaseExport fails if networkIsolation not specified [#13097]

src/Sql/Sql/Replication/Cmdlet/GetAzureSqlDatabaseReplicationLink.cs

@@ -73,7 +73,7 @@ protected override IEnumerable<AzureReplicationLinkModel> GetEntity()
         {
             ICollection<AzureReplicationLinkModel> results;
 
-            if (MyInvocation.BoundParameters.ContainsKey(PartnerServerName) && !WildcardPattern.ContainsWildcardCharacters(PartnerServerName))
+            if (MyInvocation.BoundParameters.ContainsKey(nameof(PartnerServerName)) && !WildcardPattern.ContainsWildcardCharacters(PartnerServerName))
             {
                 results = new List<AzureReplicationLinkModel>();
                 results.Add(ModelAdapter.GetLink(this.ResourceGroupName, this.ServerName, this.DatabaseName, this.PartnerResourceGroupName, this.PartnerServerName));