Skip to content

Commit 21a1250

Browse files
Added fix for Update-AzMaintenanceConfiguration (#25126)
* Added potential fix for Update-AzMaintenanceConfiguration * Added test for bug fix * Reverted small change * Updated ChangeLog * Updated ChangeLog * Update ChangeLog.md --------- Co-authored-by: NoriZC <[email protected]>
1 parent cfd5934 commit 21a1250

File tree

10 files changed

+3025
-1234
lines changed

10 files changed

+3025
-1234
lines changed

src/Maintenance/Maintenance.Test/ScenarioTests/MaintenanceTests.ps1

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ function Test-AzMaintenanceConfigurationInGuestPatch
172172
$maintenanceConfigurationNameInstance = $allMaintenanceConfigInSubscription | ?{ $_.Name -eq $maintenanceConfigurationName}
173173

174174
$maintenanceConfigurationNameInstance.LinuxParameterPackageNameMaskToInclude.Add("package3")
175+
$maintenanceConfigurationNameInstance.InstallPatchRebootSetting = "AlwaysReboot"
175176

176177
# Act
177178
Update-AzMaintenanceConfiguration -ResourceGroupName $resourceGroupName -Name $maintenanceConfigurationName -Configuration $maintenanceConfigurationNameInstance
@@ -182,6 +183,7 @@ function Test-AzMaintenanceConfigurationInGuestPatch
182183
Assert-True { $updatedMRPConfig.LinuxParameterPackageNameMaskToInclude.Contains("apt") }
183184
Assert-True { $updatedMRPConfig.LinuxParameterPackageNameMaskToInclude.Contains("httpd") }
184185
Assert-True { $updatedMRPConfig.LinuxParameterPackageNameMaskToInclude.Contains("package3") }
186+
Assert-AreEqual $updatedMRPConfig.InstallPatchRebootSetting "AlwaysReboot"
185187

186188
# Default patch config
187189
$maintenanceConfigurationName2 = Get-RandomMaintenanceConfigurationName

src/Maintenance/Maintenance.Test/SessionRecords/Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests.MaintenanceTests/TestAzConfigurationAssignmentDynamicGroupForResourceGroup.json

Lines changed: 304 additions & 169 deletions
Large diffs are not rendered by default.

src/Maintenance/Maintenance.Test/SessionRecords/Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests.MaintenanceTests/TestAzConfigurationAssignmentDynamicGroupForSubscription.json

Lines changed: 327 additions & 183 deletions
Large diffs are not rendered by default.

src/Maintenance/Maintenance.Test/SessionRecords/Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests.MaintenanceTests/TestConfigurationAssignment.json

Lines changed: 448 additions & 103 deletions
Large diffs are not rendered by default.

src/Maintenance/Maintenance.Test/SessionRecords/Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests.MaintenanceTests/TestMaintenanceConfiguration.json

Lines changed: 461 additions & 257 deletions
Large diffs are not rendered by default.

src/Maintenance/Maintenance.Test/SessionRecords/Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests.MaintenanceTests/TestMaintenanceConfigurationInGuestPatch.json

Lines changed: 987 additions & 252 deletions
Large diffs are not rendered by default.

src/Maintenance/Maintenance.Test/SessionRecords/Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests.MaintenanceTests/TestMaintenanceUpdate.json

Lines changed: 256 additions & 139 deletions
Large diffs are not rendered by default.

src/Maintenance/Maintenance.Test/SessionRecords/Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests.MaintenanceTests/TestPublicMaintenanceConfiguration.json

Lines changed: 238 additions & 130 deletions
Large diffs are not rendered by default.

src/Maintenance/Maintenance/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
-->
2020

2121
## Upcoming Release
22+
* Fixed bug where rebootSettings property wasn't updating.
2223

2324
## Version 1.4.1
2425
* Removed outdated upcoming breaking change warning

src/Maintenance/Maintenance/Models/MaintenanceAutoMapperProfile.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ private static void Initialize()
8787
.ForMember(dest => dest.WindowParameterExcludeKbRequiringReboot, opt => opt.MapFrom(src => src.InstallPatches.WindowsParameters.ExcludeKbsRequiringReboot))
8888
.ForMember(dest => dest.WindowParameterKbNumberToExclude, opt => opt.MapFrom(src => src.InstallPatches.WindowsParameters.KbNumbersToExclude))
8989
.ForMember(dest => dest.WindowParameterKbNumberToInclude, opt => opt.MapFrom(src => src.InstallPatches.WindowsParameters.KbNumbersToInclude))
90-
.ForMember(dest => dest.InstallPatchRebootSetting, opt => opt.MapFrom(src => src.InstallPatches.RebootSetting))
9190
.ForMember(dest => dest.PreTask, opt => opt.Ignore())
9291
.ForMember(dest => dest.PostTask, opt => opt.Ignore())
9392
.ForSourceMember(src => src.SystemData, s => s.Ignore());
@@ -99,6 +98,7 @@ private static void Initialize()
9998
.ForPath(dest => dest.InstallPatches.WindowsParameters.ExcludeKbsRequiringReboot, src => src.MapFrom(o => o.WindowParameterExcludeKbRequiringReboot))
10099
.ForPath(dest => dest.InstallPatches.WindowsParameters.KbNumbersToExclude, src => src.MapFrom(o => o.WindowParameterKbNumberToExclude))
101100
.ForPath(dest => dest.InstallPatches.WindowsParameters.KbNumbersToInclude, src => src.MapFrom(o => o.WindowParameterKbNumberToInclude))
101+
.ForPath(dest => dest.InstallPatches.RebootSetting, src => src.MapFrom(o => o.InstallPatchRebootSetting))
102102
.AfterMap((src, dst) => {
103103
if (string.IsNullOrEmpty(src.InstallPatchRebootSetting) &&
104104
!src.WindowParameterExcludeKbRequiringReboot.HasValue &&

0 commit comments

Comments
 (0)