[Bastion] Add support for Bastion features (#23404)

* Initial commit

* Optimize for sku and features

* Initial commit

* Optimize for sku and features

* Cleanup

* Formatting and add test cases

* Minor fixes

* Fixing tests

* Adding newly generated markdowns

* Update ChangeLog.md

* Mark "Kerberos is plural" as false positive

---------

Co-authored-by: Abhishek Shah <[email protected]>

Author: abhi7860

src/Network/Network.Test/ScenarioTests/BastionTests.cs

@@ -57,5 +57,13 @@ public void TestBastionIpObjectParam()
         {
             TestRunner.RunTestScript("Test-BastionIpObjectParam");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        [Trait(Category.Owner, NrpTeamAlias.bastion)]
+        public void TestBastionCreateWithFeatures()
+        {
+            TestRunner.RunTestScript("Test-BastionCreateWithFeatures");
+        }
     }
 }

src/Network/Network.Test/ScenarioTests/BastionTests.ps1

@@ -1,19 +1,29 @@
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 // ----------------------------------------------------------------------------------
-using System;
-using System.Collections;
-using System.Collections.Generic;
-using System.Net;
-using AutoMapper;
-using Microsoft.Azure.Commands.Network.Models;
-using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
-using Microsoft.Azure.Management.Network;
-using MNM = Microsoft.Azure.Management.Network.Models;
 
 namespace Microsoft.Azure.Commands.Network.Bastion
 {
+    using System;
+    using System.Collections.Generic;
+    using System.Net;
+
+    using Microsoft.Azure.Commands.Network.Models;
+    using Microsoft.Azure.Commands.Network.Models.Bastion;
+    using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
+    using Microsoft.Azure.Management.Network;
+    using MNM = Management.Network.Models;
+
     public abstract class BastionBaseCmdlet : NetworkBaseCmdlet
     {
         public IBastionHostsOperations BastionClient
@@ -46,20 +56,38 @@ public bool IsResourcePresent(string resourceGroupName, string name)
             {
                 GetBastion(resourceGroupName, name);
             }
-            catch (Microsoft.Rest.Azure.CloudException exception)
+            catch (Rest.Azure.CloudException exception)
             {
                 if (exception.Response.StatusCode == HttpStatusCode.NotFound)
                 {
                     // Resource is not present
                     return false;
                 }
-
                 throw;
             }
 
             return true;
         }
 
+        public bool TryGetBastion(string resourceGroupName, string name, out PSBastion psBastion)
+        {
+            psBastion = null;
+            try
+            {
+                psBastion = GetBastion(resourceGroupName, name);
+            }
+            catch (Rest.Azure.CloudException exception)
+            {
+                if (exception.Response.StatusCode == HttpStatusCode.NotFound)
+                {
+                    // Resource is not present
+                    return false;
+                }
+                throw;
+            }
+            return true;
+        }
+
         public PSBastion GetBastion(string resourceGroupName, string name)
         {
             var bastion = this.BastionClient.Get(resourceGroupName, name);
@@ -69,6 +97,11 @@ public PSBastion GetBastion(string resourceGroupName, string name)
             psBastion.Sku.Name = bastion.Sku.Name;
             psBastion.ScaleUnit = bastion.ScaleUnits;
             psBastion.Tag = TagsConversionHelper.CreateTagHashtable(bastion.Tags);
+            psBastion.EnableKerberos = bastion.EnableKerberos;
+            psBastion.DisableCopyPaste = bastion.DisableCopyPaste;
+            psBastion.EnableTunneling = bastion.EnableTunneling;
+            psBastion.EnableIpConnect = bastion.EnableIpConnect;
+            psBastion.EnableShareableLink = bastion.EnableShareableLink;
 
             return psBastion;
         }
@@ -79,6 +112,11 @@ public PSBastion ToPsBastion(MNM.BastionHost host)
             bastion.Sku.Name = host.Sku.Name;
             bastion.ScaleUnit = host.ScaleUnits;
             bastion.Tag = TagsConversionHelper.CreateTagHashtable(host.Tags);
+            bastion.EnableKerberos = bastion.EnableKerberos;
+            bastion.DisableCopyPaste = host.DisableCopyPaste;
+            bastion.EnableTunneling = host.EnableTunneling;
+            bastion.EnableIpConnect = host.EnableIpConnect;
+            bastion.EnableShareableLink = host.EnableShareableLink;
 
             return bastion;
         }
@@ -95,12 +133,105 @@ public List<PSBastion> ListBastions(string resourceGroupName)
                 foreach (MNM.BastionHost bastion in bastions)
                 {
                     PSBastion bastionToReturn = ToPsBastion(bastion);
-                    bastionToReturn.ResourceGroupName = NetworkBaseCmdlet.GetResourceGroup(bastion.Id);
+                    bastionToReturn.ResourceGroupName = GetResourceGroup(bastion.Id);
                     bastionsToReturn.Add(bastionToReturn);
                 }
             }
 
             return bastionsToReturn;
         }
+
+        public bool IsSkuDowngrade(PSBastion bastion, string sku)
+        {
+            if (PSBastionSku.TryGetSkuTier(sku, out string newSkuTier)
+                && PSBastionSku.TryGetSkuTier(bastion.Sku.Name, out string existingSkuTier))
+            {
+                switch (existingSkuTier)
+                {
+                    case PSBastionSku.Basic:
+                        return false;
+                    // Standard -> Basic
+                    case PSBastionSku.Standard:
+                        if (newSkuTier == PSBastionSku.Basic)
+                        {
+                            return true;
+                        }
+                        return false;
+                    default:
+                        return true;
+                }
+            }
+
+            return true;
+        }
+
+        public void ValidateScaleUnits(PSBastion bastion, int? scaleUnits = 2)
+        {
+            if (PSBastionSku.TryGetSkuTier(bastion.Sku.Name, out string skuTierValue))
+            {
+                switch (skuTierValue)
+                {
+                    case PSBastionSku.Basic:
+                        if (scaleUnits != PSBastion.MinimumScaleUnits)
+                        {
+                            throw new ArgumentException($"Bastion scalable host is available on Standard SKU");
+                        }
+                        break;
+                    case PSBastionSku.Standard:
+                        if (scaleUnits < PSBastion.MinimumScaleUnits
+                            || scaleUnits > PSBastion.MaximumScaleUnits)
+                        {
+                            throw new ArgumentException($"Please select scale units value between {PSBastion.MinimumScaleUnits} and {PSBastion.MaximumScaleUnits}");
+                        }
+                        break;
+                    default:
+                        throw new ArgumentException($"Please enter a valid value for Bastion SKU");
+                }
+            }
+            else
+            {
+                throw new ArgumentException($"Please enter a valid value for Bastion SKU");
+            }
+        }
+
+        public void ValidateFeatures(PSBastion bastion,
+            bool? disableCopyPaste = false,
+            bool? enableTunneling = false,
+            bool? enableIpConnect = false,
+            bool? enableShareableLink = false)
+        {
+            if (PSBastionSku.TryGetSkuTier(bastion.Sku.Name, out string skuTierValue))
+            {
+                switch (skuTierValue)
+                {
+                    case PSBastionSku.Basic:
+                        if (disableCopyPaste != null && disableCopyPaste != false)
+                        {
+                            throw new ArgumentException($"Toggling copy/paste is available on Standard SKU or higher");
+                        }
+                        if (enableTunneling != null && enableTunneling != false)
+                        {
+                            throw new ArgumentException($"Toggling tunneling is available on Standard SKU or higher");
+                        }
+                        if (enableIpConnect != null && enableIpConnect != false)
+                        {
+                            throw new ArgumentException($"Toggling IP connect is available on Standard SKU or higher");
+                        }
+                        if (enableShareableLink != null && enableShareableLink != false)
+                        {
+                            throw new ArgumentException($"Toggling shareable link is available on Standard SKU or higher");
+                        }
+                        break;
+                    case PSBastionSku.Standard:
+                        break;
+                    default:
+                        throw new ArgumentException($"Please enter a valid value for Bastion SKU");
+                }
+            }
+            else
+            {
+                throw new ArgumentException($"Please enter a valid value for Bastion SKU");
+            }
+        }
     }
 }

src/Network/Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.BastionTests/TestBastionCRUD.json

@@ -12,16 +12,16 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------
 
-
 namespace Microsoft.Azure.Commands.Network.Bastion
 {
+    using System;
+    using System.Collections.Generic;
+    using System.Management.Automation;
+
     using Microsoft.Azure.Commands.Network.Models;
     using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
     using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
     using Microsoft.Azure.Management.Network.Models;
-    using System;
-    using System.Collections.Generic;
-    using System.Management.Automation;
 
     [Cmdlet(VerbsCommon.Get,
          ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "Bastion",
@@ -66,14 +66,14 @@ public override void Execute()
             {
                 WriteObject(this.GetBastion(this.ResourceGroupName, this.Name));
             }
-            else if ((ParameterSetName.Equals(BastionParameterSetNames.ByResourceId, StringComparison.OrdinalIgnoreCase)))
+            else if (ParameterSetName.Equals(BastionParameterSetNames.ByResourceId, StringComparison.OrdinalIgnoreCase))
             {
                 var parsedResourceId = new ResourceIdentifier(this.ResourceId);
                 this.Name = parsedResourceId.ResourceName;
                 this.ResourceGroupName = parsedResourceId.ResourceGroupName;
                 WriteObject(this.GetBastion(this.ResourceGroupName, this.Name));
             }
-            else 
+            else
             {
                 WriteObject(TopLevelWildcardFilter(ResourceGroupName, Name, this.ListBastions(this.ResourceGroupName)), true);
             }