Fix the issue that core tests are not included when TestsToRun equals to All (#27273)

Author: vidai-msft

tools/BuildScripts/BuildModules.ps1

@@ -11,17 +11,17 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 # ----------------------------------------------------------------------------------
-[CmdletBinding(DefaultParameterSetName="AllSet")]
+[CmdletBinding(DefaultParameterSetName = "AllSet")]
 param (
     [string]$RepoRoot,
     [string]$Configuration = 'Debug',
-    [Parameter(ParameterSetName="AllSet")]
+    [Parameter(ParameterSetName = "AllSet")]
     [string]$TestsToRun = 'All',
-    [Parameter(ParameterSetName="CIPlanSet", Mandatory=$true)]
+    [Parameter(ParameterSetName = "CIPlanSet", Mandatory = $true)]
     [switch]$CIPlan,
-    [Parameter(ParameterSetName="ModifiedModuleSet", Mandatory=$true)]
+    [Parameter(ParameterSetName = "ModifiedModuleSet", Mandatory = $true)]
     [switch]$ModifiedModule,
-	[Parameter(ParameterSetName="TargetModuleSet", Mandatory=$true)]
+    [Parameter(ParameterSetName = "TargetModuleSet", Mandatory = $true)]
     [string[]]$TargetModule,
     [switch]$ForceRegenerate,
     [switch]$InvokedByPipeline,
@@ -51,7 +51,8 @@ Import-Module $BuildScriptsModulePath
 
 if (-not (Test-Path $sourceDirectory)) {
     Write-Warning "Cannot find source directory: $sourceDirectory"
-} elseif (-not (Test-Path $generatedDirectory)) {
+}
+elseif (-not (Test-Path $generatedDirectory)) {
     Write-Warning "Cannot find generated directory: $generatedDirectory"
 }
 
@@ -72,20 +73,22 @@ switch ($PSCmdlet.ParameterSetName) {
         }
         if ('Core' -eq $TestsToRun) {
             $testModule = $coreTestModule
-        } elseif ('NonCore') {
-            $testModule = $TargetModule | Where-Object { $_ -notin $coreTestModule}
-        } else {
+        }
+        elseif ('NonCore' -eq $TestsToRun) {
+            $testModule = $TargetModule | Where-Object { $_ -notin $coreTestModule }
+        }
+        else {
             $testModule = $TargetModule
         }
     }
     'CIPlanSet' {
         $CIPlanPath = Join-Path $RepoArtifacts "PipelineResult" "CIPlan.json"
         If (Test-Path $CIPlanPath) {
             $CIPlanContent = Get-Content $CIPlanPath | ConvertFrom-Json
-            foreach($build in $CIPlanContent.build) {
+            foreach ($build in $CIPlanContent.build) {
                 $TargetModule += $build
             }
-            foreach($test in $CIPlanContent.test) {
+            foreach ($test in $CIPlanContent.test) {
                 $testModule += $test
             }
         }
@@ -100,7 +103,8 @@ switch ($PSCmdlet.ParameterSetName) {
                 if ($line -match "^##\s\d+\.\d+\.\d+") {
                     if ($continueReading) {
                         break
-                    } else {
+                    }
+                    else {
                         $continueReading = $true
                     }
                 }
@@ -110,11 +114,11 @@ switch ($PSCmdlet.ParameterSetName) {
             }
         }
         $testModule = $TargetModule
-        Write-Host  "----------Start building modified modules----------`r`n$($TargetModule | Join-String -Separator "`r`n")" -ForegroundColor DarkYellow
+        Write-Host "----------Start building modified modules----------`r`n$($TargetModule | Join-String -Separator "`r`n")" -ForegroundColor DarkYellow
     }
     'TargetModuleSet' {
         $testModule = $TargetModule
-        Write-Host  "----------Start building target modules----------`r`n$($TargetModule | Join-String -Separator "`r`n")" -ForegroundColor DarkYellow
+        Write-Host "----------Start building target modules----------`r`n$($TargetModule | Join-String -Separator "`r`n")" -ForegroundColor DarkYellow
     }
 }
 
@@ -155,7 +159,8 @@ Write-Output "Modules are added to build sln file"
 $LogFile = Join-Path $RepoArtifacts 'Build.log'
 if ('Release' -eq $Configuration) {
     $BuildAction = 'publish'
-} else {
+}
+else {
     $BuildAction = 'build'
 
     $testCsprojFiles = Get-CsprojFromModule -TestModuleList $testModule -RepoRoot $RepoRoot -Configuration $Configuration
@@ -171,12 +176,10 @@ if ('Release' -eq $Configuration) {
 }
 
 $buildCmdResult = "dotnet $BuildAction $Buildsln -c $Configuration -fl '/flp1:logFile=$LogFile;verbosity=quiet'"
-If ($GenerateDocumentationFile -eq "false")
-{
+If ($GenerateDocumentationFile -eq "false") {
     $buildCmdResult += " -p:GenerateDocumentationFile=false"
 }
-if ($EnableTestCoverage -eq "true")
-{
+if ($EnableTestCoverage -eq "true") {
     $buildCmdResult += " -p:TestCoverage=TESTCOVERAGE"
 }
 Invoke-Expression -Command $buildCmdResult
@@ -188,4 +191,4 @@ $removeScriptPath = Join-Path $toolDirectory 'BuildScripts' 'RemoveUnwantedFiles
 & $removeScriptPath -RootPath (Join-Path $RepoArtifacts $Configuration) -CodeSign $CodeSign
 
 $updateModuleScriptPath = Join-Path $toolDirectory 'UpdateModules.ps1'
-pwsh $updateModuleScriptPath -BuildConfig $Configuration -Scope $Scope
+pwsh $updateModuleScriptPath -BuildConfig $Configuration -Scope $Scope