Skip to content

Commit 2c61475

Browse files
authored
add breaking changes information for SqlVirtualMachine (#21265)
* add breaking changes for SqlVirtualMachine * update changelog for breaking changes of sqlvm
1 parent aa7e500 commit 2c61475

File tree

10 files changed

+25
-2
lines changed

10 files changed

+25
-2
lines changed

src/SqlVirtualMachine/SqlVirtualMachine/AvailabilityGroupListener/Cmdlet/AzureAvailabilityGroupListenerCmdletBase.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
using System.Management.Automation;
2020
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
2121
using System.Text.RegularExpressions;
22+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2223

2324
namespace Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Cmdlet
2425
{
@@ -51,6 +52,7 @@ public abstract class AzureAvailabilityGroupListenerCmdletBase : AzureSqlVirtual
5152
/// <summary>
5253
/// SqlVmGroup Object of the AG Listener
5354
/// </summary>
55+
[CmdletParameterBreakingChange("SqlVMGroupObject", ChangeDescription = "SqlVMGroupObject parameter is being deprecated without being replaced.")]
5456
[Parameter(
5557
Mandatory = true,
5658
ParameterSetName = ParameterSet.SqlVMGroupObject,

src/SqlVirtualMachine/SqlVirtualMachine/AvailabilityGroupListener/Cmdlet/UpdateAzureAvailabilityGroupListener.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,15 @@
1818
using Microsoft.Azure.Commands.SqlVirtualMachine.Common;
1919
using Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Model;
2020
using Microsoft.Azure.Management.SqlVirtualMachine.Models;
21+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2122

2223
namespace Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Cmdlet
2324
{
2425
/// <summary>
2526
/// This class implements the Update-AzAvailabilityGroupListener cmdlet. It allows to update the information relative to an Azure Sql Virtual Machine
2627
/// Group and return to the user an AzureAvailabilityGroupListenerModel object corresponding to the instance updated.
2728
/// </summary>
29+
[CmdletDeprecation()]
2830
[Cmdlet(VerbsData.Update, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "AvailabilityGroupListener", DefaultParameterSetName = ParameterSet.Name, SupportsShouldProcess = true)]
2931
[OutputType(typeof(AzureAvailabilityGroupListenerModel))]
3032
public class UpdateAzureAvailabilityGroupListener : AzureAvailabilityGroupListenerUpsertCmdletBase

src/SqlVirtualMachine/SqlVirtualMachine/ChangeLog.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,14 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Added breaking change notification for cmdlets to be removed and parameters to be changed.
22+
* Cmdlet `New-AzSqlVMConfig` will be removed.
23+
* Cmdlet `Set-AzSqlVMConfigGroup` will be removed.
24+
* Cmdlet `Update-AzAvailabilityGroupListener` will be removed.
25+
* Parameter `SqlVM` will be removed from cmdlet `New-AzSqlVM`.
26+
* Parameter `SqlVMGroupObject` will be removed from cmdlet `Get-AzAvailabilityGroupListener` and `Remove-AzAvailabilityGroupListener`.
27+
* Parameter alias `SqlVM` will be removed from `InputObject` of cmdlet `Remove-AzSqlVM`.
28+
* Parameter alias `SqlVMGroup` will be removed from `InputObject` of cmdlet `Update-AzSqlVMGroup` and `Remove-AzSqlVMGroup`.
2129
* Added breaking change notification for SqlManagementType
2230

2331
## Version 1.1.0

src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachine/Cmdlet/Config/NewAzureSqlVMConfig.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
using Microsoft.Azure.Commands.SqlVirtualMachine.Common;
1717
using Microsoft.Azure.Commands.SqlVirtualMachine.Common.ArgumentCompleters;
1818
using Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Model;
19+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
1920
using System.Collections.Generic;
2021
using System.Linq;
2122
using System.Management.Automation;
@@ -27,6 +28,7 @@ namespace Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Cmdlet.Co
2728
/// This class implements the New-AzVMConfig cmdlet. It will create a local AzureSqlVMModel powershell object that can be used as configuration settings
2829
/// for the creation of a sql virtual machine on Azure.
2930
/// </summary>
31+
[CmdletDeprecation()]
3032
[Cmdlet(VerbsCommon.New, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "SqlVMConfig", DefaultParameterSetName = NameParameterList, SupportsShouldProcess = true)]
3133
[OutputType(typeof(AzureSqlVMModel))]
3234
public class NewAzureSqlVMConfig : AzureSqlVMUpsertCmdletBase

src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachine/Cmdlet/Config/SetAzureSqlVMConfigGroup.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
using Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Model;
2222
using Microsoft.Azure.Management.SqlVirtualMachine.Models;
2323
using Microsoft.WindowsAzure.Commands.Common;
24+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2425

2526
namespace Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Cmdlet.Config
2627
{
@@ -29,6 +30,7 @@ namespace Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Cmdlet.Co
2930
/// Sql Virtual Machine group to the local copy of the powershell object. It returns an instance of AzureSqlVMModel that can be used as configuration
3031
/// for an Azure Sql Virtual Machine.
3132
/// </summary>
33+
[CmdletDeprecation()]
3234
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "SqlVMConfigGroup", SupportsShouldProcess = true)]
3335
[OutputType(typeof(AzureSqlVMModel))]
3436
public class SetAzureSqlVMConfigGroup : AzureSqlVirtualMachineCmdletBase<IEnumerable<AzureSqlVMModel>, AzureSqlVMAdapter>

src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachine/Cmdlet/NewAzureSqlVM.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ public class NewAzureSqlVM : AzureSqlVMUpsertCmdletBase
6969
/// Sql virtual machine to be updated
7070
/// </summary>
7171
[CmdletParameterBreakingChange("SqlManagementType", ChangeDescription = "SqlManagementType parameter is being deprecated")]
72+
[CmdletParameterBreakingChange("SqlVM", ChangeDescription = "SqlVM parameter is being deprecated without being replaced.")]
7273
[Parameter(Mandatory = true,
7374
ParameterSetName = NameInputObject,
7475
ValueFromPipeline = true,

src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachine/Cmdlet/RemoveAzureSqlVM.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,11 @@ public class RemoveAzureSqlVM : AzureSqlVMCmdletBase
5151
[Alias("SqlVMName")]
5252
[ResourceNameCompleter("Microsoft.SqlVirtualMachine/SqlVirtualMachines", "ResourceGroupName")]
5353
public virtual string Name { get; set; }
54-
54+
5555
/// <summary>
5656
/// Sql virtual machine resource to be removed
5757
/// </summary>
58+
[CmdletParameterBreakingChange("InputObject", ChangeDescription = "InputObject parameter alias 'SqlVM' will be removed.")]
5859
[Parameter(Mandatory = true,
5960
ParameterSetName = ParameterSet.InputObject,
6061
ValueFromPipeline = true,

src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachine/Cmdlet/UpdateAzureSqlVM.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
using Microsoft.Azure.Commands.SqlVirtualMachine.Common;
2323
using Microsoft.Azure.Commands.SqlVirtualMachine.Common.ArgumentCompleters;
2424
using Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Model;
25-
using static Microsoft.Azure.Commands.SqlVirtualMachine.Common.ParameterSet;
2625
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
26+
using static Microsoft.Azure.Commands.SqlVirtualMachine.Common.ParameterSet;
2727

2828
namespace Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Cmdlet
2929
{
@@ -129,6 +129,7 @@ public class UpdateAzureSqlVM : AzureSqlVMUpsertCmdletBase
129129
/// <summary>
130130
/// Sql virtual machine to be updated
131131
/// </summary>
132+
[CmdletParameterBreakingChange("InputObject", ChangeDescription = "InputObject parameter alias 'SqlVM' will be removed.")]
132133
[Parameter(Mandatory = true,
133134
ParameterSetName = NameInputObject,
134135
ValueFromPipeline = true,

src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachineGroup/Cmdlet/RemoveAzureSqlVMGroup.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
using System.Management.Automation;
1717
using Microsoft.Azure.Commands.SqlVirtualMachine.Common;
1818
using Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Model;
19+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
1920

2021

2122
namespace Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Cmdlet
@@ -31,6 +32,7 @@ public class RemoveAzureSqlVMGroup : AzureSqlVMGroupCmdletBase
3132
/// <summary>
3233
/// Sql virtual machine group resource to be removed
3334
/// </summary>
35+
[CmdletParameterBreakingChange("InputObject", ChangeDescription = "InputObject parameter alias 'SqlVMGroup' will be removed.")]
3436
[Parameter(Mandatory = true,
3537
ParameterSetName = ParameterSet.InputObject,
3638
Position = 0,

src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachineGroup/Cmdlet/UpdateAzureSqlVMGroup.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
using Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Model;
2121
using Microsoft.Azure.Management.SqlVirtualMachine.Models;
2222
using Microsoft.WindowsAzure.Commands.Common;
23+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2324

2425
namespace Microsoft.Azure.Commands.SqlVirtualMachine.SqlVirtualMachine.Cmdlet
2526
{
@@ -34,6 +35,7 @@ public class UpdateAzureSqlVMGroup : AzureSqlVMGroupUpsertCmdletBase
3435
/// <summary>
3536
/// Sql virtual machine group to be updated
3637
/// </summary>
38+
[CmdletParameterBreakingChange("InputObject", ChangeDescription = "InputObject parameter alias 'SqlVMGroup' will be removed.")]
3739
[Parameter(Mandatory = true,
3840
ParameterSetName = ParameterSet.InputObject,
3941
ValueFromPipeline = true,

0 commit comments

Comments
 (0)