fix parsing bug (#13142)

* fix parsing bug

* add default values

Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>

Author: 3 people

src/Resources/Resources/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fixed parsing bug
 * Updated ARM template What-If cmdlets to remove preview message from results
 * Fixed an issue where template deployment cmdlets crash if `-WhatIf` is set at a higher scope [#13038]
 * Fixed an issue where template deployment cmdlets does not preserve case for template parameters

src/Resources/Resources/RoleAssignments/NewAzureRoleAssignmentCommand.cs

@@ -184,7 +184,7 @@ public class NewAzureRoleAssignmentCommand : ResourcesBaseCmdlet
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.ScopeWithSPN,
             HelpMessage = "Condition to be applied to the RoleAssignment.")]
         [ValidateNotNullOrEmpty]
-        public string Condition { get; set; }
+        public string Condition { get; set; } = null;
 
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.Empty,
             HelpMessage = "Version of the condition.")]
@@ -207,7 +207,7 @@ public class NewAzureRoleAssignmentCommand : ResourcesBaseCmdlet
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.ScopeWithSPN,
             HelpMessage = "Version of the condition.")]
         [ValidateNotNullOrEmpty]
-        public string ConditionVersion { get; set; }
+        public string ConditionVersion { get; set; } = null;
 
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.RoleIdWithScopeAndObjectId,
             HelpMessage = "Role Id the principal is assigned to.")]
@@ -245,7 +245,7 @@ public override void ExecuteCmdlet()
                     this.ResourceType = RoleAssignment.ObjectType;
                     this.Scope = RoleAssignment.Scope;
                     Guid guid = Guid.Empty;
-                    Guid.TryParse(RoleAssignment.RoleDefinitionId,out guid);
+                    Guid.TryParse(RoleAssignment.RoleDefinitionId, out guid);
                     this.RoleDefinitionId = guid;
                     this.Description = RoleAssignment.Description;
                     this.Condition = RoleAssignment.Condition;
@@ -271,7 +271,9 @@ public override void ExecuteCmdlet()
                 }
 
             }
-            double _conditionVersion = double.Parse((ConditionVersion ?? "2.0"));
+            // ensure that if ConditionVersion is empty in any way, it becomes null
+            ConditionVersion = string.IsNullOrEmpty(ConditionVersion) ? null : string.IsNullOrWhiteSpace(ConditionVersion) ? null : ConditionVersion; 
+            double _conditionVersion = double.Parse(ConditionVersion ?? "2.0");
             if (_conditionVersion < 2.0)
             {
                 WriteExceptionError(new ArgumentException("Argument -ConditionVersion must be greater or equal than 2.0"));