[Az.ElasticSan]Update warning for data integration check in new/create volume group cmdlets (#28002)

Author: EmmaZhu

src/ElasticSan/ElasticSan.Autorest/Properties/AssemblyInfo.cs

@@ -20,7 +20,7 @@
 [assembly: System.Reflection.AssemblyCopyrightAttribute("Copyright © Microsoft")]
 [assembly: System.Reflection.AssemblyProductAttribute("Microsoft Azure PowerShell")]
 [assembly: System.Reflection.AssemblyTitleAttribute("Microsoft Azure PowerShell - ElasticSan")]
-[assembly: System.Reflection.AssemblyFileVersionAttribute("1.2.1")]
-[assembly: System.Reflection.AssemblyVersionAttribute("1.2.1")]
+[assembly: System.Reflection.AssemblyFileVersionAttribute("1.4.0")]
+[assembly: System.Reflection.AssemblyVersionAttribute("1.4.0")]
 [assembly: System.Runtime.InteropServices.ComVisibleAttribute(false)]
 [assembly: System.CLSCompliantAttribute(false)]

src/ElasticSan/ElasticSan.Autorest/custom/New-AzElasticSan.ps1

@@ -97,13 +97,13 @@ param(
     [Parameter()]
     [Microsoft.Azure.PowerShell.Cmdlets.ElasticSan.Category('Body')]
     [System.Int64]
-    # Base size of the Elastic San appliance in TiB. Default vaule is 20.
+    # Base size of the Elastic San appliance in TiB. Default value is 20.
     ${BaseSizeTiB},
 
     [Parameter()]
     [Microsoft.Azure.PowerShell.Cmdlets.ElasticSan.Category('Body')]
     [System.Int64]
-    # Extended size of the Elastic San appliance in TiB. Default vaule is 0.
+    # Extended size of the Elastic San appliance in TiB. Default value is 0.
     ${ExtendedCapacitySizeTiB},
 
     [Parameter()]

src/ElasticSan/ElasticSan.Autorest/custom/New-AzElasticSanVolumeGroup.ps1

@@ -239,8 +239,11 @@ function New-AzElasticSanVolumeGroup {
         $null = $PSBoundParameters.Remove('IdentityUserAssignedIdentityId')
       }
 
-      if (($PSBoundParameters.ContainsKey("EnforceDataIntegrityCheckForIscsi") -eq $false) -or ($PSBoundParameters.EnforceDataIntegrityCheckForIscsi -eq $true)) {
-        Write-Warning "This needs CRC32C to be set on header and data digests on the client for all the connections from the client to the volumes in this volume group. You can do this by connecting to the volumes from the client using multi-session scripts generated in portal connect flow or from documentation, which contain steps to set CRC32C on header and data digests. Do not enable CRC protection on the volume group if you are using Fedora or its downstream Linux distributions such as RHEL, CentOS etc. as data digests are not supported on them. If you enable this flag for those distributions, connectivity to the volumes will fail. Refer to https://learn.microsoft.com/en-us/azure/storage/elastic-san/elastic-san-create?tabs=azure-portal for more information."
+      if (($PSBoundParameters.ContainsKey("EnforceDataIntegrityCheckForIscsi") -eq $true) -and ($PSBoundParameters.EnforceDataIntegrityCheckForIscsi -eq $true)) {
+        Write-Warning "CRC protection feature is not supported for Azure VMware solution (AVS) yet. Do not enable this flag if you plan to use the volumes within this volume group as datastores for AVS, as the datastore creation will fail. For Azure Virtual Machines, enabling this flag would need CRC32C to be set on iSCSI header and data digests on the client for all the connections from the client to the volumes in this volume group. You can achieve that by disconnecting the volumes from the client and reconnecting using multi-session scripts generated in portal connect flow or from documentation, which contain steps to set CRC32C on header and data digests. Do not enable CRC protection on the volume group if you are using Fedora or its downstream Linux distributions such as RHEL, CentOS etc. as data digests are not supported on them. If you enable this flag for those distributions, connectivity to the volumes will fail. Learn more: https://go.microsoft.com/fwlink/?LinkId=2294733&id=Microsoft_Azure_ElasticSan"        
+      }
+      else {
+        Write-Warning "CRC protection is recommended if you plan to connect the volumes in this volume group to Azure Virtual Machines. Do not enable it if you are using Fedora or its downstream Linux distributions such as RHEL, CentOS etc. on your VM, as data digests are not supported on them. If you enable this flag for those distributions, connectivity to the volumes will fail. Also, do not enable this flag if you plan to use the volumes within this volume group as datastores for Azure VMware Solution (AVS), as this feature is not supported for AVS yet and the datastore creation will fail. Learn more: https://go.microsoft.com/fwlink/?LinkId=2294733&id=Microsoft_Azure_ElasticSan"
       }
 
       Az.ElasticSan.internal\New-AzElasticSanVolumeGroup @PSBoundParameters

src/ElasticSan/ElasticSan.Autorest/custom/Update-AzElasticSanVolumeGroup.ps1

@@ -268,8 +268,12 @@ function Update-AzElasticSanVolumeGroup {
         }
 
         if ($PSBoundParameters.ContainsKey("EnforceDataIntegrityCheckForIscsi") -and ($PSBoundParameters.EnforceDataIntegrityCheckForIscsi -eq $true)) {
-            Write-Warning "This needs CRC32C to be set on header and data digests on the client for all the connections from the client to the volumes in this volume group. You can do this by disconnecting the volumes from the client and reconnecting using multi-session scripts generated in portal connect flow or from documentation, which contain steps to set CRC32C on header and data digests. Do not enable CRC protection on the volume group if you are using Fedora or its downstream Linux distributions such as RHEL, CentOS etc. as data digests are not supported on them. If you enable this flag for those distributions, connectivity to the volumes will fail. Refer to https://learn.microsoft.com/en-us/azure/storage/elastic-san/elastic-san-create?tabs=azure-portal for more information."
-          }
+            Write-Warning "CRC protection feature is not supported for Azure VMware solution (AVS) yet. Do not enable this flag if you plan to use the volumes within this volume group as datastores for AVS, as the datastore creation will fail. For Azure Virtual Machines, enabling this flag would need CRC32C to be set on iSCSI header and data digests on the client for all the connections from the client to the volumes in this volume group. You can achieve that by disconnecting the volumes from the client and reconnecting using multi-session scripts generated in portal connect flow or from documentation, which contain steps to set CRC32C on header and data digests. Do not enable CRC protection on the volume group if you are using Fedora or its downstream Linux distributions such as RHEL, CentOS etc. as data digests are not supported on them. If you enable this flag for those distributions, connectivity to the volumes will fail. Learn more: https://go.microsoft.com/fwlink/?LinkId=2294733&id=Microsoft_Azure_ElasticSan"
+        }
+        else {
+            Write-Warning "CRC protection is recommended if you plan to connect the volumes in this volume group to Azure Virtual Machines. Do not enable it if you are using Fedora or its downstream Linux distributions such as RHEL, CentOS etc. on your VM, as data digests are not supported on them. If you enable this flag for those distributions, connectivity to the volumes will fail. Also, do not enable this flag if you plan to use the volumes within this volume group as datastores for Azure VMware Solution (AVS), as this feature is not supported for AVS yet and the datastore creation will fail. Learn more: https://go.microsoft.com/fwlink/?LinkId=2294733&id=Microsoft_Azure_ElasticSan"
+        }
+        
         Az.ElasticSan.internal\Update-AzElasticSanVolumeGroup @PSBoundParameters
     }
 }

src/ElasticSan/ElasticSan.Autorest/docs/Az.ElasticSan.md

@@ -1,6 +1,6 @@
 ---
 Module Name: Az.ElasticSan
-Module Guid: 4ec5915a-3898-41f7-a00b-29a4da49fc64
+Module Guid: ffcb466a-f0cf-4285-bdad-8a1bbeebe0c4
 Download Help Link: https://learn.microsoft.com/powershell/module/az.elasticsan
 Help Version: 1.0.0.0
 Locale: en-US

src/ElasticSan/ElasticSan.Autorest/docs/New-AzElasticSan.md

@@ -131,7 +131,7 @@ Accept wildcard characters: False
 
 ### -BaseSizeTiB
 Base size of the Elastic San appliance in TiB.
-Default vaule is 20.
+Default value is 20.
 
 ```yaml
 Type: System.Int64
@@ -163,7 +163,7 @@ Accept wildcard characters: False
 
 ### -ExtendedCapacitySizeTiB
 Extended size of the Elastic San appliance in TiB.
-Default vaule is 0.
+Default value is 0.
 
 ```yaml
 Type: System.Int64

src/ElasticSan/ElasticSan.Autorest/docs/Remove-AzElasticSanVolumeGroupNetworkRule.md

@@ -33,7 +33,7 @@ Remove a list of virtual network rules from a VolumeGroup
 
 ### Example 1: Remove network rules by NetworkAclsVirtualNetworkRule objects  
 ```powershell
-# Initialze network rule objects 
+# Initialize network rule objects 
 $virtualNetworkRule1 =  New-AzElasticSanVirtualNetworkRuleObject -VirtualNetworkResourceId  "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/myresourcegroup/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/subnet1" -Action Allow
 $virtualNetworkRule2 =  New-AzElasticSanVirtualNetworkRuleObject -VirtualNetworkResourceId  "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/myresourcegroup/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/subnet2" -Action Allow
 $virtualNetworkRule3 =  New-AzElasticSanVirtualNetworkRuleObject -VirtualNetworkResourceId  "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/myresourcegroup/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/subnet3" -Action Allow

src/ElasticSan/ElasticSan.Autorest/docs/Update-AzElasticSanVolumeGroup.md

@@ -72,7 +72,7 @@ SystemDataLastModifiedByType           : Application
 Type                                   : Microsoft.ElasticSan/ElasticSans
 ```
 
-This example updates the protocol type and virtual network rules of a volume gorup
+This example updates the protocol type and virtual network rules of a volume group
 
 ### Example 2: Update a volume group virtual network rule with JSON input 
 ```powershell

src/ElasticSan/ElasticSan.Autorest/examples/Remove-AzElasticSanVolumeGroupNetworkRule.md

@@ -1,6 +1,6 @@
 ### Example 1: Remove network rules by NetworkAclsVirtualNetworkRule objects  
 ```powershell
-# Initialze network rule objects 
+# Initialize network rule objects 
 $virtualNetworkRule1 =  New-AzElasticSanVirtualNetworkRuleObject -VirtualNetworkResourceId  "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/myresourcegroup/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/subnet1" -Action Allow
 $virtualNetworkRule2 =  New-AzElasticSanVirtualNetworkRuleObject -VirtualNetworkResourceId  "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/myresourcegroup/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/subnet2" -Action Allow
 $virtualNetworkRule3 =  New-AzElasticSanVirtualNetworkRuleObject -VirtualNetworkResourceId  "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/myresourcegroup/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/subnet3" -Action Allow

src/ElasticSan/ElasticSan.Autorest/examples/Update-AzElasticSanVolumeGroup.md

@@ -23,7 +23,7 @@ SystemDataLastModifiedByType           : Application
 Type                                   : Microsoft.ElasticSan/ElasticSans
 ```
 
-This example updates the protocol type and virtual network rules of a volume gorup
+This example updates the protocol type and virtual network rules of a volume group
 
 ### Example 2: Update a volume group virtual network rule with JSON input 
 ```powershell