Updating sfmc to latest api preview version (2023-11-01-preview) (#23510)

* updating sfmc to latest api preview version

* Adding breaking change csv file

* Update ChangeLog.md

---------

Co-authored-by: NoriZC <[email protected]>

Author: mwesigwaguma

src/ServiceFabric/ServiceFabric/ChangeLog.md

@@ -19,6 +19,7 @@
 -->
 ## Upcoming Release
 * Fixed a bug that Get commands do not return all resources.
+* Updated sfmc to latest api preview version `2023-11-01-preview`.
 
 ## Version 3.3.0
 * Fixed minor issues

src/ServiceFabric/ServiceFabricManagedClusters.Management.Sdk/Generated/ApplicationTypesOperations.cs

@@ -268,8 +268,11 @@ internal ApplicationTypesOperations (ServiceFabricManagementClient client)
         /// <param name='applicationTypeName'>
         /// The name of the application type name resource.
         /// </param>
-        /// /// <param name='parameters'>
-        /// The application type name resource.
+        /// <param name='location'>
+        /// Resource location depends on the parent resource.
+        /// </param>
+        /// <param name='tags'>
+        /// Azure resource tags.
         /// </param>
         /// <param name='customHeaders'>
         /// Headers that will be added to request.

src/ServiceFabric/ServiceFabricManagedClusters.Management.Sdk/Generated/ApplicationTypesOperationsExtensions.cs

@@ -76,7 +76,7 @@ public static ApplicationTypeResource Get(this IApplicationTypesOperations opera
         /// </param>
         public static ApplicationTypeResource CreateOrUpdate(this IApplicationTypesOperations operations, string resourceGroupName, string clusterName, string applicationTypeName, string id = default(string), string name = default(string), string type = default(string), string location = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), SystemData systemData = default(SystemData), string provisioningState = default(string))
         {
-                return ((IApplicationTypesOperations)operations).CreateOrUpdateAsync(resourceGroupName, clusterName, applicationTypeName, id, name, type, location, tags, systemData, provisioningState).GetAwaiter().GetResult();
+            return ((IApplicationTypesOperations)operations).CreateOrUpdateAsync(resourceGroupName, clusterName, applicationTypeName, id, name, type, location, tags, systemData, provisioningState).GetAwaiter().GetResult();
         }
 
         /// <summary>

src/ServiceFabric/ServiceFabricManagedClusters.Management.Sdk/Generated/IApplicationTypesOperations.cs

@@ -57,8 +57,11 @@ public partial interface IApplicationTypesOperations
         /// <param name='applicationTypeName'>
         /// The name of the application type name resource.
         /// </param>
-        /// /// /// <param name='parameters'>
-        /// The application type name resource.
+        /// <param name='location'>
+        /// Resource location depends on the parent resource.
+        /// </param>
+        /// <param name='tags'>
+        /// Azure resource tags.
         /// </param>
         /// <param name='customHeaders'>
         /// The headers that will be added to request.

src/ServiceFabric/ServiceFabricManagedClusters.Management.Sdk/Generated/Models/ApplicationTypeVersionResource.cs

@@ -50,7 +50,7 @@ public ApplicationTypeVersionResource()
 
         /// <param name="appPackageUrl">The URL to the application package
         /// </param>
-        public ApplicationTypeVersionResource(string appPackageUrl, string id = default(string), string name = default(string), string type = default(string), string location = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), SystemData systemData = default(SystemData), string provisioningState = default(string))
+        public ApplicationTypeVersionResource(string id = default(string), string name = default(string), string type = default(string), string location = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), SystemData systemData = default(SystemData), string provisioningState = default(string), string appPackageUrl = default(string))
 
         : base(id, name, type, location, tags, systemData)
         {

src/ServiceFabric/ServiceFabricManagedClusters.Management.Sdk/Generated/Models/ManagedCluster.cs

@@ -177,7 +177,7 @@ public ManagedCluster()
         /// <param name="publicIPPrefixId">Specify the resource id of a public IP prefix that the load balancer will
         /// allocate a public IP address from. Only supports IPv4.
         /// </param>
-        public ManagedCluster(string location, string dnsName, string adminUserName, Sku sku, string id = default(string), string name = default(string), string type = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), string etag = default(string), SystemData systemData = default(SystemData), string fqdn = default(string), string ipv4Address = default(string), string clusterId = default(string), string clusterState = default(string), System.Collections.Generic.IList<string> clusterCertificateThumbprints = default(System.Collections.Generic.IList<string>), int? clientConnectionPort = default(int?), int? httpGatewayConnectionPort = default(int?), string adminPassword = default(string), System.Collections.Generic.IList<LoadBalancingRule> loadBalancingRules = default(System.Collections.Generic.IList<LoadBalancingRule>), bool? allowRdpAccess = default(bool?), System.Collections.Generic.IList<NetworkSecurityRule> networkSecurityRules = default(System.Collections.Generic.IList<NetworkSecurityRule>), System.Collections.Generic.IList<ClientCertificate> clients = default(System.Collections.Generic.IList<ClientCertificate>), AzureActiveDirectory azureActiveDirectory = default(AzureActiveDirectory), System.Collections.Generic.IList<SettingsSectionDescription> fabricSettings = default(System.Collections.Generic.IList<SettingsSectionDescription>), string provisioningState = default(string), string clusterCodeVersion = default(string), string clusterUpgradeMode = default(string), string clusterUpgradeCadence = default(string), System.Collections.Generic.IList<string> addonFeatures = default(System.Collections.Generic.IList<string>), bool? enableAutoOSUpgrade = default(bool?), bool? zonalResiliency = default(bool?), ApplicationTypeVersionsCleanupPolicy applicationTypeVersionsCleanupPolicy = default(ApplicationTypeVersionsCleanupPolicy), bool? enableIpv6 = default(bool?), string subnetId = default(string), System.Collections.Generic.IList<IPTag> ipTags = default(System.Collections.Generic.IList<IPTag>), string ipv6Address = default(string), bool? enableServicePublicIP = default(bool?), System.Collections.Generic.IList<Subnet> auxiliarySubnets = default(System.Collections.Generic.IList<Subnet>), System.Collections.Generic.IList<ServiceEndpoint> serviceEndpoints = default(System.Collections.Generic.IList<ServiceEndpoint>), string zonalUpdateMode = default(string), bool? useCustomVnet = default(bool?), string publicIPPrefixId = default(string))
+        public ManagedCluster(string location, Sku sku, string id = default(string), string name = default(string), string type = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), string etag = default(string), SystemData systemData = default(SystemData), string clusterState = default(string), string dnsName = default(string), string fqdn = default(string), string ipv4Address = default(string), string clusterId = default(string), System.Collections.Generic.IList<string> clusterCertificateThumbprints = default(System.Collections.Generic.IList<string>), int? clientConnectionPort = default(int?), int? httpGatewayConnectionPort = default(int?), string adminUserName = default(string), string adminPassword = default(string), System.Collections.Generic.IList<LoadBalancingRule> loadBalancingRules = default(System.Collections.Generic.IList<LoadBalancingRule>), bool? allowRdpAccess = default(bool?), System.Collections.Generic.IList<NetworkSecurityRule> networkSecurityRules = default(System.Collections.Generic.IList<NetworkSecurityRule>), System.Collections.Generic.IList<ClientCertificate> clients = default(System.Collections.Generic.IList<ClientCertificate>), AzureActiveDirectory azureActiveDirectory = default(AzureActiveDirectory), System.Collections.Generic.IList<SettingsSectionDescription> fabricSettings = default(System.Collections.Generic.IList<SettingsSectionDescription>), string provisioningState = default(string), string clusterCodeVersion = default(string), string clusterUpgradeMode = default(string), string clusterUpgradeCadence = default(string), System.Collections.Generic.IList<string> addonFeatures = default(System.Collections.Generic.IList<string>), bool? enableAutoOSUpgrade = default(bool?), bool? zonalResiliency = default(bool?), ApplicationTypeVersionsCleanupPolicy applicationTypeVersionsCleanupPolicy = default(ApplicationTypeVersionsCleanupPolicy), bool? enableIpv6 = default(bool?), string subnetId = default(string), System.Collections.Generic.IList<IPTag> ipTags = default(System.Collections.Generic.IList<IPTag>), string ipv6Address = default(string), bool? enableServicePublicIP = default(bool?), System.Collections.Generic.IList<Subnet> auxiliarySubnets = default(System.Collections.Generic.IList<Subnet>), System.Collections.Generic.IList<ServiceEndpoint> serviceEndpoints = default(System.Collections.Generic.IList<ServiceEndpoint>), string zonalUpdateMode = default(string), bool? useCustomVnet = default(bool?), string publicIPPrefixId = default(string))
 
         : base(location, id, name, type, tags, etag, systemData)
         {

src/ServiceFabric/ServiceFabricManagedClusters.Management.Sdk/Generated/Models/ManagedClusterCodeVersionResult.cs

@@ -42,7 +42,7 @@ public ManagedClusterCodeVersionResult()
 
         /// <param name="supportExpiryUtc">The date of expiry of support of the version.
         /// </param>
-        public ManagedClusterCodeVersionResult(string id = default(string), string name = default(string), string type = default(string), string clusterCodeVersion = default(string), string supportExpiryUtc = default(string), string osType = default(string))
+        public ManagedClusterCodeVersionResult(string id = default(string), string name = default(string), string type = default(string), string osType = default(string), string clusterCodeVersion = default(string), string supportExpiryUtc = default(string))
 
         {
             this.Id = id;

src/ServiceFabric/ServiceFabricManagedClusters.Management.Sdk/Generated/Models/NodeType.cs

@@ -5,8 +5,6 @@
 
 namespace Microsoft.Azure.Management.ServiceFabricManagedClusters.Models
 {
-    using System.Linq;
-
     /// <summary>
     /// Describes a node type in the cluster, each node type represents sub set of
     /// nodes in the cluster.
@@ -228,7 +226,7 @@ public NodeType()
         /// want to use and then click Want to deploy programmatically, Get Started -&gt;.
         /// Enter any required information and then click Save.
         /// </param>
-        public NodeType(bool isPrimary, int vmInstanceCount, string id = default(string), string name = default(string), string type = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), SystemData systemData = default(SystemData), int dataDiskSizeGB = default(int), string dataDiskType = default(string), string dataDiskLetter = default(string), System.Collections.Generic.IDictionary<string, string> placementProperties = default(System.Collections.Generic.IDictionary<string, string>), System.Collections.Generic.IDictionary<string, string> capacities = default(System.Collections.Generic.IDictionary<string, string>), EndpointRangeDescription applicationPorts = default(EndpointRangeDescription), EndpointRangeDescription ephemeralPorts = default(EndpointRangeDescription), string vmSize = default(string), string vmImagePublisher = default(string), string vmImageOffer = default(string), string vmImageSku = default(string), string vmImageVersion = default(string), System.Collections.Generic.IList<VaultSecretGroup> vmSecrets = default(System.Collections.Generic.IList<VaultSecretGroup>), System.Collections.Generic.IList<VmssExtension> vmExtensions = default(System.Collections.Generic.IList<VmssExtension>), VmManagedIdentity vmManagedIdentity = default(VmManagedIdentity), bool? isStateless = default(bool?), bool? multiplePlacementGroups = default(bool?), System.Collections.Generic.IList<FrontendConfiguration> frontendConfigurations = default(System.Collections.Generic.IList<FrontendConfiguration>), System.Collections.Generic.IList<NetworkSecurityRule> networkSecurityRules = default(System.Collections.Generic.IList<NetworkSecurityRule>), System.Collections.Generic.IList<VmssDataDisk> additionalDataDisks = default(System.Collections.Generic.IList<VmssDataDisk>), bool? enableEncryptionAtHost = default(bool?), string provisioningState = default(string), bool? enableAcceleratedNetworking = default(bool?), bool? useDefaultPublicLoadBalancer = default(bool?), bool? useTempDataDisk = default(bool?), bool? enableOverProvisioning = default(bool?), System.Collections.Generic.IList<string> zones = default(System.Collections.Generic.IList<string>), bool? isSpotVM = default(bool?), string hostGroupId = default(string), bool? useEphemeralOSDisk = default(bool?), string spotRestoreTimeout = default(string), string evictionPolicy = default(string), string vmImageResourceId = default(string), string subnetId = default(string), System.Collections.Generic.IList<string> vmSetupActions = default(System.Collections.Generic.IList<string>), string securityType = default(string), bool? secureBootEnabled = default(bool?), bool? enableNodePublicIP = default(bool?), string vmSharedGalleryImageId = default(string), string natGatewayId = default(string), VmImagePlan vmImagePlan = default(VmImagePlan), NodeTypeSku sku = default(NodeTypeSku))
+        public NodeType(string id = default(string), string name = default(string), string type = default(string), System.Collections.Generic.IDictionary<string, string> tags = default(System.Collections.Generic.IDictionary<string, string>), SystemData systemData = default(SystemData), NodeTypeSku sku = default(NodeTypeSku), string securityType = default(string), bool? isPrimary = default(bool?), int? vmInstanceCount = default(int?), int? dataDiskSizeGB = default(int?), string dataDiskType = default(string), string dataDiskLetter = default(string), System.Collections.Generic.IDictionary<string, string> placementProperties = default(System.Collections.Generic.IDictionary<string, string>), System.Collections.Generic.IDictionary<string, string> capacities = default(System.Collections.Generic.IDictionary<string, string>), EndpointRangeDescription applicationPorts = default(EndpointRangeDescription), EndpointRangeDescription ephemeralPorts = default(EndpointRangeDescription), string vmSize = default(string), string vmImagePublisher = default(string), string vmImageOffer = default(string), string vmImageSku = default(string), string vmImageVersion = default(string), System.Collections.Generic.IList<VaultSecretGroup> vmSecrets = default(System.Collections.Generic.IList<VaultSecretGroup>), System.Collections.Generic.IList<VmssExtension> vmExtensions = default(System.Collections.Generic.IList<VmssExtension>), VmManagedIdentity vmManagedIdentity = default(VmManagedIdentity), bool? isStateless = default(bool?), bool? multiplePlacementGroups = default(bool?), System.Collections.Generic.IList<FrontendConfiguration> frontendConfigurations = default(System.Collections.Generic.IList<FrontendConfiguration>), System.Collections.Generic.IList<NetworkSecurityRule> networkSecurityRules = default(System.Collections.Generic.IList<NetworkSecurityRule>), System.Collections.Generic.IList<VmssDataDisk> additionalDataDisks = default(System.Collections.Generic.IList<VmssDataDisk>), bool? enableEncryptionAtHost = default(bool?), string provisioningState = default(string), bool? enableAcceleratedNetworking = default(bool?), bool? useDefaultPublicLoadBalancer = default(bool?), bool? useTempDataDisk = default(bool?), bool? enableOverProvisioning = default(bool?), System.Collections.Generic.IList<string> zones = default(System.Collections.Generic.IList<string>), bool? isSpotVM = default(bool?), string hostGroupId = default(string), bool? useEphemeralOSDisk = default(bool?), string spotRestoreTimeout = default(string), string evictionPolicy = default(string), string vmImageResourceId = default(string), string subnetId = default(string), System.Collections.Generic.IList<string> vmSetupActions = default(System.Collections.Generic.IList<string>), bool? secureBootEnabled = default(bool?), bool? enableNodePublicIP = default(bool?), string vmSharedGalleryImageId = default(string), string natGatewayId = default(string), VmImagePlan vmImagePlan = default(VmImagePlan))
 
         : base(id, name, type, tags, systemData)
         {
@@ -304,22 +302,22 @@ public NodeType()
         /// type is created.
         /// </summary>
         [Newtonsoft.Json.JsonProperty(PropertyName = "properties.isPrimary")]
-        public bool IsPrimary {get; set; }
+        public bool? IsPrimary {get; set; }
 
         /// <summary>
         /// Gets or sets the number of nodes in the node type. &lt;br /&gt;&lt;br /&gt;**Values:**
         /// &lt;br /&gt;-1 - Use when auto scale rules are configured or sku.capacity is
         /// defined &lt;br /&gt; 0 - Not supported &lt;br /&gt; &gt;0 - Use for manual scale.
         /// </summary>
         [Newtonsoft.Json.JsonProperty(PropertyName = "properties.vmInstanceCount")]
-        public int VmInstanceCount {get; set; }
+        public int? VmInstanceCount {get; set; }
 
         /// <summary>
         /// Gets or sets disk size for the managed disk attached to the vms on the node
         /// type in GBs.
         /// </summary>
         [Newtonsoft.Json.JsonProperty(PropertyName = "properties.dataDiskSizeGB")]
-        public int DataDiskSizeGB {get; set; }
+        public int? DataDiskSizeGB {get; set; }
 
         /// <summary>
         /// Gets or sets managed data disk type. Specifies the storage account type for
@@ -411,7 +409,7 @@ public NodeType()
         /// machines.
         /// </summary>
         [Newtonsoft.Json.JsonProperty(PropertyName = "properties.vmExtensions")]
-        public System.Collections.Generic.IList<VmssExtension> VmExtensions { get; set; }
+        public System.Collections.Generic.IList<VmssExtension> VmExtensions {get; set; }
 
         /// <summary>
         /// Gets or sets identities to assign to the virtual machine scale set under
@@ -623,16 +621,18 @@ public virtual void Validate()
                 this.Sku.Validate();
             }
 
-            if (this.VmInstanceCount > 2147483647)
-            {
-                throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMaximum, "VMInstanceCount", 2147483647);
-            }
-            if (this.VmInstanceCount < -1)
+            if (this.VmInstanceCount != null)
             {
-                throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMinimum, "VMInstanceCount", -1);
+                if (this.VmInstanceCount > 2147483647)
+                {
+                    throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMaximum, "VMInstanceCount", 2147483647);
+                }
+                if (this.VmInstanceCount < -1)
+                {
+                    throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.InclusiveMinimum, "VMInstanceCount", -1);
+                }
             }
 
-
             if (this.DataDiskLetter != null)
             {
                 if (!System.Text.RegularExpressions.Regex.IsMatch(this.DataDiskLetter, "^[a-zA-Z]{1}$"))

src/ServiceFabric/ServiceFabricManagedClusters.Management.Sdk/README.md

@@ -21,7 +21,7 @@ payload-flattening-threshold: 2
 use-extension:
   "@autorest/powershell": "4.x"
 
-commit: da459cd725e11aa72e7fbc3b65d523b6e2b6453b
+commit: ce96a721d6bffa72dada8a998dee55f4c32ad0ef
 input-file:
   - https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-03-01-preview/managedcluster.json
   - https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-03-01-preview/nodetype.json