Merge pull request #26167 from dannysongg/allow-params-toggle

Fix bug in `Publish-AzWebApp` to allow params to be toggled off

Author: msJinLei

src/Websites/Websites/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fix bug where parameters could not be set to false for `Publish-AzWebApp`
 
 ## Version 3.2.1
 * Introduced secrets detection feature to safeguard sensitive data.

src/Websites/Websites/Cmdlets/WebApps/PublishAzureWebApp.cs

@@ -119,33 +119,34 @@ public override void ExecuteCmdlet()
 
             paramValues.Add("path", TargetPath);
 
+            // Purposely using IsParameterBound to check if the parameter is passed or not. In this case we want to return true if $false is passed. 
+            // We only want to set the parameter if a value is passed.
             // default async to true if not provided to match old behavior
-            if (Async.IsPresent)
+            if (this.IsParameterBound(c => c.Async))
             {
                 paramValues.Add("async", Async.ToString());
             }
-
             else
             {
                 paramValues.Add("async", "true");
             }
 
-            if (Restart.IsPresent)
+            if (this.IsParameterBound(c => c.Restart))
             {
                 paramValues.Add("restart", Restart.ToString());
             }
 
-            if (Clean.IsPresent)
+            if (this.IsParameterBound(c => c.Clean))
             {
                 paramValues.Add("clean", Clean.ToString());
             }
 
-            if (IgnoreStack.IsPresent)
+            if (this.IsParameterBound(c => c.IgnoreStack))
             {
                 paramValues.Add("ignorestack", IgnoreStack.ToString());
             }
 
-            if (Reset.IsPresent)
+            if (this.IsParameterBound(c => c.Reset))
             {
                 paramValues.Add("reset", Reset.ToString());
             }

tools/SecurityTools/CredScanSuppressions.json

@@ -1340,6 +1340,10 @@
     {
       "file": "src\\Batch\\Batch.Test\\SessionRecords\\Microsoft.Azure.Commands.Batch.Test.ScenarioTests.BatchAccountTests\\TestBatchAccountEndToEnd.json",
       "_justification": "Legitimate session record. Test resources, keys and tokens are deleted."
+    },
+    {
+      "file": "tools\\TestFx\\Live\\LiveTestUtility.psm1",
+      "_justification": "Legitimate test session record, keys are deleted."
     }
   ]
 }