Removing length validation for DNS TXT record to ensure consistency (#22208)

* Removing length validation for DNS TXT record to ensure consistency

* Removing json files corresponding to removed tests for length validation

* Changelog for public and private Dns

* Update src/Dns/Dns/ChangeLog.md

Co-authored-by: Vincent Dai <[email protected]>

* Update src/PrivateDns/PrivateDns/ChangeLog.md

Co-authored-by: Vincent Dai <[email protected]>

---------

Co-authored-by: Vincent Dai <[email protected]>

Author: avadhanulalavanya

src/Dns/Dns.Test/ScenarioTests/RecordsTests.cs

@@ -156,21 +156,6 @@ public void TestRecordSetTXTNonEmpty()
             TestRunner.RunTestScript("Test-RecordSetTXTNonEmpty");
         }
 
-        [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestRecordSetTXTLengthValidation()
-        {
-            TestRunner.RunTestScript("Test-RecordSetTXTLengthValidation");
-        }
-
-        [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestRecordSetTXTLegacyLengthValidation()
-        {
-            TestRunner.RunTestScript("Test-RecordSetTXTLegacyLengthValidation");
-        }
-
-
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestRecordSetSRV()

src/Dns/Dns.Test/ScenarioTests/RecordsTests.ps1

@@ -682,55 +682,6 @@ function Test-RecordSetTXTNonEmpty
 	Remove-AzResourceGroup -Name $resourceGroup.ResourceGroupName -Force
 }
 
-function Test-RecordSetTXTLegacyLengthValidation
-{
-	$zoneName = Get-RandomZoneName
-	$recordName = getAssetname
-    $resourceGroup = TestSetup-CreateResourceGroup 
-	$zone = $resourceGroup | New-AzDnsZone -Name $zoneName 
-	$longRecordTxt = Get-TxtOfSpecifiedLength 1025;
-	$maxRecordTxt = Get-TxtOfSpecifiedLength 1024;
-
-	$recordSet = $zone | New-AzDnsRecordSet -Name $recordName -Ttl 100 -RecordType TXT ;
-		
-	Assert-Throws {$recordSet | Add-AzDnsRecordConfig -Value $longRecordTxt }
-	
-	$recordSet = $recordSet | Add-AzDnsRecordConfig -Value $maxRecordTxt
-	$setResult = $recordSet | Set-AzDnsRecordSet ;
-		
-	Assert-AreEqual $maxRecordTxt $setResult.Records[0].Value;
-
-	$getResult = Get-AzDnsRecordSet -Name $recordName -ZoneName $zoneName -ResourceGroupName $resourceGroup.ResourceGroupName -RecordType TXT ;
-	Assert-AreEqual $maxRecordTxt $getResult.Records[0].Value;
-
-	Remove-AzDnsZone -Name $zoneName -ResourceGroupName $resourceGroup.ResourceGroupName -Confirm:$false
-	Remove-AzResourceGroup -Name $resourceGroup.ResourceGroupName -Force
-}
-
-
-function Test-RecordSetTXTLengthValidation
-{
-	$zoneName = Get-RandomZoneName
-	$recordName = getAssetname
-    $resourceGroup = TestSetup-CreateResourceGroup 
-	$zone = $resourceGroup | New-AzDnsZone -Name $zoneName 
-
-	$longRecordTxt = Get-TxtOfSpecifiedLength 1025;
-	Assert-Throws {New-AzDnsRecordConfig -Value $longRecordTxt }
-
-	$maxRecordTxt = Get-TxtOfSpecifiedLength 1024;
-	$maxRecord = New-AzDnsRecordConfig -Value $maxRecordTxt
-	$record = $zone | New-AzDnsRecordSet -Name $recordName -Ttl 100 -RecordType TXT -DnsRecords $maxRecord ;
-	Assert-AreEqual $maxRecordTxt $record.Records[0].Value;
-
-	$getResult = Get-AzDnsRecordSet -Name $recordName -ZoneName $zoneName -ResourceGroupName $resourceGroup.ResourceGroupName -RecordType TXT ;
-	Assert-AreEqual $maxRecordTxt $getResult.Records[0].Value;
-
-	Remove-AzDnsZone -Name $zoneName -ResourceGroupName $resourceGroup.ResourceGroupName -Confirm:$false
-	Remove-AzResourceGroup -Name $resourceGroup.ResourceGroupName -Force
-}
-
-
 function Test-RecordSetPTR
 {
 	$zoneName = Get-RandomZoneName

src/Dns/Dns.Test/SessionRecords/Microsoft.Azure.Commands.ScenarioTest.DnsTests.RecordsTests/TestRecordSetTXTLegacyLengthValidation.json

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Removed length validation for DNS TXT record to make it consistent with Azure CLI and Azure portal.
 
 ## Version 1.1.2
 * Update references in .psd1 to use relative path

src/Dns/Dns.Test/SessionRecords/Microsoft.Azure.Commands.ScenarioTest.DnsTests.RecordsTests/TestRecordSetTXTLengthValidation.json

@@ -33,10 +33,6 @@ public class DnsClient
     {
         public const string DnsResourceLocation = "global";
 
-        public const int TxtRecordMaxLength = 1024;
-
-        public const int TxtRecordMinLength = 0;
-
         private Dictionary<RecordType, Type> recordTypeValidationEntries = new Dictionary<RecordType, Type>()
         {
             {RecordType.A, typeof (ARecord)},

src/Dns/Dns/ChangeLog.md

@@ -120,10 +120,6 @@ public abstract class DnsRecordBase : ICloneable
     {
         public abstract object Clone();
 
-        public const int TxtRecordMaxLength = 1024;
-
-        public const int TxtRecordMinLength = 0;
-
         public const int TxtRecordChunkSize = 255;
 
         public const int CaaRecordMaxLength = 1024;

src/Dns/Dns/Models/DnsClient.cs

@@ -59,7 +59,6 @@ public class AddAzureDnsRecordConfig : DnsBaseCmdlet
 
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The text value for the TXT record to add.", ParameterSetName = "TXT")]
         [ValidateNotNullOrEmpty]
-        [ValidateLength(DnsClient.TxtRecordMinLength, DnsClient.TxtRecordMaxLength)]
         public string Value { get; set; }
 
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The priority value SRV record to add.", ParameterSetName = "SRV")]

src/Dns/Dns/Models/DnsRecordSet.cs

@@ -66,7 +66,6 @@ public class NewAzureRmDnsRecordConfig : DnsBaseCmdlet
 
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The text value for the TXT record to add.", ParameterSetName = ParameterSetTxt)]
         [ValidateNotNullOrEmpty]
-        [ValidateLength(DnsRecordBase.TxtRecordMinLength, DnsRecordBase.TxtRecordMaxLength)]
         public string Value { get; set; }
 
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The priority value SRV record to add.", ParameterSetName = ParameterSetSrv)]

src/Dns/Dns/Records/AddAzureDnsRecordConfig.cs

@@ -128,21 +128,6 @@ public void TestRecordSetTXTNonEmpty()
             TestRunner.RunTestScript("Test-RecordSetTXTNonEmpty");
         }
 
-        [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestRecordSetTXTLengthValidation()
-        {
-            TestRunner.RunTestScript("Test-RecordSetTXTLengthValidation");
-        }
-
-        [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestRecordSetTXTLegacyLengthValidation()
-        {
-            TestRunner.RunTestScript("Test-RecordSetTXTLegacyLengthValidation");
-        }
-
-
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestRecordSetSRV()