LASTERROREXIT does not catch Invoke-Analyzer errors.

Paul D.Smith · Paul D.Smith · commit 3acf909ac923 · 2024-11-04T09:59:40.000Z
diff --git a/tools/CheckPowershellCompliance.ps1 b/tools/CheckPowershellCompliance.ps1
@@ -91,8 +91,9 @@ function Confirm-Compliance {
     }
 
     # Recursively find all *.ps1 files and run Invoke-ScriptAnalyzer against them.
-    Get-ChildItem -Path . -Recurse -Include '*.ps1' | Invoke-ScriptAnalyzer -Settings $settings
-    if ($LastExitCode -ne 0) {
+    $problems = $(Get-ChildItem -Path ./custom -Recurse -Include '*.ps1' | Invoke-ScriptAnalyzer -Settings $settings)
+    if ("" -ne $problems) {
+        Write-Output $problems
         Write-Error 'ScriptAnalyzer found (possibly back-compatibility) issues.'
         exit 5
     }

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,9 @@ function Confirm-Compliance {`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`# Recursively find all *.ps1 files and run Invoke-ScriptAnalyzer against them.`
`94`		`- Get-ChildItem -Path . -Recurse -Include '*.ps1' \| Invoke-ScriptAnalyzer -Settings $settings`
`95`		`- if ($LastExitCode -ne 0) {`
	`94`	`+ $problems = $(Get-ChildItem -Path ./custom -Recurse -Include '*.ps1' \| Invoke-ScriptAnalyzer -Settings $settings)`
	`95`	`+ if ("" -ne $problems) {`
	`96`	`+ Write-Output $problems`
`96`	`97`	`Write-Error 'ScriptAnalyzer found (possibly back-compatibility) issues.'`
`97`	`98`	`exit 5`
`98`	`99`	`}`