ctrl+c to abort login (#13396)

Author: isra-fel

src/Accounts/Accounts/Account/ConnectAzureRmAccount.cs

@@ -227,6 +227,13 @@ protected override void BeginProcessing()
             AzureSession.Instance.TryGetComponent(WriteWarningKey, out _originalWriteWarning);
             AzureSession.Instance.UnregisterComponent<EventHandler<StreamEventArgs>>(WriteWarningKey);
             AzureSession.Instance.RegisterComponent(WriteWarningKey, () => _writeWarningEvent);
+
+            // todo: ideally cancellation token should be passed to authentication factory as a parameter
+            // however AuthenticationFactory.Authenticate does not support it
+            // so I store it in AzureSession.Instance as a global variable
+            // todo: CancellationTokenSource should be visiable only in cmdlet class
+            // CancellationTokenSource.Token should be passed to other classes
+            AzureSession.Instance.RegisterComponent("LoginCancellationToken", () => new CancellationTokenSource(), true);
         }
 
         private event EventHandler<StreamEventArgs> _writeWarningEvent;
@@ -237,6 +244,14 @@ private void WriteWarningSender(object sender, StreamEventArgs args)
             _tasks.Enqueue(new Task(() => this.WriteWarning(args.Message)));
         }
 
+        protected override void StopProcessing()
+        {
+            if (AzureSession.Instance.TryGetComponent("LoginCancellationToken", out CancellationTokenSource cancellationTokenSource)) {
+                cancellationTokenSource?.Cancel();
+            }
+            base.StopProcessing();
+        }
+
         public override void ExecuteCmdlet()
         {
             Guid subscrptionIdGuid;

src/Accounts/Accounts/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Supported interrupting login by hitting <kbd>CTRL</kbd>+<kbd>C</kbd>
 * Fixed an issue causing `Connect-AzAccount -KeyVaultAccessToken` not working [#13127]
 * Fixed null reference and method case insensitive in `Invoke-AzRestMethod`
 

src/Accounts/Authentication/Authentication/DelegatingAuthenticator.cs

@@ -26,20 +26,31 @@ public abstract class DelegatingAuthenticator : IAuthenticator
         protected const string AdfsTenant = "adfs";
         protected const string OrganizationsTenant = "organizations";
 
+        protected CancellationToken AuthenticationCancellationToken
+        {
+            get
+            {
+                // todo: move "LoginCancellationToken" to common repo as a const
+                if (AzureSession.Instance.TryGetComponent("LoginCancellationToken", out CancellationTokenSource cancellationTokenSource))
+                {
+                    return cancellationTokenSource.Token;
+                }
+                return new CancellationTokenSource().Token;
+            }
+        }
+
         public IAuthenticator Next { get; set; }
         public abstract bool CanAuthenticate(AuthenticationParameters parameters);
         public abstract Task<IAccessToken> Authenticate(AuthenticationParameters parameters, CancellationToken cancellationToken);
 
         public Task<IAccessToken> Authenticate(AuthenticationParameters parameters)
         {
-            var source = new CancellationTokenSource();
-            return Authenticate(parameters, source.Token);
+            return Authenticate(parameters, AuthenticationCancellationToken);
         }
 
         public bool TryAuthenticate(AuthenticationParameters parameters, out Task<IAccessToken> token)
         {
-            var source = new CancellationTokenSource();
-            return TryAuthenticate(parameters, source.Token, out token);
+            return TryAuthenticate(parameters, AuthenticationCancellationToken, out token);
         }
 
         public bool TryAuthenticate(AuthenticationParameters parameters, CancellationToken cancellationToken, out Task<IAccessToken> token)

src/Accounts/Authenticators/DeviceCodeAuthenticator.cs

@@ -31,7 +31,7 @@ public override Task<IAccessToken> Authenticate(AuthenticationParameters paramet
             var deviceCodeParameters = parameters as DeviceCodeParameters;
             var tokenCacheProvider = parameters.TokenCacheProvider;
             var onPremise = parameters.Environment.OnPremise;
-            //null instead of "organizations" should be passed to Azure.Identity to support MSA account 
+            //null instead of "organizations" should be passed to Azure.Identity to support MSA account
             var tenantId = onPremise ? AdfsTenant :
                 (string.Equals(parameters.TenantId, OrganizationsTenant, StringComparison.OrdinalIgnoreCase) ? null : parameters.TenantId);
             var resource = parameters.Environment.GetEndpoint(parameters.ResourceId) ?? parameters.ResourceId;
@@ -51,15 +51,13 @@ public override Task<IAccessToken> Authenticate(AuthenticationParameters paramet
                 TokenCache = tokenCache.TokenCache,
             };
             var codeCredential = new DeviceCodeCredential(options);
-            var source = new CancellationTokenSource();
-            source.CancelAfter(TimeSpan.FromMinutes(5));
 
-            var authTask = codeCredential.AuthenticateAsync(requestContext, source.Token);
+            var authTask = codeCredential.AuthenticateAsync(requestContext, cancellationToken);
             return MsalAccessToken.GetAccessTokenAsync(
                 authTask,
                 codeCredential,
                 requestContext,
-                source.Token);
+                cancellationToken);
         }
 
         private Task DeviceCodeFunc(DeviceCodeInfo info, CancellationToken cancellation)

src/Accounts/Authenticators/InteractiveUserAuthenticator.cs

@@ -65,15 +65,13 @@ public override Task<IAccessToken> Authenticate(AuthenticationParameters paramet
                 RedirectUri = GetReplyUrl(onPremise, interactiveParameters),
             };
             var browserCredential = new InteractiveBrowserCredential(options);
-            var source = new CancellationTokenSource();
-            source.CancelAfter(TimeSpan.FromMinutes(5));
-            var authTask = browserCredential.AuthenticateAsync(requestContext, source.Token);
+            var authTask = browserCredential.AuthenticateAsync(requestContext, cancellationToken);
 
             return MsalAccessToken.GetAccessTokenAsync(
                 authTask,
                 browserCredential,
                 requestContext,
-                source.Token);
+                cancellationToken);
         }
 
         private Uri GetReplyUrl(bool onPremise, InteractiveParameters interactiveParameters)