Skip to content

Commit 4876210

Browse files
Adjust Publish-AzWebApp default parameters (#22832)
* Adjust Publish-AzWebApp default behavior * Update tests and async behavior * Moving release notes to upcoming release * Update ChangeLog.md --------- Co-authored-by: Yabo Hu <[email protected]>
1 parent 587ef0c commit 4876210

File tree

6 files changed

+1686
-1425
lines changed

6 files changed

+1686
-1425
lines changed

src/Websites/Websites.Test/ScenarioTests/WebAppTests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1274,7 +1274,7 @@ function Test-PublishAzureWebAppOnedeploy
12741274
New-AzResource -PropertyObject $PropertiesObject -ResourceGroupName $rgname -ResourceType Microsoft.Web/sites/config -ResourceName "$appName/web" -ApiVersion 2018-02-01 -Force
12751275

12761276
$warPath = Join-Path $ResourcesPath "HelloJava.war"
1277-
$publishedApp = Publish-AzWebApp -ResourceGroupName $rgname -Name $appName -ArchivePath $warPath -Type war -Clean $true -TargetPath /home/site/wwwroot/webapps/ROOT -Force
1277+
$publishedApp = Publish-AzWebApp -ResourceGroupName:$rgname -Name:$appName -ArchivePath:$warPath -Type:war -Clean:$true -TargetPath:/home/site/wwwroot/webapps/ROOT -Force
12781278

12791279
Assert-NotNull $publishedApp
12801280
}

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestPublishWebAppFromWar.json

Lines changed: 490 additions & 640 deletions
Large diffs are not rendered by default.

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestPublishWebAppFromZip.json

Lines changed: 510 additions & 432 deletions
Large diffs are not rendered by default.

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestPublishWebAppOneDeploy.json

Lines changed: 653 additions & 347 deletions
Large diffs are not rendered by default.

src/Websites/Websites/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Adjusted `Publish-AzWebApp` default behavior
2122

2223
## Version 3.1.1
2324
* Added support for XenonMV3 webapps

src/Websites/Websites/Cmdlets/WebApps/PublishAzureWebApp.cs

Lines changed: 31 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,37 @@ public override void ExecuteCmdlet()
118118
}
119119

120120
paramValues.Add("path", TargetPath);
121-
paramValues.Add("isasync", Async.IsPresent.ToString());
122-
paramValues.Add("restart", Restart.IsPresent.ToString());
123-
paramValues.Add("clean", Clean.IsPresent.ToString());
124-
paramValues.Add("ignorestack", IgnoreStack.IsPresent.ToString());
125-
paramValues.Add("reset", Reset.IsPresent.ToString());
121+
122+
// default async to true if not provided to match old behavior
123+
if (Async.IsPresent)
124+
{
125+
paramValues.Add("async", Async.ToString());
126+
}
127+
128+
else
129+
{
130+
paramValues.Add("async", "true");
131+
}
132+
133+
if (Restart.IsPresent)
134+
{
135+
paramValues.Add("restart", Restart.ToString());
136+
}
137+
138+
if (Clean.IsPresent)
139+
{
140+
paramValues.Add("clean", Clean.ToString());
141+
}
142+
143+
if (IgnoreStack.IsPresent)
144+
{
145+
paramValues.Add("ignorestack", IgnoreStack.ToString());
146+
}
147+
148+
if (Reset.IsPresent)
149+
{
150+
paramValues.Add("reset", Reset.ToString());
151+
}
126152

127153
uriBuilder.Query = paramValues.ToString();
128154

0 commit comments

Comments
 (0)