[HanaOnAzure] Fix issue in powershell <7 (#12685)

* fix hana

* fix doc link

Author: isra-fel

src/HanaOnAzure/Az.HanaOnAzure.psd1

@@ -1,25 +1,135 @@
+#
+# Module manifest for module 'Az.HanaOnAzure'
+#
+# Generated by: Microsoft Corporation
+#
+# Generated on: 2020/8/18
+#
+
 @{
-  GUID = '79ad50da-e6b5-4703-885a-d36974a4d9b9'
-  RootModule = './Az.HanaOnAzure.psm1'
-  ModuleVersion = '0.1.0'
-  CompatiblePSEditions = 'Core', 'Desktop'
-  Author = 'Microsoft Corporation'
-  CompanyName = 'Microsoft Corporation'
-  Copyright = 'Microsoft Corporation. All rights reserved.'
-  Description = 'Microsoft Azure PowerShell: HanaOn cmdlets'
-  PowerShellVersion = '5.1'
-  DotNetFrameworkVersion = '4.7.2'
-  RequiredAssemblies = './bin/Az.HanaOnAzure.private.dll'
-  RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.9.2'; })
-  FormatsToProcess = './Az.HanaOnAzure.format.ps1xml'
-  FunctionsToExport = 'Get-AzSapMonitor', 'Get-AzSapMonitorProviderInstance', 'New-AzSapMonitor', 'New-AzSapMonitorProviderInstance', 'Remove-AzSapMonitor', 'Remove-AzSapMonitorProviderInstance', 'Update-AzSapMonitor'
-  AliasesToExport = '*'
-  PrivateData = @{
+
+# Script module or binary module file associated with this manifest.
+RootModule = './Az.HanaOnAzure.psm1'
+
+# Version number of this module.
+ModuleVersion = '0.1.0'
+
+# Supported PSEditions
+CompatiblePSEditions = 'Core', 'Desktop'
+
+# ID used to uniquely identify this module
+GUID = '79ad50da-e6b5-4703-885a-d36974a4d9b9'
+
+# Author of this module
+Author = 'Microsoft Corporation'
+
+# Company or vendor of this module
+CompanyName = 'Microsoft Corporation'
+
+# Copyright statement for this module
+Copyright = 'Microsoft Corporation. All rights reserved.'
+
+# Description of the functionality provided by this module
+Description = 'Microsoft Azure PowerShell: HanaOn cmdlets'
+
+# Minimum version of the PowerShell engine required by this module
+PowerShellVersion = '5.1'
+
+# Name of the PowerShell host required by this module
+# PowerShellHostName = ''
+
+# Minimum version of the PowerShell host required by this module
+# PowerShellHostVersion = ''
+
+# Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
+DotNetFrameworkVersion = '4.7.2'
+
+# Minimum version of the common language runtime (CLR) required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
+# ClrVersion = ''
+
+# Processor architecture (None, X86, Amd64) required by this module
+# ProcessorArchitecture = ''
+
+# Modules that must be imported into the global environment prior to importing this module
+RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '1.9.2'; })
+
+# Assemblies that must be loaded prior to importing this module
+RequiredAssemblies = './bin/Az.HanaOnAzure.private.dll'
+
+# Script files (.ps1) that are run in the caller's environment prior to importing this module.
+# ScriptsToProcess = @()
+
+# Type files (.ps1xml) to be loaded when importing this module
+# TypesToProcess = @()
+
+# Format files (.ps1xml) to be loaded when importing this module
+FormatsToProcess = './Az.HanaOnAzure.format.ps1xml'
+
+# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
+# NestedModules = @()
+
+# Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
+FunctionsToExport = 'Get-AzSapMonitor', 'Get-AzSapMonitorProviderInstance', 
+               'New-AzSapMonitor', 'New-AzSapMonitorProviderInstance', 
+               'Remove-AzSapMonitor', 'Remove-AzSapMonitorProviderInstance', 
+               'Update-AzSapMonitor'
+
+# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
+CmdletsToExport = @()
+
+# Variables to export from this module
+# VariablesToExport = @()
+
+# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
+AliasesToExport = '*'
+
+# DSC resources to export from this module
+# DscResourcesToExport = @()
+
+# List of all modules packaged with this module
+# ModuleList = @()
+
+# List of all files packaged with this module
+# FileList = @()
+
+# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
+PrivateData = @{
+
     PSData = @{
-      Tags = 'Azure', 'ResourceManager', 'ARM', 'PSModule', 'HanaOn'
-      LicenseUri = 'https://aka.ms/azps-license'
-      ProjectUri = 'https://github.com/Azure/azure-powershell'
-      ReleaseNotes = '* the first preview release'
-    }
-  }
+
+        # Tags applied to this module. These help with module discovery in online galleries.
+        Tags = 'Azure','ResourceManager','ARM','PSModule','HanaOn'
+
+        # A URL to the license for this module.
+        LicenseUri = 'https://aka.ms/azps-license'
+
+        # A URL to the main website for this project.
+        ProjectUri = 'https://github.com/Azure/azure-powershell'
+
+        # A URL to an icon representing this module.
+        # IconUri = ''
+
+        # ReleaseNotes of this module
+        # ReleaseNotes = ''
+
+        # Prerelease string of this module
+        # Prerelease = ''
+
+        # Flag to indicate whether the module requires explicit user acceptance for install/update/save
+        # RequireLicenseAcceptance = $false
+
+        # External dependent modules of this module
+        # ExternalModuleDependencies = @()
+
+    } # End of PSData hashtable
+
+ } # End of PrivateData hashtable
+
+# HelpInfo URI of this module
+# HelpInfoURI = ''
+
+# Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
+# DefaultCommandPrefix = ''
+
 }
+

src/HanaOnAzure/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fixed an issue in PowerShell prior to 7.0
 
 ## Version 0.1.0
 * the first preview release

src/HanaOnAzure/custom/New-AzSapMonitorProviderInstance.ps1

@@ -203,7 +203,8 @@ function New-AzSapMonitorProviderInstance {
                     hanaDbName     = $HanaDatabaseName
                     hanaDbSqlPort  = $HanaDatabaseSqlPort
                     hanaDbUsername = $HanaDatabaseUsername
-                    hanaDbPassword = ConvertFrom-SecureString $HanaDatabasePassword -AsPlainText
+                    # cannot use `ConvertFrom-SecureString -AsPlainText`, requires powershell >= 7
+                    hanaDbPassword = [System.Runtime.InteropServices.marshal]::PtrToStringAuto([System.Runtime.InteropServices.marshal]::SecureStringToBSTR($HanaDatabasePassword))
                 }
             }
             'ByKeyVault' {

src/HanaOnAzure/examples/New-AzSapMonitor.md

@@ -10,3 +10,4 @@ westus2  ps-sapmonitor-t01 Microsoft.HanaOnAzure/sapMonitors
 ```
 
 This command creates a SAP monitor.
+

src/HanaOnAzure/exports/New-AzSapMonitor.ps1

@@ -19,9 +19,9 @@ Creates a SAP monitor for the specified subscription, resource group, and resour
 .Description
 Creates a SAP monitor for the specified subscription, resource group, and resource name.
 .Example
-PS C:\> $workspace = New-AzOperationalInsightsWorkspace -ResourceGroupName nancyc-hn1 -Name sapmonitor-test  -Location westus2 -Sku "Standard"
-PS C:\> $workspace = Get-AzOperationalInsightsWorkspaceSharedKey -ResourceGroupName nancyc-hn1 -Name sapmonitor-test
-PS C:\> New-AzSapMonitor -Name ps-sapmonitor-t01 -ResourceGroupName nancyc-hn1 -Location westus2 -EnableCustomerAnalytic -MonitorSubnet "/subscriptions/9e223dbe-3399-4e19-88eb-0975f02ac87f/resourceGroups/nancyc-hn1/providers/Microsoft.Network/virtualNetworks/vnet-sap/subnets/subnet-admin" -LogAnalyticsWorkspaceSharedKey $workspace.PrimarySharedKey -LogAnalyticsWorkspaceId $workspace.CustomerId -LogAnalyticsWorkspaceResourceId $workspace.ResourceId
+PS C:\> $Workspace = New-AzOperationalInsightsWorkspace -ResourceGroupName nancyc-hn1 -Name sapmonitor-test  -Location westus2 -Sku "Standard"
+PS C:\> $WorkspaceKey = Get-AzOperationalInsightsWorkspaceSharedKey -ResourceGroupName nancyc-hn1 -Name sapmonitor-test
+PS C:\> New-AzSapMonitor -Name ps-sapmonitor-t01 -ResourceGroupName nancyc-hn1 -Location westus2 -EnableCustomerAnalytic -MonitorSubnet "/subscriptions/9e223dbe-3399-4e19-88eb-0975f02ac87f/resourceGroups/nancyc-hn1/providers/Microsoft.Network/virtualNetworks/vnet-sap/subnets/subnet-admin" -LogAnalyticsWorkspaceSharedKey $WorkspaceKey.PrimarySharedKey -LogAnalyticsWorkspaceId $Workspace.CustomerId -LogAnalyticsWorkspaceResourceId $Workspace.ResourceId
 
 Location Name              Type
 -------- ----              ----

src/HanaOnAzure/exports/ProxyCmdletDefinitions.ps1

@@ -409,9 +409,9 @@ Creates a SAP monitor for the specified subscription, resource group, and resour
 .Description
 Creates a SAP monitor for the specified subscription, resource group, and resource name.
 .Example
-PS C:\> $workspace = New-AzOperationalInsightsWorkspace -ResourceGroupName nancyc-hn1 -Name sapmonitor-test  -Location westus2 -Sku "Standard"
-PS C:\> $workspace = Get-AzOperationalInsightsWorkspaceSharedKey -ResourceGroupName nancyc-hn1 -Name sapmonitor-test
-PS C:\> New-AzSapMonitor -Name ps-sapmonitor-t01 -ResourceGroupName nancyc-hn1 -Location westus2 -EnableCustomerAnalytic -MonitorSubnet "/subscriptions/9e223dbe-3399-4e19-88eb-0975f02ac87f/resourceGroups/nancyc-hn1/providers/Microsoft.Network/virtualNetworks/vnet-sap/subnets/subnet-admin" -LogAnalyticsWorkspaceSharedKey $workspace.PrimarySharedKey -LogAnalyticsWorkspaceId $workspace.CustomerId -LogAnalyticsWorkspaceResourceId $workspace.ResourceId
+PS C:\> $Workspace = New-AzOperationalInsightsWorkspace -ResourceGroupName nancyc-hn1 -Name sapmonitor-test  -Location westus2 -Sku "Standard"
+PS C:\> $WorkspaceKey = Get-AzOperationalInsightsWorkspaceSharedKey -ResourceGroupName nancyc-hn1 -Name sapmonitor-test
+PS C:\> New-AzSapMonitor -Name ps-sapmonitor-t01 -ResourceGroupName nancyc-hn1 -Location westus2 -EnableCustomerAnalytic -MonitorSubnet "/subscriptions/9e223dbe-3399-4e19-88eb-0975f02ac87f/resourceGroups/nancyc-hn1/providers/Microsoft.Network/virtualNetworks/vnet-sap/subnets/subnet-admin" -LogAnalyticsWorkspaceSharedKey $WorkspaceKey.PrimarySharedKey -LogAnalyticsWorkspaceId $Workspace.CustomerId -LogAnalyticsWorkspaceResourceId $Workspace.ResourceId
 
 Location Name              Type
 -------- ----              ----