Merge pull request #21542 from wastoresh/mergestorage

[Do not Squash] Merge main change to storage preview branch

Author: wyunchi-ms

.azure-pipelines/live-test.yml

@@ -23,10 +23,6 @@ parameters:
   displayName: PowerShell 7.0.x Version
   type: string
   default: 7.0.*
-- name: ps_7_1_x
-  displayName: PowerShell 7.1.x Version
-  type: string
-  default: 7.1.*
 - name: ps_7_2_x
   displayName: PowerShell 7.2.x Version
   type: string
@@ -88,14 +84,6 @@ jobs:
     psVersion: ${{ parameters.ps_7_0_x }}
     dotnetVersion: ${{ parameters.dotnet_sdk_6 }}
 
-- template: util/live-test-steps.yml
-  parameters:
-    name: 'ps_7_1_x_win_2019'
-    vmImage: ${{ parameters.img_windows_2019 }}
-    osType: 'Windows'
-    psVersion: ${{ parameters.ps_7_1_x }}
-    dotnetVersion: ${{ parameters.dotnet_sdk_6 }}
-
 - template: util/live-test-steps.yml
   parameters:
     name: 'ps_7_2_x_win_2019'
@@ -120,14 +108,6 @@ jobs:
     psVersion: ${{ parameters.ps_7_0_x }}
     dotnetVersion: ${{ parameters.dotnet_sdk_6 }}
 
-- template: util/live-test-steps.yml
-  parameters:
-    name: 'ps_7_1_x_win_2022'
-    vmImage: ${{ parameters.img_windows_2022 }}
-    osType: 'Windows'
-    psVersion: ${{ parameters.ps_7_1_x }}
-    dotnetVersion: ${{ parameters.dotnet_sdk_6 }}
-
 - template: util/live-test-steps.yml
   parameters:
     name: 'ps_7_2_x_win_2022'
@@ -152,14 +132,6 @@ jobs:
     psVersion: ${{ parameters.ps_7_0_x }}
     dotnetVersion: ${{ parameters.dotnet_sdk_6 }}
 
-- template: util/live-test-steps.yml
-  parameters:
-    name: 'ps_7_1_x_linux'
-    vmImage: ${{ parameters.img_linux }}
-    osType: 'Linux'
-    psVersion: ${{ parameters.ps_7_1_x }}
-    dotnetVersion: ${{ parameters.dotnet_sdk_6 }}
-
 - template: util/live-test-steps.yml
   parameters:
     name: 'ps_7_2_x_linux'
@@ -184,14 +156,6 @@ jobs:
     psVersion: ${{ parameters.ps_7_0_x }}
     dotnetVersion: ${{ parameters.dotnet_sdk_6 }}
 
-- template: util/live-test-steps.yml
-  parameters:
-    name: 'ps_7_1_x_macOS'
-    vmImage: ${{ parameters.img_macos }}
-    osType: 'MacOS'
-    psVersion: ${{ parameters.ps_7_1_x }}
-    dotnetVersion: ${{ parameters.dotnet_sdk_6 }}
-
 - template: util/live-test-steps.yml
   parameters:
     name: 'ps_7_2_x_macOS'

.azure-pipelines/release-test.yml

@@ -7,10 +7,6 @@ parameters:
   displayName: PowerShell 7.0.x Version
   type: string
   default: 7.0.*
-- name: ps7_1
-  displayName: PowerShell 7.1.x Version
-  type: string
-  default: 7.1.*
 - name: ps7_2
   displayName: PowerShell 7.2.x Version
   type: string
@@ -64,14 +60,6 @@ jobs:
     psVersion: ${{ parameters.ps7 }}
     netCoreVersion: ${{ parameters.netCoreVersion }}
 
-- template: util/smoke-test-steps.yml
-  parameters:
-    name: 'Win_PS7_1_X_SmokeTest'
-    agentPoolName: ${{ variables.winAgentPoolName }}
-    agentPoolVMImage: ${{ variables.winAgentPoolVMImage }}
-    psVersion: ${{ parameters.ps7_1 }}
-    netCoreVersion: ${{ parameters.netCoreVersion }}
-
 - template: util/smoke-test-steps.yml
   parameters:
     name: 'Win_PS7_2_X_SmokeTest'
@@ -112,14 +100,6 @@ jobs:
     psVersion: ${{ parameters.ps7 }}
     netCoreVersion: ${{ parameters.netCoreVersion }}
 
-- template: util/smoke-test-steps.yml
-  parameters:
-    name: 'Linux_PS7_1_X_SmokeTest'
-    agentPoolName: ${{ variables.linuxAgentPoolName }}
-    agentPoolVMImage: ${{ variables.linuxAgentPoolVMImage }}
-    psVersion: ${{ parameters.ps7_1 }}
-    netCoreVersion: ${{ parameters.netCoreVersion }}
-
 - template: util/smoke-test-steps.yml
   parameters:
     name: 'Linux_PS7_2_X_SmokeTest'
@@ -160,14 +140,6 @@ jobs:
     psVersion: ${{ parameters.ps7 }}
     netCoreVersion: ${{ parameters.netCoreVersion }}
 
-- template: util/smoke-test-steps.yml
-  parameters:
-    name: 'MacOS_PS7_1_X_SmokeTest'
-    agentPoolName: ${{ variables.macOsAgentPoolName }}
-    agentPoolVMImage: ${{ variables.macOsAgentPoolVMImage }}
-    psVersion: ${{ parameters.ps7_1 }}
-    netCoreVersion: ${{ parameters.netCoreVersion }}
-
 - template: util/smoke-test-steps.yml
   parameters:
     name: 'MacOS_PS7_2_X_SmokeTest'

.azure-pipelines/util/live-test-steps.yml

@@ -123,7 +123,7 @@ jobs:
 
   - task: PowerShell@2
     displayName: Save live test results to Kusto
-    condition: succeededOrFailed()
+    condition: and(succeededOrFailed(), eq(variables['Build.Reason'], 'Schedule'))
     inputs:
       pwsh: true
       targetType: filePath

documentation/Debugging-StaticAnalysis-Errors.md

@@ -33,7 +33,7 @@ msbuild build.proj
 The three most common Static Analysis errors are breaking changes, signature issues, and help issues.  To figure out which type of error is causing the build failure, open each of the relevant .csv files (if the .csv file does not exist, there is no violation detected).  Any issue marked with severity 0 or 1 must be resolved in order for the build to pass.
 
 ### Assembly Version Conflict
-(To be Updated)
+We utilize some shared assemblies, such as Azure.Core, accross all the modules to avoid duplicating. To maintain consistency, only one version is allowed to be loaded within a single PowerShell session. If any errors occur, they will be recorded in the `AssemblyVersionConflict.csv` file. We recommend reviewing each error listed in this file and updating your package dependencies accordingly. Generally, suppressing these issues is not advised.
 
 ### Breaking Changes
 If you make a change that could cause a breaking change, it will be listed in `BreakingChangeIssues.csv`.  Please look at each of these errors in this file, and if they do indeed introduce a breaking change in a non-breaking change release, please revert the change that caused this violation. 
@@ -57,13 +57,13 @@ Example issues occur when your changed markdown files in the `help` folder (_e.g
 - Push the changes to the .csv file and ensure the errors no longer show up in the `ExampleIssues.csv` file output from the CI pipeline artifacts.
 - 
 ### Extra Assemblies
-(To be Updated)
+We will examine each assembly within the module's artifacts folder to identify any assembly that is actually not needed to pack into the package, for example a a system assembly. The names of these assemblies will be documented in the `ExtraAssemblies.csv` file. As these assemblies serve no purpose for this module, they should be removed to decrease the module package size. It is important to verify whether these files were copied due to an incorrect copy step, such as a `Copy` action in a `props` or `csproj` file. Generally, suppressing these issues is not advised.
 
 ### Help Issues
 Most help issues that cause StaticAnalysis to fail occur when help has not been added for a particular cmdlet.  If you have not generated help for your new cmdlets, please follow the instructions [here](https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md). If this is not the issue, follow the steps listed under "Remediation" for each violation listed in HelpIssues.csv.
 
 ### Missing Assemblies
-(To be Updated)
+We will ensure that all required assemblies are located within the module's artifacts folder for packaging purposes. If a necessary assembly is not included, the module cannot be imported. Any missing assemblies will be documented in the `MissingAssemblies.csv` file. It is important to investigate the reason behind a missing assembly, such as the assembly being loaded as a shared assembly but not added to the allowed list defined in `DependencyAnalyzer.cs`.
 
 ### Signature Issues
 Signature issues occur when your cmdlets do not follow PowerShell standards.  Please check the [_Cmdlet Best Practices_](https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/design-guidelines/cmdlet-best-practices.md) and the [_Parameter Best Practices_](https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/design-guidelines/parameter-best-practices.md) documents to ensure you are following PowerShell guidelines.  Issues with severity 0 or 1 must be addressed, while issues with severity 2 are advisory.  If you have an issue with severity 0 or 1 that has been approved by the Azure PowerShell team, you can suppress them following these steps:
@@ -109,4 +109,4 @@ Please check whether you have matched the correct number of **quotes** and **bra
 - MissingArrayIndexExpression: Array index expression is missing or not valid.
 - UnexpectedToken: Unexpected token xxx. (Check whether you have missed or added extra quote)
 
-In this scenario, many other unreasonable errors will occur. Leave them alone. Just make sure you have correct the number of **quotes** and **brackets** and rerun the CI verification. 
+In this scenario, many other unreasonable errors will occur. Leave them alone. Just make sure you have correct the number of **quotes** and **brackets** and rerun the CI verification. 

src/Accounts/Accounts.Test/EnvironmentCmdletTests.cs

@@ -546,6 +546,39 @@ public void GetsAzureEnvironment()
             Assert.Single(environments);
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void GetsAllAzureEnvironments()
+        {
+            List<PSAzureEnvironment> environments = null;
+            Mock<ICommandRuntime> commandRuntimeMock = new Mock<ICommandRuntime>();
+            commandRuntimeMock.Setup(c => c.WriteObject(It.IsAny<object>(), It.IsAny<bool>()))
+                .Callback<object, bool>((e, _) => environments = (List<PSAzureEnvironment>)e);
+
+            var cmdlet = new GetAzureRMEnvironmentCommand()
+            {
+                CommandRuntime = commandRuntimeMock.Object
+            };
+
+            cmdlet.InvokeBeginProcessing();
+            cmdlet.ExecuteCmdlet();
+            cmdlet.InvokeEndProcessing();
+
+            Assert.Equal(3, environments.Count);
+
+            var publicEnvironmentRef = EnvironmentCmdletTestsExtension.GetAzureCloudEndpoints();
+            var publicEnvironment = environments.Where(x => 0 == string.Compare(x.Name, "AzureCloud")).First();
+            Assert.True(publicEnvironment.IsAbsolutelyEqual(publicEnvironmentRef));
+
+            var chinaEnvironmentRef = EnvironmentCmdletTestsExtension.GetAzureChinaCloudEndpoints();
+            var chinaEnvironment = environments.Where(x => 0 == string.Compare(x.Name, "AzureChinaCloud")).First();
+            Assert.True(chinaEnvironment.IsAbsolutelyEqual(chinaEnvironmentRef));
+
+            var usEnvironmentRef = EnvironmentCmdletTestsExtension.GetAzureUSGovernmentEndpoints();
+            var usEnvironment = environments.Where(x => 0 == string.Compare(x.Name, "AzureUSGovernment")).First();
+            Assert.True(usEnvironment.IsAbsolutelyEqual(usEnvironmentRef));
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void ThrowsWhenSettingPublicEnvironment()