Marking Additional Azure Batch future breaking changes (#28479)

Author: wiboris

src/Batch/Batch/JobSchedules/GetBatchJobScheduleCommand.cs

@@ -16,10 +16,12 @@
 using Microsoft.Azure.Commands.Batch.Models;
 using System.Management.Automation;
 using Constants = Microsoft.Azure.Commands.Batch.Utils.Constants;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.Batch
 {
-    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchJobSchedule", DefaultParameterSetName = Constants.ODataFilterParameterSet),OutputType(typeof(PSCloudJobSchedule))]
+    [GenericBreakingChangeWithVersion("The following properties of the PSPoolSpecification class found under the returned PSCloudJobSchedule class are being deprecated: TargetNodeCommunicationMode, ResourceTags, CertificateReferences, ApplicationLicenses, CloudServiceConfiguration","15.0.0", "4.0.0")]
+    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchJobSchedule", DefaultParameterSetName = Constants.ODataFilterParameterSet), OutputType(typeof(PSCloudJobSchedule))]
     public class GetBatchJobScheduleCommand : BatchObjectModelCmdletBase
     {
         private int maxCount = Constants.DefaultMaxCount;

src/Batch/Batch/JobSchedules/NewBatchJobScheduleCommand.cs

@@ -17,6 +17,7 @@
 using System.Collections;
 using System.Management.Automation;
 using Constants = Microsoft.Azure.Commands.Batch.Utils.Constants;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.Batch
 {
@@ -38,6 +39,7 @@ public class NewBatchJobScheduleCommand : BatchObjectModelCmdletBase
 
         [Parameter(Mandatory = true, HelpMessage = "Specifies details of the jobs to be created on this schedule.")]
         [ValidateNotNullOrEmpty]
+        [GenericBreakingChangeWithVersion("The following properties of the PSPoolSpecification class found under the PSJobSpecification class are being deprecated: TargetNodeCommunicationMode, ResourceTags, CertificateReferences, ApplicationLicenses, CloudServiceConfiguration","15.0.0", "4.0.0")]
         public PSJobSpecification JobSpecification { get; set; }
 
         [Parameter]

src/Batch/Batch/Jobs/GetBatchJobCommand.cs

@@ -16,10 +16,12 @@
 using Microsoft.Azure.Commands.Batch.Models;
 using System.Management.Automation;
 using Constants = Microsoft.Azure.Commands.Batch.Utils.Constants;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.Batch
 {
-    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchJob", DefaultParameterSetName = Constants.ODataFilterParameterSet),OutputType(typeof(PSCloudJob))]
+    [GenericBreakingChangeWithVersion("The following properties of the PSPoolSpecification class found under the returned PSCloudJob class are being deprecated: TargetNodeCommunicationMode, ResourceTags, CertificateReferences, ApplicationLicenses, CloudServiceConfiguration","15.0.0", "4.0.0")]
+    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchJob", DefaultParameterSetName = Constants.ODataFilterParameterSet), OutputType(typeof(PSCloudJob))]
     public class GetBatchJobCommand : BatchObjectModelCmdletBase
     {
         private int maxCount = Constants.DefaultMaxCount;

src/Batch/Batch/Jobs/NewBatchJobCommand.cs

@@ -18,6 +18,7 @@
 using System.Management.Automation;
 using Constants = Microsoft.Azure.Commands.Batch.Utils.Constants;
 using System.Collections.Generic;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.Batch
 {
@@ -60,6 +61,7 @@ public class NewBatchJobCommand : BatchObjectModelCmdletBase
 
         [Parameter(Mandatory = true, HelpMessage = "The pool information for the job.")]
         [ValidateNotNullOrEmpty]
+        [GenericBreakingChangeWithVersion("The following properties of the PSPoolSpecification class found under the PSPoolInformation class are being deprecated: TargetNodeCommunicationMode, ResourceTags, CertificateReferences, ApplicationLicenses, CloudServiceConfiguration","15.0.0", "4.0.0")]
         public PSPoolInformation PoolInformation { get; set; }
 
         [Parameter]

src/Batch/Batch/Pools/GetBatchPoolCommand.cs

@@ -16,9 +16,11 @@
 using Microsoft.Azure.Commands.Batch.Models;
 using System.Management.Automation;
 using Constants = Microsoft.Azure.Commands.Batch.Utils.Constants;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.Batch
 {
+    [CmdletOutputBreakingChangeWithVersion(typeof(PSCloudPool), "15.0.0", "4.0.0", DeprecatedOutputProperties = new string[] {"CurrentNodeCommunicationMode", "TargetNodeCommunicationMode", "ResourceTags", "CertificateReferences", "ApplicationLicenses", "CloudServiceConfiguration"})]
     [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchPool", DefaultParameterSetName = Constants.ODataFilterParameterSet), OutputType(typeof(PSCloudPool))]
     public class GetBatchPoolCommand : BatchObjectModelCmdletBase
     {

src/Batch/Batch/Pools/GetBatchPoolNodeCountCommand.cs

@@ -31,9 +31,10 @@ public class GetBatchPoolNodeCountCommand : BatchObjectModelCmdletBase
         [ValidateNotNullOrEmpty]
         public string PoolId { get; set; }
 
-        [Parameter(ParameterSetName = Constants.ParentObjectParameterSet, 
+        [Parameter(ParameterSetName = Constants.ParentObjectParameterSet,
             ValueFromPipeline = true, Mandatory = false, HelpMessage = "The pool object for which to get node counts.")]
         [ValidateNotNullOrEmpty]
+        [GenericBreakingChangeWithVersion("The following properties of PSCloudPool are being deprecated: CurrentNodeCommunicationMode, TargetNodeCommunicationMode, ResourceTags, CertificateReferences, ApplicationLicenses, CloudServiceConfiguration","15.0.0", "4.0.0")]
         public PSCloudPool Pool { get; set; }
 
         [Parameter(ParameterSetName = Constants.ODataFilterParameterSet), ValidateRange(1, defaultMaxCount)]

src/Batch/Batch/Pools/NewBatchPoolCommand.cs

@@ -31,7 +31,7 @@ public class NewBatchPoolCommand : BatchObjectModelCmdletBase
         internal const string CloudServiceAutoScaleParameterSet = "CloudServiceAndAutoScale";
         internal const string VirtualMachineTargetDedicatedParameterSet = "VirtualMachineAndTargetDedicated";
         internal const string VirtualMachineAutoScaleParameterSet = "VirtualMachineAndAutoScale";
-        internal const string ChangeDesc = "Parameter is being deprecated without being replaced";
+        public const string ChangeDesc = "Parameter is being deprecated without being replaced";
 
         [Parameter(Position = 0, Mandatory = true, HelpMessage = "The id of the pool to create.")]
         [ValidateNotNullOrEmpty]
@@ -84,7 +84,7 @@ public class NewBatchPoolCommand : BatchObjectModelCmdletBase
         [ValidateNotNullOrEmpty]
         public PSTaskSchedulingPolicy TaskSchedulingPolicy { get; set; }
 
-        [CmdletParameterBreakingChangeWithVersion("ResourceTag", "15.0.0", "4.0.0")]
+        [CmdletParameterBreakingChangeWithVersion("ResourceTag", "15.0.0", "4.0.0", ChangeDescription = ChangeDesc)]
         [Parameter(Mandatory = false, HelpMessage = "The user  defined tags to be associated with the Azure Batch Pool.When specified, these tags are propagated to the backing Azure resources associated with the pool.This property can only be specified when the Batch account was created with the poolAllocationMode property set to 'UserSubscription'.")]
         [ValidateNotNullOrEmpty]
         public IDictionary ResourceTag { get; set; }
@@ -102,7 +102,7 @@ public class NewBatchPoolCommand : BatchObjectModelCmdletBase
         [Parameter]
         [ValidateNotNullOrEmpty]
         [Alias("CertificateReference")]
-        [CmdletParameterBreakingChangeWithVersion("CertificateReference", "15.0.0", "4.0.0")]
+        [CmdletParameterBreakingChangeWithVersion("CertificateReference", "15.0.0", "4.0.0", ChangeDescription = ChangeDesc)]
         public PSCertificateReference[] CertificateReferences { get; set; }
 
         [Parameter]
@@ -113,7 +113,7 @@ public class NewBatchPoolCommand : BatchObjectModelCmdletBase
         [Parameter]
         [ValidateNotNullOrEmpty]
         [Alias("ApplicationLicense")]
-        [CmdletParameterBreakingChangeWithVersion("ApplicationLicense", "15.0.0", "4.0.0")]
+        [CmdletParameterBreakingChangeWithVersion("ApplicationLicense", "15.0.0", "4.0.0", ChangeDescription = ChangeDesc)]
         public List<string> ApplicationLicenses { get; set; }
 
         [Parameter(ParameterSetName = VirtualMachineAutoScaleParameterSet)]
@@ -124,7 +124,7 @@ public class NewBatchPoolCommand : BatchObjectModelCmdletBase
         [Parameter(ParameterSetName = CloudServiceAutoScaleParameterSet)]
         [Parameter(ParameterSetName = CloudServiceTargetDedicatedParameterSet)]
         [ValidateNotNullOrEmpty]
-        [CmdletParameterBreakingChangeWithVersion("CloudServiceConfiguration", "15.0.0", "4.0.0")]
+        [CmdletParameterBreakingChangeWithVersion("CloudServiceConfiguration", "15.0.0", "4.0.0", ChangeDescription = ChangeDesc)]
         public PSCloudServiceConfiguration CloudServiceConfiguration { get; set; }
 
         [Parameter]
@@ -146,7 +146,7 @@ public class NewBatchPoolCommand : BatchObjectModelCmdletBase
         [Parameter]
         [ValidateNotNullOrEmpty]
         [PSArgumentCompleter("Default", "Classic", "Simplified")]
-        [CmdletParameterBreakingChangeWithVersion("TargetNodeCommunicationMode", "15.0.0", "4.0.0")]
+        [CmdletParameterBreakingChangeWithVersion("TargetNodeCommunicationMode", "15.0.0", "4.0.0", ChangeDescription = ChangeDesc)]
         public NodeCommunicationMode TargetNodeCommunicationMode { get; set; }
 
         protected override void ExecuteCmdletImpl()

src/Batch/Batch/Pools/SetBatchPoolCommand.cs

@@ -15,6 +15,7 @@
 using Microsoft.Azure.Commands.Batch.Models;
 using System.Management.Automation;
 using Constants = Microsoft.Azure.Commands.Batch.Utils.Constants;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.Batch
 {
@@ -24,6 +25,7 @@ public class SetBatchPoolCommand : BatchObjectModelCmdletBase
         [Parameter(Position = 0, Mandatory = true, ValueFromPipeline = true,
             HelpMessage = "The PSCloudPool object with changes to commit to the Batch Service.")]
         [ValidateNotNullOrEmpty]
+        [GenericBreakingChangeWithVersion("The following properties of PSCloudPool are being deprecated: CurrentNodeCommunicationMode, TargetNodeCommunicationMode, ResourceTags, CertificateReferences, ApplicationLicenses, CloudServiceConfiguration","15.0.0", "4.0.0")]
         public PSCloudPool Pool { get; set; }
 
         protected override void ExecuteCmdletImpl()

src/Batch/Batch/Tasks/GetBatchTaskCommand.cs

@@ -16,6 +16,7 @@
 using Microsoft.Azure.Commands.Batch.Models;
 using System.Management.Automation;
 using Constants = Microsoft.Azure.Commands.Batch.Utils.Constants;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.Batch
 {
@@ -37,6 +38,7 @@ public class GetBatchTaskCommand : BatchObjectModelCmdletBase
 
         [Parameter(Position = 0, ParameterSetName = Constants.ParentObjectParameterSet, ValueFromPipeline = true)]
         [ValidateNotNullOrEmpty]
+        [GenericBreakingChangeWithVersion("The following properties of the PSPoolSpecification class found under the PSCloudJob class are being deprecated: TargetNodeCommunicationMode, ResourceTags, CertificateReferences, ApplicationLicenses, CloudServiceConfiguration","15.0.0", "4.0.0")]
         public PSCloudJob Job { get; set; }
 
         [Parameter(ParameterSetName = Constants.ODataFilterParameterSet)]

src/Batch/Batch/Tasks/GetBatchTaskCountCommand.cs

@@ -31,6 +31,7 @@ public class GetBatchTaskCountCommand : BatchObjectModelCmdletBase
 
         [Parameter(Position = 0, ParameterSetName = Constants.ParentObjectParameterSet, ValueFromPipeline = true)]
         [ValidateNotNullOrEmpty]
+        [GenericBreakingChangeWithVersion("The following properties of the PSPoolSpecification class found under the PSCloudJob class are being deprecated: TargetNodeCommunicationMode, ResourceTags, CertificateReferences, ApplicationLicenses, CloudServiceConfiguration","15.0.0", "4.0.0")]
         public PSCloudJob Job { get; set; }
 
         protected override void ExecuteCmdletImpl()