Skip to content

Commit 5f6f1d3

Browse files
authored
[Storage] Fix an Azure File issue on SAS credential (#22297)
1 parent 3c32bd2 commit 5f6f1d3

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/Storage/Storage/Common/AzureStorageFileDirectory.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,14 +145,14 @@ public AzureStorageFileDirectory(ShareDirectoryClient shareDirectoryClient, Azur
145145
// Convert Track2 File Dir object to Track 1 file Dir object
146146
public static CloudFileDirectory GetTrack1FileDirClient(ShareDirectoryClient shareFileDirClient, StorageCredentials credentials)
147147
{
148-
if (credentials.IsSAS) // the Uri already contains credentail.
149-
{
150-
credentials = null;
151-
}
152148
if (credentials.IsToken)
153149
{
154150
return new InvalidCloudFileDirectory(shareFileDirClient.Uri, credentials);
155151
}
152+
if (credentials.IsSAS) // the Uri already contains credentail.
153+
{
154+
credentials = null;
155+
}
156156
CloudFileDirectory track1CloudFileDir;
157157
track1CloudFileDir = new CloudFileDirectory(shareFileDirClient.Uri, credentials);
158158
return track1CloudFileDir;

src/Storage/Storage/Common/AzureStorageFileShare.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,14 +230,14 @@ public void UndeleteShare()
230230
// Convert Track2 File share object to Track 1 file share object
231231
public static CloudFileShare GetTrack1FileShareClient(ShareClient shareClient, StorageCredentials credentials)
232232
{
233-
if (credentials.IsSAS) // the Uri already contains credentail.
234-
{
235-
credentials = null;
236-
}
237233
if (credentials.IsToken)
238234
{
239235
return new InvalidCloudFileShare(shareClient.Uri, credentials);
240236
}
237+
if (credentials.IsSAS) // the Uri already contains credentail.
238+
{
239+
credentials = null;
240+
}
241241
CloudFileShare track1CloudFileShare = new CloudFileShare(shareClient.Uri, credentials);
242242
return track1CloudFileShare;
243243
}

0 commit comments

Comments
 (0)