PowerShell Live Test Fix for Firewall (#21387)

* Fixed failing tests

* Live test changes

* live tests fix due to location

* reverted snat changes

---------

Co-authored-by: Gizachew Eshetie <[email protected]>

Author: Gizachew-Eshetie

src/Network/Network.Test/ScenarioTests/AzureFirewallIpGroupTests.ps1

@@ -34,9 +34,9 @@ function Test-AzureFirewallIpGroup
 {
       # Setup
       $rgname = Get-ResourceGroupName
-      $rglocation = Get-ProviderLocation ResourceManagement "eastus2euap"
-      $location = Get-ProviderLocation ResourceManagement "eastus2euap"
-      $ipGroupLocation = Get-ProviderLocation ResourceManagement "eastus2euap"
+      $rglocation = Get-ProviderLocation ResourceManagement "eastus"
+      $location = Get-ProviderLocation ResourceManagement "eastus"
+      $ipGroupLocation = Get-ProviderLocation ResourceManagement "eastus"
       $ipGroupName1 = Get-ResourceName
       $ipGroupName2 = Get-ResourceName
 
@@ -125,7 +125,7 @@ function Test-AzureFirewallIpGroup
       $publicip = New-AzPublicIpAddress -ResourceGroupName $rgname -name $publicIpName -location $location -AllocationMethod Static -Sku Standard
 
       # Create AzureFirewall (with no rules, ThreatIntel is in Alert mode by default)
-      $azureFirewall = New-AzFirewall –Name $azureFirewallName -ResourceGroupName $rgname -Location $location -VirtualNetworkName $vnetName -PublicIpName $publicIpName
+      $azureFirewall = New-AzFirewall –Name $azureFirewallName -ResourceGroupName $rgname -Location $location -VirtualNetwork $vnet -PublicIpAddress $publicip
 
       #
       #  Application Rule Section

src/Network/Network.Test/ScenarioTests/AzureFirewallPolicyTests.ps1

@@ -22,7 +22,7 @@ function Test-AzureFirewallPolicyCRUD {
     $azureFirewallPolicyName = Get-ResourceName
     $azureFirewallPolicyAsJobName = Get-ResourceName
     $resourceTypeParent = "Microsoft.Network/FirewallPolicies"
-    $location = "eastus2euap"
+    $location = "westus2"
 
     $ruleGroupName = Get-ResourceName
 
@@ -269,7 +269,7 @@ function Test-AzureFirewallPolicyWithThreatIntelWhitelistCRUD {
     $azureFirewallPolicyName = Get-ResourceName
     $azureFirewallPolicyAsJobName = Get-ResourceName
     $resourceTypeParent = "Microsoft.Network/FirewallPolicies"
-    $location = "eastus2euap"
+    $location = "westus2"
 
     $ruleGroupName = Get-ResourceName
     $threatIntelWhiteListIp1 = "20.3.4.5"
@@ -332,7 +332,7 @@ function Test-AzureFirewallPolicyWithDNSSettings {
     $azureFirewallPolicyName = Get-ResourceName
     $azureFirewallPolicyAsJobName = Get-ResourceName
     $resourceTypeParent = "Microsoft.Network/FirewallPolicies"
-    $location = "eastus2euap"
+    $location = "westus2"
     $dnsServers = @("10.10.10.1", "20.20.20.2")
 
     try {
@@ -425,7 +425,7 @@ function Test-AzureFirewallPolicyWithSQLSetting {
     $rgname = Get-ResourceGroupName
     $azureFirewallPolicyName = Get-ResourceName
     $azureFirewallPolicyName2 = Get-ResourceName
-    $location = "eastus2euap"
+    $location = "westus2"
 
     try {
 
@@ -451,7 +451,7 @@ function Test-AzureFirewallPolicyWithSQLSetting {
         $disallowSql = New-AzFirewallPolicySqlSetting
         $azureFirewallPolicy = Set-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname -Location $location -SqlSetting $disallowSql
         $getAzureFirewallPolicy = Get-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname
-        Assert-Null $getAzureFirewallPolicy.SqlSetting.AllowSqlRedirect
+        Assert-AreEqual false $getAzureFirewallPolicy.SqlSetting.AllowSqlRedirect
 
         # test set AzureFirewallPolicy with sql redirect
         $azureFirewallPolicy = Set-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname -Location $location -SqlSetting $allowSql
@@ -489,7 +489,7 @@ function Test-AzureFirewallPolicyCRUDWithNetworkRuleDestinationFQDNs {
     $azureFirewallPolicyName = Get-ResourceName
     $azureFirewallPolicyAsJobName = Get-ResourceName
     $resourceTypeParent = "Microsoft.Network/FirewallPolicies"
-    $location = "eastus2euap"
+    $location = "westus2"
     $dnsServers = @("10.10.10.1", "20.20.20.2")
 
     $ruleGroupName = Get-ResourceName
@@ -610,8 +610,8 @@ function Test-AzureFirewallPolicyWithIpGroups {
     $azureFirewallPolicyName = Get-ResourceName
     $azureFirewallPolicyAsJobName = Get-ResourceName
     $resourceTypeParent = "Microsoft.Network/FirewallPolicies"
-    $location = "eastus2euap"
-    $ipGroupLocation = Get-ProviderLocation ResourceManagement "eastus2euap"
+    $location = "westus2"
+    $ipGroupLocation = Get-ProviderLocation ResourceManagement "westus2"
     $ipGroupName1 = Get-ResourceName
     $ipGroupName2 = Get-ResourceName
 

src/Network/Network.Test/ScenarioTests/AzureFirewallTests.ps1

@@ -525,10 +525,10 @@ function Test-AzureFirewallCRUDWithZones {
         $vnet = New-AzVirtualNetwork -Name $vnetName -ResourceGroupName $rgname -Location $location -AddressPrefix 10.0.0.0/16 -Subnet $subnet
 
         # Create public ip
-        $publicip = New-AzPublicIpAddress -ResourceGroupName $rgname -name $publicIpName -location $location -AllocationMethod Static -Sku Standard
+        $publicip = New-AzPublicIpAddress -ResourceGroupName $rgname -name $publicIpName -location $location -AllocationMethod Static -Sku Standard -Zone 1, 2, 3
 
         # Create AzureFirewall (with no rules, ThreatIntel is in Alert mode by default)
-        $azureFirewall = New-AzFirewall –Name $azureFirewallName -ResourceGroupName $rgname -Location $location -VirtualNetworkName $vnetName -PublicIpName $publicIpName -Zone 1, 2, 3
+        $azureFirewall = New-AzFirewall –Name $azureFirewallName -ResourceGroupName $rgname -Location $location -VirtualNetwork $vnet -PublicIpAddress $publicip -Zone 1, 2, 3
 
         # Get AzureFirewall
         $getAzureFirewall = Get-AzFirewall -name $azureFirewallName -ResourceGroupName $rgname
@@ -1236,8 +1236,8 @@ function Test-AzureFirewallVirtualHubCRUDWithZones {
     $rgname = Get-ResourceGroupName
     $azureFirewallName = Get-ResourceName
     $resourceTypeParent = "Microsoft.Network/AzureFirewalls"
-    $policyLocation = Get-ProviderLocation $resourceTypeParent "eastus2euap"
-    $location = Get-ProviderLocation $resourceTypeParent "eastus2euap"
+    $policyLocation = Get-ProviderLocation $resourceTypeParent "eastus"
+    $location = Get-ProviderLocation $resourceTypeParent "eastus"
     $azureFirewallPolicyName = Get-ResourceName
     $skuName = "AZFW_Hub"
     $skuTier = "Standard"