powershell azurestackhci update

Author: shraddhasun

src/StackHCIVM/StackHCIVM.Autorest/custom/Az.StackHCIVM.custom.psm1

@@ -1,9 +1,9 @@
 # region Generated 
   # Load the private module dll
-  $null = Import-Module -PassThru -Name (Join-Path $PSScriptRoot '..\bin\Az.StackHCIVM.private.dll')
+  $null = Import-Module -PassThru -Name (Join-Path $PSScriptRoot '../bin/Az.StackHCIVM.private.dll')
 
   # Load the internal module
-  $internalModulePath = Join-Path $PSScriptRoot '..\internal\Az.StackHCIVM.internal.psm1'
+  $internalModulePath = Join-Path $PSScriptRoot '../internal/Az.StackHCIVM.internal.psm1'
   if(Test-Path $internalModulePath) {
     $null = Import-Module -Name $internalModulePath
   }

src/StackHCIVM/StackHCIVM.Autorest/custom/Get-AzStackHCIVMNetworkInterface_ByResourceId.ps1

@@ -22,13 +22,13 @@ Gets a network interface
 
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.INetworkInterfaces
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.INetworkInterface
 
 .Link
 https://learn.microsoft.com/powershell/module/az.stackhcivm/get-azstackhcivmnetworkinterface
 #>
 function Get-AzStackHCIVMNetworkInterface_ByResourceId {
-[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.INetworkInterfaces])]
+[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.INetworkInterface])]
 [CmdletBinding( PositionalBinding=$false)]
 param(
 

src/StackHCIVM/StackHCIVM.Autorest/custom/Get-AzStackHCIVMStoragePath_ByResourceId.ps1

@@ -20,13 +20,13 @@ Gets a storage path blah
 Gets a storage path blah
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IStorageContainers
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IStorageContainer
 
 .Link
 https://learn.microsoft.com/powershell/module/az.stackhcivm/get-azstackhcivmstoragepath
 #>
 function Get-AzStackHCIVMStoragePath_ByResourceId {
-[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IStorageContainers])]
+[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IStorageContainer])]
 [CmdletBinding(PositionalBinding=$false)]
 
 param(

src/StackHCIVM/StackHCIVM.Autorest/custom/Get-AzStackHCIVMVirtualHardDisk_ByResourceId.ps1

@@ -20,12 +20,12 @@ Gets a virtual hard disk
 Gets a virtual hard disk 
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IVirtualHardDisks
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IVirtualHardDisk
 .Link
 https://learn.microsoft.com/powershell/module/az.stackhcivm/get-azstackhcivmvirtualharddisk
 #>
 function Get-AzStackHCIVMVirtualHardDisk_ByResourceId {
-[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IVirtualHardDisks])]
+[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IVirtualHardDisk])]
 [CmdletBinding( PositionalBinding=$false)]
 
 param(

src/StackHCIVM/StackHCIVM.Autorest/custom/Get-AzStackHCIVmImage.ps1

@@ -21,7 +21,7 @@ Gets a gallery image
 
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImages
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImage
 Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IMarketplaceGalleryImages
 
 .Link
@@ -31,7 +31,7 @@ https://learn.microsoft.com/powershell/module/az.stackhcivm/get-azstackhcivmimag
 function Get-AzStackHCIVMImage{    
     [CmdletBinding(DefaultParameterSetName='BySubscription', PositionalBinding=$false)]
     [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IMarketplaceGalleryImages])]
-    [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImages])]
+    [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImage])]
     param(
     [Parameter(ParameterSetName='ByName', Mandatory)]
     [Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Category('Path')]

src/StackHCIVM/StackHCIVM.Autorest/custom/Get-AzStackHCIVmLogicalNetwork_ByResourceId2.ps1

@@ -21,13 +21,13 @@ Gets a logical network
 
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.ILogicalNetworks
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.ILogicalNetwork
 
 .Link
 https://learn.microsoft.com/powershell/module/az.stackhcivm/get-azstackhcivmlogicalnetwork
 #>
 function Get-AzStackHCIVMLogicalNetwork_ByResourceId {
-    [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHciVM.Models.ILogicalNetworks])]
+    [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.ILogicalNetwork])]
     [CmdletBinding(PositionalBinding=$false)]
 
     param(

src/StackHCIVM/StackHCIVM.Autorest/custom/New-AzStackHCIVMImage.ps1

@@ -31,7 +31,7 @@ PS C:\> {{ Add code here }}
 
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImages
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImage
 Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IMarketplaceGalleryImages
 .Notes
 COMPLEX PARAMETER PROPERTIES
@@ -42,7 +42,7 @@ https://learn.microsoft.com/powershell/module/az.stackhcivm/new-azstackhcivmimag
 function New-AzStackHCIVMImage{
     [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IMarketplaceGalleryImages],ParameterSetName='Marketplace' )]
     [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IMarketplaceGalleryImages],ParameterSetName='MarketplaceURN' )]
-    [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImages],ParameterSetName='GalleryImage' )]
+    [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImage],ParameterSetName='GalleryImage' )]
     [CmdletBinding(PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')]
     param(
 
@@ -102,9 +102,10 @@ function New-AzStackHCIVMImage{
 
     [Parameter(ParameterSetName='GalleryImage', Mandatory)]
     [Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Category('Body')]
-    [System.String]
-    # Local path of image that the image should be created from. 
+    [System.Security.SecureString]
+    # Local path of image that the image should be created from (as SecureString). 
     # This parameter is required for non marketplace images. 
+    # Use: ConvertTo-SecureString -String "path\to\image.vhdx" -AsPlainText -Force
     ${ImagePath},
 
     [Parameter(ParameterSetName='GalleryImage', Mandatory)]
@@ -238,7 +239,6 @@ function New-AzStackHCIVMImage{
     ${ProxyUseDefaultCredentials}
 
     )
-
         if (-Not ($name -match $imageNameRegex )) {
             Write-Error "Invalid Name for image provided: $name" -ErrorAction Stop
         }
@@ -307,7 +307,6 @@ function New-AzStackHCIVMImage{
             $PSBoundParameters['ErrorAction'] = 'Stop'
             try {
                 Az.StackHCIVM.internal\New-AzStackHCIVMMarketplaceGalleryImage @PSBoundParameters
-                Start-Sleep -Seconds 60
                 $PercentCompleted = 0 
                 Write-Progress -Activity "Download Percentage: " -Status "$PercentCompleted % Complete:" -PercentComplete $PercentCompleted
                 $null = $PSBoundParameters.Remove("Version")
@@ -330,15 +329,13 @@ function New-AzStackHCIVMImage{
                         $PercentCompleted = 0
                     } 
                     Write-Progress -Activity "Download Percentage: " -Status "$PercentCompleted % Complete" -PercentComplete $PercentCompleted
-                    Start-Sleep -Seconds 5    
                     if ($image.ProvisioningStatus -eq "Failed") {
                         Break
                     }           
                 }
                 if ($image.ProvisioningStatus -eq "Failed"){
                     Write-Error $image.StatusErrorMessage -ErrorAction Stop
                 }
-               
             } catch {
                 $e = $_
                 if ($e.FullyQualifiedErrorId -match "MissingAzureKubernetesMapping" ){
@@ -416,6 +413,7 @@ function New-AzStackHCIVMImage{
         if ($PSCmdlet.ParameterSetName -eq "GalleryImage")
         {
             try{
+                # ImagePath is already a SecureString, no conversion needed
                 Az.StackHCIVM.internal\New-AzStackHCIVMGalleryImage -ErrorAction Stop @PSBoundParameters 
             } catch {
                 $e = $_

src/StackHCIVM/StackHCIVM.Autorest/custom/New-AzStackHCIVMLogicalNetwork_New.ps1

@@ -22,7 +22,7 @@ The operation to create or update a logical network.
 Please note some properties can be set only during logical network creation.
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.ILogicalNetworks
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.ILogicalNetwork
 .Notes
 COMPLEX PARAMETER PROPERTIES
 
@@ -50,7 +50,7 @@ https://learn.microsoft.com/powershell/module/az.stackhcivm/new-azstackhcivmlogi
 #>
 
 function New-AzStackHCIVMLogicalNetwork {
-  [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.ILogicalNetworks])]
+  [OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.ILogicalNetwork])]
   [CmdletBinding( PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')]
   param(
       [Parameter(Mandatory)]

src/StackHCIVM/StackHCIVM.Autorest/custom/New-AzStackHCIVMNetworkInterface_New.ps1

@@ -22,7 +22,7 @@ The operation to create or update a network interface.
 Please note some properties can be set only during network interface creation.
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.INetworkInterfaces
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.INetworkInterface
 .Notes
 COMPLEX PARAMETER PROPERTIES
 
@@ -36,7 +36,7 @@ IPCONFIGURATION <IIPConfiguration[]>: IPConfigurations - A list of IPConfigurati
 https://learn.microsoft.com/powershell/module/az.stackhcivm/new-azstackhcivmnetworkinterface
 #>
 function New-AzStackHCIVMNetworkInterface {
-[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.INetworkInterfaces])]
+[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.INetworkInterface])]
 [CmdletBinding(PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')]
 param(
     [Parameter(Mandatory)]

src/StackHCIVM/StackHCIVM.Autorest/custom/New-AzStackHCIVMStoragePath_New.ps1

@@ -23,12 +23,12 @@ The operation to create or update a storage container.
 Please note some properties can be set only during storage container creation.
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IStorageContainers
+Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IStorageContainer
 .Link
 https://learn.microsoft.com/powershell/module/az.stackhcivm/new-azstackhcivmstoragepath
 #>
 function New-AzStackHCIVMStoragePath{
-[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IStorageContainers])]
+[OutputType([Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IStorageContainer])]
 [CmdletBinding(PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')]
 param(
     [Parameter(Mandatory)]
@@ -145,7 +145,6 @@ param(
       Write-Error "Invalid CustomLocationId: $CustomLocationId" -ErrorAction Stop
     } 
 
-    
     try{
       Az.StackHCIVM.internal\New-AzStackHCIVMStoragePath -ErrorAction Stop @PSBoundParameters 
     } catch {
@@ -156,5 +155,5 @@ param(
           Write-Error $e.Exception.Message -ErrorAction Stop
       }
     }
- 
+
 }