Skip to content

Commit 6741dfb

Browse files
authored
[Storage] Add warning messages for an upcoming breaking change of parameter EnableLargeFileShare (#21405)
* add warning messages * Udpate warning message
1 parent 85c061a commit 6741dfb

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

src/Storage/Storage.Management/ChangeLog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Added warning messages for an upcoming cmdlet breaking change
22+
- `New-AzStorageAccount`
23+
- `Set-AzStorageAccount`
2124

2225
## Version 5.5.0
2326
* Supported create storage account with DnsEndpointType

src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccount.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,17 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15-
using System.Collections;
16-
using System.Management.Automation;
15+
using Microsoft.Azure.Commands.Management.Storage.Models;
16+
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
1717
using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
1818
using Microsoft.Azure.Management.Storage;
1919
using Microsoft.Azure.Management.Storage.Models;
20-
using StorageModels = Microsoft.Azure.Management.Storage.Models;
21-
using Microsoft.Azure.Commands.Management.Storage.Models;
22-
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
20+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2321
using System;
22+
using System.Collections;
2423
using System.Collections.Generic;
25-
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
24+
using System.Management.Automation;
25+
using StorageModels = Microsoft.Azure.Management.Storage.Models;
2626

2727
namespace Microsoft.Azure.Commands.Management.Storage
2828
{
@@ -286,6 +286,7 @@ public bool EnableAzureActiveDirectoryDomainServicesForFile
286286
}
287287
private bool? enableAzureActiveDirectoryDomainServicesForFile = null;
288288

289+
[CmdletParameterBreakingChange("EnableLargeFileShare", ChangeDescription = "EnableLargeFileShare parameter will be deprecated in a future release.")]
289290
[Parameter(Mandatory = false, HelpMessage = "Indicates whether or not the storage account can support large file shares with more than 5 TiB capacity. Once the account is enabled, the feature cannot be disabled. Currently only supported for LRS and ZRS replication types, hence account conversions to geo-redundant accounts would not be possible. Learn more in https://go.microsoft.com/fwlink/?linkid=2086047")]
290291
public SwitchParameter EnableLargeFileShare { get; set; }
291292

src/Storage/Storage.Management/StorageAccount/SetAzureStorageAccount.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,17 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15-
using System.Collections;
16-
using System.Collections.Generic;
17-
using System.Management.Automation;
15+
using Microsoft.Azure.Commands.Management.Storage.Models;
16+
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
1817
using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
1918
using Microsoft.Azure.Management.Storage;
2019
using Microsoft.Azure.Management.Storage.Models;
21-
using StorageModels = Microsoft.Azure.Management.Storage.Models;
22-
using Microsoft.Azure.Commands.Management.Storage.Models;
23-
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
20+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2421
using System;
22+
using System.Collections;
23+
using System.Collections.Generic;
24+
using System.Management.Automation;
25+
using StorageModels = Microsoft.Azure.Management.Storage.Models;
2526

2627
namespace Microsoft.Azure.Commands.Management.Storage
2728
{
@@ -245,6 +246,7 @@ public bool EnableAzureActiveDirectoryDomainServicesForFile
245246
}
246247
private bool? enableAzureActiveDirectoryDomainServicesForFile = null;
247248

249+
[CmdletParameterBreakingChange("EnableLargeFileShare", ChangeDescription = "EnableLargeFileShare parameter will be deprecated in a future release.")]
248250
[Parameter(Mandatory = false, HelpMessage = "Indicates whether or not the storage account can support large file shares with more than 5 TiB capacity. Once the account is enabled, the feature cannot be disabled. Currently only supported for LRS and ZRS replication types, hence account conversions to geo-redundant accounts would not be possible. Learn more in https://go.microsoft.com/fwlink/?linkid=2086047")]
249251
public SwitchParameter EnableLargeFileShare { get; set; }
250252

0 commit comments

Comments
 (0)