Skip to content

Commit 6a70582

Browse files
committed
Add comments.
1 parent 28e38ad commit 6a70582

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

tools/VersionController/Models/VersionBumper.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,13 @@ public void BumpAllVersions()
5959
Console.WriteLine("Updating version for " + _fileHelper.ModuleName + " from " + _oldVersion + " to " + _newVersion);
6060
}
6161

62-
UpdateSerializedAssemblyVersion();
62+
/*UpdateSerializedAssemblyVersion();
6363
UpdateChangeLog();
6464
var releaseNotes = GetReleaseNotes();
6565
UpdateOutputModuleManifest(releaseNotes);
6666
UpdateRollupModuleManifest();
6767
UpdateAssemblyInfo();
68-
UpdateDependentModules();
68+
UpdateDependentModules();*/
6969
Console.WriteLine("Finished bumping version " + moduleName + "\n");
7070
}
7171

@@ -171,8 +171,11 @@ private string GetBumpedVersion()
171171
{
172172
versionBump = Version.MINOR;
173173
}
174-
// Fix for https://github.com/Azure/azure-powershell/pull/12356
175-
// This only work when version is 1.9.x
174+
// for https://github.com/Azure/azure-powershell/pull/12356
175+
// Because of the wrong compare script in the link above, we need to avoid the minor bump when the version of Az.Accounts is 1.9.x
176+
// So we add a special judge for it when the version is 1.9.x and the expect bump type is minor,
177+
// we will change the type to patch so that it can work until 1.9.9.Once the version is greater or equal than 2.0.0
178+
// this special judge will not works anymore.
176179
if (splitVersion[0] == 1 && splitVersion[1] == 9 && versionBump == Version.MINOR)
177180
{
178181
versionBump = Version.PATCH;

0 commit comments

Comments
 (0)