Skip to content

Commit 6a94502

Browse files
authored
Add breaking change notification (#12649)
Co-authored-by: wyunchi-ms <[email protected]>
1 parent 1e839fc commit 6a94502

13 files changed

+29
-6
lines changed

src/Aks/Aks/Commands/NewKubeBase.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,14 @@
2121
using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
2222
using Microsoft.Azure.Management.ContainerService.Models;
2323
using Microsoft.WindowsAzure.Commands.Common;
24+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2425
using Microsoft.WindowsAzure.Commands.Utilities.Common;
2526

2627
namespace Microsoft.Azure.Commands.Aks
2728
{
2829
public abstract class NewKubeBase : CreateOrUpdateKubeBase
2930
{
31+
[CmdletParameterBreakingChange("NodeVmSetType", ChangeDescription = "Default value will be changed from AvailabilitySet to VirtualMachineScaleSets.")]
3032
[Parameter(Mandatory = false, HelpMessage = "Represents types of an node pool. Possible values include: 'VirtualMachineScaleSets', 'AvailabilitySet'")]
3133
[PSArgumentCompleter("AvailabilitySet", "VirtualMachineScaleSets")]
3234
public string NodeVmSetType { get; set; }
@@ -37,6 +39,7 @@ public abstract class NewKubeBase : CreateOrUpdateKubeBase
3739
[Parameter(Mandatory = false, HelpMessage = "Maximum number of pods that can run on node.")]
3840
public int NodeMaxPodCount { get; set; }
3941

42+
[CmdletParameterBreakingChange("NodeOsType", ChangeDescription = "NodeOsType will be removed as it supports only one value Linux.")]
4043
[Parameter(Mandatory = false, HelpMessage = "OsType to be used to specify os type, currently support 'Linux' only here.")]
4144
[PSArgumentCompleter("Linux")]
4245
public string NodeOsType { get; set; }
@@ -92,6 +95,7 @@ public abstract class NewKubeBase : CreateOrUpdateKubeBase
9295
+ "At least one lower case, one upper case, one special character !@#$%^&*(), the minimum lenth is 12.")]
9396
public SecureString WindowsProfileAdminUserPassword { get; set; }
9497

98+
[CmdletParameterBreakingChange("NetworkPlugin", ChangeDescription = "Default value will be changed from None to azure.")]
9599
[Parameter(Mandatory = false, HelpMessage = "Network plugin used for building Kubernetes network.")]
96100
[PSArgumentCompleter("azure", "kubenet")]
97101
public string NetworkPlugin { get; set; }

src/Resources/Resources/ManagementGroups/GetAzureRmManagementGroup.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
using Microsoft.Azure.Commands.Resources.Models.ManagementGroups;
1919
using Microsoft.Azure.Management.ManagementGroups;
2020
using Microsoft.Azure.Management.ManagementGroups.Models;
21+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2122

2223
namespace Microsoft.Azure.Commands.Resources.ManagementGroups
2324
{
@@ -30,6 +31,8 @@ public class GetAzureRmManagementGroup : AzureManagementGroupsCmdletBase
3031
/// <summary>
3132
/// Get-AzManagementGroup Cmdlet
3233
/// </summary>
34+
[Alias("GroupId")]
35+
[CmdletParameterBreakingChange("GroupName", ReplaceMentCmdletParameterName = "GroupId", ChangeDescription = "We will repleace GroupName with GroupId to make it more clear.")]
3336
[Parameter(ParameterSetName = Constants.ParameterSetNames.GetParameterSet, Mandatory = true, HelpMessage = Constants.HelpMessages.GroupName, Position = 0)]
3437
public string GroupName { get; set; }
3538

src/Resources/Resources/ManagementGroups/NewAzureRmManagementGroup.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
using Microsoft.Azure.Commands.Resources.Models.ManagementGroups;
1818
using Microsoft.Azure.Management.ManagementGroups;
1919
using Microsoft.Azure.Management.ManagementGroups.Models;
20+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
21+
2022
using Newtonsoft.Json;
2123
using Newtonsoft.Json.Linq;
2224

@@ -28,6 +30,8 @@ namespace Microsoft.Azure.Commands.Resources.ManagementGroups
2830
[Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ManagementGroup", DefaultParameterSetName = Constants.ParameterSetNames.GroupOperationsParameterSet, SupportsShouldProcess = true), OutputType(typeof(PSManagementGroup))]
2931
public class NewAzureRmManagementGroup : AzureManagementGroupsCmdletBase
3032
{
33+
[Alias("GroupId")]
34+
[CmdletParameterBreakingChange("GroupName", ReplaceMentCmdletParameterName = "GroupId", ChangeDescription = "We will repleace GroupName with GroupId to make it more clear.")]
3135
[Parameter(ParameterSetName = Constants.ParameterSetNames.GroupOperationsParameterSet, Mandatory = true, HelpMessage = Constants.HelpMessages.GroupName, Position = 0)]
3236
[Parameter(ParameterSetName = Constants.ParameterSetNames.ParentGroupParameterSet, Mandatory = true,
3337
HelpMessage = Constants.HelpMessages.ParentObject)]

src/Resources/Resources/ManagementGroups/NewAzureRmManagementGroupSubscription.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
using Microsoft.Azure.Commands.Resources.ManagementGroups.Common;
1818
using Microsoft.Azure.Management.ManagementGroups;
1919
using Microsoft.Azure.Management.ManagementGroups.Models;
20+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2021

2122
namespace Microsoft.Azure.Commands.Resources.ManagementGroups
2223
{
@@ -26,6 +27,8 @@ namespace Microsoft.Azure.Commands.Resources.ManagementGroups
2627
[Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ManagementGroupSubscription",DefaultParameterSetName = Constants.ParameterSetNames.GroupOperationsParameterSet,SupportsShouldProcess = true), OutputType(typeof(bool))]
2728
public class NewAzureRmManagementGroupSubscription : AzureManagementGroupsCmdletBase
2829
{
30+
[Alias("GroupId")]
31+
[CmdletParameterBreakingChange("GroupName", ReplaceMentCmdletParameterName = "GroupId", ChangeDescription = "We will repleace GroupName with GroupId to make it more clear.")]
2932
[Parameter(ParameterSetName = Constants.ParameterSetNames.GroupOperationsParameterSet, Mandatory = true,
3033
HelpMessage = Constants.HelpMessages.GroupName, Position = 0)]
3134
[ValidateNotNullOrEmpty]

src/Resources/Resources/ManagementGroups/RemoveAzureRmManagementGroup.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
using Microsoft.Azure.Commands.Resources.Models.ManagementGroups;
1818
using Microsoft.Azure.Management.ManagementGroups;
1919
using Microsoft.Azure.Management.ManagementGroups.Models;
20+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2021

2122
namespace Microsoft.Azure.Commands.Resources.ManagementGroups
2223
{
@@ -32,6 +33,8 @@ public class RemoveAzureRmManagementGroup : AzureManagementGroupsCmdletBase
3233
[ValidateNotNullOrEmpty]
3334
public PSManagementGroup InputObject { get; set; }
3435

36+
[Alias("GroupId")]
37+
[CmdletParameterBreakingChange("GroupName", ReplaceMentCmdletParameterName = "GroupId", ChangeDescription = "We will repleace GroupName with GroupId to make it more clear.")]
3538
[Parameter(ParameterSetName = Constants.ParameterSetNames.GroupOperationsParameterSet, Mandatory = true,
3639
HelpMessage = Constants.HelpMessages.GroupName, Position = 0)]
3740
[ValidateNotNullOrEmpty]

src/Resources/Resources/ManagementGroups/RemoveAzureRmManagementGroupSubscription.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
using Microsoft.Azure.Commands.Resources.ManagementGroups.Common;
1818
using Microsoft.Azure.Management.ManagementGroups;
1919
using Microsoft.Azure.Management.ManagementGroups.Models;
20+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2021

2122
namespace Microsoft.Azure.Commands.Resources.ManagementGroups
2223
{
@@ -26,6 +27,8 @@ namespace Microsoft.Azure.Commands.Resources.ManagementGroups
2627
[Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ManagementGroupSubscription",DefaultParameterSetName = Constants.ParameterSetNames.GroupOperationsParameterSet,SupportsShouldProcess = true), OutputType(typeof(bool))]
2728
public class RemoveAzureRmManagementGroupSubscription : AzureManagementGroupsCmdletBase
2829
{
30+
[Alias("GroupId")]
31+
[CmdletParameterBreakingChange("GroupName", ReplaceMentCmdletParameterName = "GroupId", ChangeDescription = "We will repleace GroupName with GroupId to make it more clear.")]
2932
[Parameter(ParameterSetName = Constants.ParameterSetNames.GroupOperationsParameterSet, Mandatory = true,
3033
HelpMessage = Constants.HelpMessages.GroupName, Position = 0)]
3134
[ValidateNotNullOrEmpty]

src/Resources/Resources/ManagementGroups/UpdateAzureRmManagementGroup.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
using Microsoft.Azure.Commands.Resources.Models.ManagementGroups;
1818
using Microsoft.Azure.Management.ManagementGroups;
1919
using Microsoft.Azure.Management.ManagementGroups.Models;
20+
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
2021

2122
namespace Microsoft.Azure.Commands.Resources.ManagementGroups
2223
{
@@ -30,6 +31,8 @@ public class UpdateAzureRmManagementGroup : AzureManagementGroupsCmdletBase
3031
[ValidateNotNullOrEmpty]
3132
public PSManagementGroup InputObject { get; set; }
3233

34+
[Alias("GroupId")]
35+
[CmdletParameterBreakingChange("GroupName", ReplaceMentCmdletParameterName = "GroupId", ChangeDescription = "We will repleace GroupName with GroupId to make it more clear.")]
3336
[Parameter(ParameterSetName = Constants.ParameterSetNames.ParentGroupParameterSet, Mandatory = true,
3437
HelpMessage = Constants.HelpMessages.InputObject, ValueFromPipeline = false)]
3538
[Parameter(ParameterSetName = Constants.ParameterSetNames.GroupOperationsParameterSet, Mandatory = true, HelpMessage = Constants.HelpMessages.GroupName, Position = 0)]

src/Resources/Resources/help/Get-AzManagementGroup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ Management Group Id
161161
```yaml
162162
Type: System.String
163163
Parameter Sets: GetOperation
164-
Aliases:
164+
Aliases: GroupId
165165

166166
Required: True
167167
Position: 0

src/Resources/Resources/help/New-AzManagementGroup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ Management Group Id
136136
```yaml
137137
Type: System.String
138138
Parameter Sets: (All)
139-
Aliases:
139+
Aliases: GroupId
140140

141141
Required: True
142142
Position: 0

src/Resources/Resources/help/New-AzManagementGroupSubscription.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Management Group Id
5050
```yaml
5151
Type: System.String
5252
Parameter Sets: (All)
53-
Aliases:
53+
Aliases: GroupId
5454

5555
Required: True
5656
Position: 0

0 commit comments

Comments
 (0)