Remove Geo for Rate Limiting Feature for Application Gateway Firewall Policy Settings (#23104)

* new

* new

* Update ChangeLog.md

* Update BreakingChangeIssues.csv

* mistake

* Update BreakingChangeIssues.csv

* Update ChangeLog.md

* Update ChangeLog.md

* Update BreakingChangeIssues.csv

---------

Co-authored-by: Yabo Hu <[email protected]>

Author: Shawnli222

src/Network/Network/ChangeLog.md

@@ -19,6 +19,7 @@
 --->
 
 ## Upcoming Release
+* [Breaking Change] Removed `Geo` as a valid input for parameter `VariableName` in `NewAzureApplicationGatewayFirewallCustomRuleGroupByVariable`.
 * Added AllowBranchToBranchTraffic property to New-AzRouteServer
 * Added AllowBranchToBranchTraffic property to Get-AzRouteServer
 * Changed Update-AzRouteServer functionality to fix bugs

src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs

@@ -13,7 +13,6 @@
 // ----------------------------------------------------------------------------------
 
 using Microsoft.Azure.Commands.Network.Models;
-using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Linq;
 using System.Management.Automation;
 
@@ -22,12 +21,11 @@ namespace Microsoft.Azure.Commands.Network
     [Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ApplicationGatewayFirewallCustomRuleGroupByVariable"), OutputType(typeof(PSApplicationGatewayFirewallCustomRuleGroupByVariable))]
     public class NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand : NetworkBaseCmdlet
     {
-        [CmdletParameterBreakingChangeWithVersionAttribute("VariableName", "11.0.0", "7.0.0", ChangeDescription = "Geo would be invalid for parameter VariableName")]
         [Parameter(
             Mandatory = true,
             HelpMessage = "User Session clause variable.")]
         [ValidateNotNullOrEmpty]
-        [ValidateSet("ClientAddr", "Geo", "GeoLocation", "None", IgnoreCase = true)]
+        [ValidateSet("ClientAddr", "GeoLocation", "None", IgnoreCase = true)]
         public string VariableName { get; set; }
 
         public override void ExecuteCmdlet()

src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md

@@ -53,7 +53,7 @@ User Session clause variable.
 Type: System.String
 Parameter Sets: (All)
 Aliases:
-Accepted values: ClientAddr, Geo, GeoLocation, None
+Accepted values: ClientAddr, GeoLocation, None
 
 Required: True
 Position: Named

tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv

@@ -1,3 +1,4 @@
 "Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
 "Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","2020","The cmdlet 'Update-AzRouteServer' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'AllowBranchToBranchTraffic'.","Change the type for parameter 'AllowBranchToBranchTraffic' back to 'System.Management.Automation.SwitchParameter'."
-"Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzRouteServer' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzRouteServer'."
+"Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmRouteServer","Update-AzRouteServer","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzRouteServer' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzRouteServer'."
+"Az.Network","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand","New-AzApplicationGatewayFirewallCustomRuleGroupByVariable","0","2040","The validation set for parameter 'VariableName' for cmdlet 'New-AzApplicationGatewayFirewallCustomRuleGroupByVariable' no longer contains the value 'Geo'.","Add 'Geo' back to the validation set for 'VariableName'."