Add DisableTcpStateTracking to Nic Property (#19486)

* draft

* add tests

* 2nd try

* trial

* add in generated.format

Co-authored-by: Dan Tu <[email protected]>

Author: dtuCloud

src/Network/Network.Test/ScenarioTests/NetworkInterfaceTests.cs

@@ -115,6 +115,14 @@ public void TestNetworkInterfaceWithAcceleratedNetworking()
             TestRunner.RunTestScript("Test-NetworkInterfaceWithAcceleratedNetworking");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        [Trait(Category.Owner, NrpTeamAlias.sdnnrp)]
+        public void TestNetworkInterfaceWithDisableTcpStateTracking()
+        {
+            TestRunner.RunTestScript("Test-NetworkInterfaceWithDisableTcpStateTracking");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         [Trait(Category.Owner, NrpTeamAlias.sdnnrp)]

src/Network/Network.Test/ScenarioTests/NetworkInterfaceTests.ps1

@@ -983,6 +983,56 @@ function Test-NetworkInterfaceWithAcceleratedNetworking
     }
 }
 
+<#
+.SYNOPSIS
+Tests creating new simple public networkinterface with disableTcpStateTracking Property.
+#>
+function Test-NetworkInterfaceWithDisableTcpStateTracking
+{
+   # Setup
+    $rgname = Get-ResourceGroupName
+    $vnetName = Get-ResourceName
+    $subnetName = Get-ResourceName
+    $publicIpName = Get-ResourceName
+    $nicName = Get-ResourceName
+    $domainNameLabel = Get-ResourceName
+    $rglocation = Get-ProviderLocation ResourceManagement "eastus2euap"
+    $resourceTypeParent = "Microsoft.Network/networkInterfaces"
+    $location = Get-ProviderLocation $resourceTypeParent "eastus2euap"
+    
+    try 
+    {
+        # Create the resource group
+        $resourceGroup = New-AzResourceGroup -Name $rgname -Location $rglocation -Tags @{ testtag = "testval" } 
+        # Create the Virtual Network
+        $subnet = New-AzVirtualNetworkSubnetConfig -Name $subnetName -AddressPrefix 10.0.1.0/24
+        $vnet = New-AzVirtualNetwork -Name $vnetName -ResourceGroupName $rgname -Location $location -AddressPrefix 10.0.0.0/16 -Subnet $subnet
+        
+        # Create the publicip
+        $publicip = New-AzPublicIpAddress -ResourceGroupName $rgname -name $publicIpName -location $location -AllocationMethod Dynamic -DomainNameLabel $domainNameLabel
+
+        # Create NetworkInterface with DisableTcpStateTracking Property set to true
+        $actualNic = New-AzNetworkInterface -Name $nicName -ResourceGroupName $rgname -Location $location -Subnet $vnet.Subnets[0] -PublicIpAddress $publicip -DisableTcpStateTracking true
+        $expectedNic = Get-AzNetworkInterface -Name $nicName -ResourceGroupName $rgname
+
+        Assert-NotNull $expectedNic.ResourceGuid
+        Assert-AreEqual "Succeeded" $expectedNic.ProvisioningState
+        Assert-AreEqual $true $expectedNic.DisableTcpStateTracking
+
+        # Delete ResourceGroup
+        $delete = Remove-AzNetworkInterface -ResourceGroupName $rgname -name $nicName -PassThru -Force
+        Assert-AreEqual true $delete
+        
+        $list = Get-AzNetworkInterface -ResourceGroupName $rgname
+        Assert-AreEqual 0 @($list).Count
+    }
+    finally
+    {
+        # Cleanup
+        Clean-ResourceGroup $rgname
+    }
+}
+
 <#
 .SYNOPSIS
 Test creating new NetworkInterfaceTapConfiguration using minimal set of parameters

src/Network/Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkInterfaceTests/TestNetworkInterfaceWithDisableTcpStateTracking.json

@@ -25,6 +25,8 @@
     - `New-AzVirtualNetworkGatewayConnection`
 * Updated commandlet to support no-internet advertise CustomIpPrefix.
     - `Update-AzCustomIpPrefix`
+* Updated commandlet to support create/update nic with DisableTcpStateTracking property
+	- `New-AzNetworkInterface`
 * Updated commandlets to support specifying a VirtualRouterAsn on Virtual Hub
     - `NewAzureRmVirtualHubCommand.cs`
     - `UpdateAzureRmVirtualHubCommand.cs`

src/Network/Network/ChangeLog.md

@@ -43,6 +43,9 @@ public class PSNetworkInterface : PSTopLevelResource, INetworkInterfaceReference
         [Ps1Xml(Target = ViewControl.Table)]
         public bool? EnableIPForwarding { get; set; }
 
+        [Ps1Xml(Target = ViewControl.Table)]
+        public string DisableTcpStateTracking { get; set; }
+
         public List<string> HostedWorkloads { get; set; }
 
         public PSNetworkSecurityGroup NetworkSecurityGroup { get; set; }

src/Network/Network/Models/PSNetworkInterface.cs

@@ -1876,6 +1876,10 @@
                 <Label>VnetEncryptionSupported</Label>
                 <PropertyName>VnetEncryptionSupported</PropertyName>
               </ListItem>
+              <ListItem>
+                <Label>DisableTcpStateTracking</Label>
+                <PropertyName>DisableTcpStateTracking</PropertyName>
+              </ListItem>
               <ListItem>
                 <Label>AuxiliaryMode</Label>
                 <PropertyName>AuxiliaryMode</PropertyName>

src/Network/Network/Network.format.ps1xml

@@ -2008,6 +2008,10 @@
             <Alignment>Left</Alignment>
             <Label>EnableAcceleratedNetworking</Label>
           </TableColumnHeader>
+          <TableColumnHeader>
+            <Alignment>Left</Alignment>
+            <Label>DisableTcpStateTracking</Label>
+          </TableColumnHeader>
           <TableColumnHeader>
             <Alignment>Left</Alignment>
             <Label>EnableIPForwarding</Label>
@@ -2043,6 +2047,10 @@
               <TableColumnItem>
                 <Alignment>Left</Alignment>
                 <PropertyName>EnableAcceleratedNetworking</PropertyName>
+              </TableColumnItem>
+			  <TableColumnItem>
+                <Alignment>Left</Alignment>
+                <PropertyName>DisableTcpStateTracking</PropertyName>
               </TableColumnItem>
               <TableColumnItem>
                 <Alignment>Left</Alignment>

src/Network/Network/Network.generated.format.ps1xml

@@ -223,6 +223,12 @@ public class NewAzureNetworkInterfaceCommand : NetworkInterfaceBaseCmdlet
             HelpMessage = "The Internal Dns name")]
         public string InternalDnsNameLabel { get; set; }
 
+        [Parameter(
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "DisableTcpStateTracking")]
+        public string DisableTcpStateTracking { get; set; }
+
         [Parameter(
             Mandatory = false,
             HelpMessage = "EnableIPForwarding")]
@@ -290,6 +296,11 @@ private PSNetworkInterface CreateNetworkInterface()
                 networkInterface.ExtendedLocation = new PSExtendedLocation(this.EdgeZone);
             }
 
+            if (!string.IsNullOrEmpty(DisableTcpStateTracking))
+            {
+                networkInterface.DisableTcpStateTracking = this.DisableTcpStateTracking;
+            }
+
             networkInterface.EnableIPForwarding = this.EnableIPForwarding.IsPresent;
             networkInterface.EnableAcceleratedNetworking = this.EnableAcceleratedNetworking.IsPresent;
 

src/Network/Network/NetworkInterface/NewAzureNetworkInterfaceCommand.cs

@@ -186,6 +186,20 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
+### -DisableTcpStateTracking
+Indicates whether to disable tcp state tracking.
+
+```yaml
+Type: System.String
+Parameter Sets: (All)
+Aliases:
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: True (ByPropertyName)
+Accept wildcard characters: False
+```
+
 ### -DnsServer
 Specifies the DNS server for the network interface.