Skip to content

Commit 6f37822

Browse files
hiaganotyashhh
andauthored
Enabling logs to investigate SQL protection issue (#27313)
Co-authored-by: Yash <[email protected]>
1 parent b6c0cef commit 6f37822

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/AzureWorkloadPsBackupProvider.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -929,6 +929,8 @@ private RestAzureNS.AzureOperationResponse<ProtectedItemResource> EnableOrModify
929929
keyValueDict, item.Id);
930930

931931
properties.PolicyId = policy.Id;
932+
933+
Logger.Instance.WriteDebug("Successfully parsed Item URI");
932934
}
933935
}
934936

@@ -937,6 +939,7 @@ private RestAzureNS.AzureOperationResponse<ProtectedItemResource> EnableOrModify
937939
Properties = properties
938940
};
939941

942+
Logger.Instance.WriteDebug("checking for MUA for modify policy");
940943
// check for MUA
941944
bool isMUAProtected = false;
942945
if (isMUAOperation && oldPolicy != null && newPolicy != null)
@@ -947,7 +950,8 @@ private RestAzureNS.AzureOperationResponse<ProtectedItemResource> EnableOrModify
947950
{
948951
isMUAProtected = true;
949952
}
950-
953+
954+
Logger.Instance.WriteDebug("Entering CreateOrUpdateProtectedItem");
951955
return ServiceClientAdapter.CreateOrUpdateProtectedItem(
952956
containerUri,
953957
protectedItemUri,
@@ -1144,4 +1148,4 @@ private void ValidateAzureWorkloadDisableProtectionRequest(ItemBase itemBase)
11441148
ValidateAzureWorkloadContainerType(itemBase.ContainerType);
11451149
}
11461150
}
1147-
}
1151+
}

src/RecoveryServices/RecoveryServices.Backup.ServiceClientAdapter/BMSAPIs/ItemAPIs.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ public RestAzureNS.AzureOperationResponse<ProtectedItemResource> CreateOrUpdateP
9494
}
9595
}
9696

97+
Logger.Instance.WriteDebug("Executing CreateOrUpdateWithHttpMessagesAsync");
9798
return BmsAdapter.Client.ProtectedItems.CreateOrUpdateWithHttpMessagesAsync(
9899
vaultName ?? BmsAdapter.GetResourceName(),
99100
resourceGroupName ?? BmsAdapter.GetResourceGroupName(),

src/RecoveryServices/RecoveryServices.Backup/Cmdlets/Item/EnableAzureRmRecoveryServicesBackupProtection.cs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ public override void ExecuteCmdlet()
173173
string.Compare(((AzureWorkloadProtectableItem)ProtectableItem).ProtectableItemType,
174174
ProtectableItemType.SQLInstance.ToString()) == 0))
175175
{
176+
WriteDebug("Executing AzureWorkloadParameterSet");
177+
176178
string backupManagementType = ProtectableItem.BackupManagementType.ToString();
177179
string workloadType = ConversionUtils.GetServiceClientWorkloadType(ProtectableItem.WorkloadType.ToString());
178180
string containerName = "VMAppContainer;" + ((AzureWorkloadProtectableItem)ProtectableItem).ContainerName;
@@ -237,6 +239,8 @@ public override void ExecuteCmdlet()
237239
}
238240
else
239241
{
242+
WriteDebug("Executing parameter set: " + ParameterSetName);
243+
240244
PsBackupProviderManager providerManager =
241245
new PsBackupProviderManager(new Dictionary<Enum, object>()
242246
{
@@ -258,10 +262,14 @@ public override void ExecuteCmdlet()
258262
{ ResourceGuardParams.IsMUAOperation, isMUAOperation },
259263
}, ServiceClientAdapter);
260264

265+
WriteDebug("Initialized provider manager");
266+
261267
IPsBackupProvider psBackupProvider = (Item != null) ?
262268
providerManager.GetProviderInstance(Item.WorkloadType, Item.BackupManagementType)
263269
: providerManager.GetProviderInstance(Policy.WorkloadType);
264-
270+
271+
WriteDebug("policy workload type: " + Policy.WorkloadType.ToString());
272+
265273
if (Policy.WorkloadType == Models.WorkloadType.AzureFiles)
266274
{
267275
// if item & policy are not null and both have ids
@@ -312,6 +320,8 @@ public override void ExecuteCmdlet()
312320

313321
var itemResponse = psBackupProvider.EnableProtection();
314322

323+
WriteDebug("Enabled protection successfully, going to handle the backup job");
324+
315325
// Track Response and display job details
316326
HandleCreatedJob(
317327
itemResponse,

src/RecoveryServices/RecoveryServices/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Added logs to enable better debugging for Modify protection with MSSQL workload.
2122

2223
## Version 7.5.1
2324
* Updated Restore-AzRecoveryServicesBackupItem to support 0 as a TargetZoneNumber to restore to NoZone.

0 commit comments

Comments
 (0)