Add telemetry to detect potential infinite recursion properties (#24709)

Author: vidai-msft

src/Accounts/Authentication/Sanitizer/Providers/SanitizerCollectionProvider.cs

@@ -51,7 +51,7 @@ public override void SanitizeValue(object sanitizingObject, Stack<object> saniti
                         }
                         else
                         {
-                            if (!collItemType.IsValueType && !sanitizingStack.Contains(collItem) && !ExceedsMaxDepth(property))
+                            if (!collItemType.IsValueType && !sanitizingStack.Contains(collItem) && !ExceedsMaxDepth(property, telemetry))
                             {
                                 var provider = resolver.ResolveProvider(collItem.GetType());
                                 provider?.SanitizeValue(collItem, sanitizingStack, resolver, property, telemetry);

src/Accounts/Authentication/Sanitizer/Providers/SanitizerCustomObjectProvider.cs

@@ -47,7 +47,7 @@ public override void SanitizeValue(object sanitizingObject, Stack<object> saniti
                         }
                         else
                         {
-                            if (!propValueType.IsValueType && !sanitizingStack.Contains(propValue) && !ExceedsMaxDepth(prop))
+                            if (!propValueType.IsValueType && !sanitizingStack.Contains(propValue) && !ExceedsMaxDepth(prop, telemetry))
                             {
                                 provider.SanitizeValue(propValue, sanitizingStack, resolver, prop, telemetry);
                             }

src/Accounts/Authentication/Sanitizer/Providers/SanitizerDictionaryProvider.cs

@@ -53,7 +53,7 @@ public override void SanitizeValue(object sanitizingObject, Stack<object> saniti
                         }
                         else
                         {
-                            if (!dicItemValueType.IsValueType && !sanitizingStack.Contains(dictItemValue) && !ExceedsMaxDepth(property))
+                            if (!dicItemValueType.IsValueType && !sanitizingStack.Contains(dictItemValue) && !ExceedsMaxDepth(property, telemetry))
                             {
                                 var provider = resolver.ResolveProvider(dicItemValueType);
                                 provider?.SanitizeValue(dictItemValue, sanitizingStack, resolver, property, telemetry);

src/Accounts/Authentication/Sanitizer/Providers/SanitizerProviderBase.cs

@@ -12,7 +12,9 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------
 
+using System;
 using System.Collections.Generic;
+using Microsoft.ApplicationInsights.Channel;
 using Microsoft.Azure.Commands.Common.Authentication.Sanitizer.Services;
 using Microsoft.WindowsAzure.Commands.Common.Sanitizer;
 
@@ -44,7 +46,7 @@ protected string ResolvePropertyPath(SanitizerProperty property)
             return propertyPath;
         }
 
-        protected bool ExceedsMaxDepth(SanitizerProperty property)
+        protected bool ExceedsMaxDepth(SanitizerProperty property, SanitizerTelemetry telemetry)
         {
             if (property == null)
                 return false;
@@ -59,6 +61,9 @@ protected bool ExceedsMaxDepth(SanitizerProperty property)
                 currentProperty = currentProperty.ParentProperty;
             }
 
+            telemetry.HasErrorInDetection = true;
+            telemetry.DetectionError = new Exception($"Potential stack overflow exception may occurr on property: {property.PropertyName}!");
+
             return true;
         }