Changing threat detection policy "without a storage account name" error

Changing threat detection policy "without a storage account name" error

Author: yaakoviyun

src/ResourceManager/Sql/Commands.Sql/Properties/Resources.resx

@@ -174,6 +174,9 @@
   <data name="NoStorageAccountWhenConfiguringAuditingPolicy" xml:space="preserve">
     <value>Cannot set auditing policy without a storage account name.</value>
   </data>
+  <data name="NoStorageAccountWhenConfiguringThreatDetectionPolicy" xml:space="preserve">
+    <value>Cannot set threat detection policy without a storage account name.</value>
+  </data>
   <data name="PdoTitle" xml:space="preserve">
     <value>PHP Data Objects(PDO) Sample Code:</value>
   </data>

src/ResourceManager/Sql/Commands.Sql/ThreatDetection/Services/SqlThreatDetectionAdapter.cs

@@ -265,6 +265,11 @@ private BaseSecurityAlertPolicyProperties PopulatePolicyProperties(BaseThreatDet
 
         private void PopulateStoragePropertiesInPolicy(BaseThreatDetectionPolicyModel model, BaseSecurityAlertPolicyProperties properties, string storageEndpointSuffix)
         {
+            if (string.IsNullOrEmpty(model.StorageAccountName)) // can happen if the user didn't provide account name for a policy that lacked it 
+            {
+                throw new Exception(string.Format(Properties.Resources.NoStorageAccountWhenConfiguringThreatDetectionPolicy));
+            }
+
             properties.StorageEndpoint = string.Format("https://{0}.blob.{1}", model.StorageAccountName, storageEndpointSuffix);
             properties.StorageAccountAccessKey =  AzureCommunicator.GetStorageKeys(model.StorageAccountName)[StorageKeyKind.Primary];
         }