Skip to content

Commit 754c9b3

Browse files
authored
Disable codeql for test coverage and reduce the frequency of live test for sql and synapse (#25650)
1 parent 508b8c0 commit 754c9b3

File tree

3 files changed

+21
-22
lines changed

3 files changed

+21
-22
lines changed

.azure-pipelines/test-coverage.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ parameters:
1919
variables:
2020
EnableTestCoverage: true
2121
TestCoverageLocation: $(Pipeline.Workspace)/artifacts
22+
Codeql.Enabled: false
2223

2324
pr: none
2425
trigger: none

src/Sql/Sql.Test/LiveTests/TestLiveScenarios.ps1

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Invoke-LiveTestScenario -Name "Create, get, update and remove a new SQL Server" -Description "Test on new SQL Server" -ScenarioScript `
1+
Invoke-LiveTestScenario -Name "Create, get, update and remove a new SQL Server" -Description "Test on new SQL Server" -PowerShellVersion "5.1", "Latest" -ScenarioScript `
22
{
33
param ($rg)
44

@@ -11,8 +11,7 @@ Invoke-LiveTestScenario -Name "Create, get, update and remove a new SQL Server"
1111
$actual = New-AzSqlServer -ResourceGroupName $rgName `
1212
-ServerName $serverName `
1313
-Location $location `
14-
-SqlAdministratorCredentials `
15-
$(New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList $adminSqlLogin, $(ConvertTo-SecureString -String $password -AsPlainText -Force))
14+
-SqlAdministratorCredentials $(New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList $adminSqlLogin, $(ConvertTo-SecureString -String $password -AsPlainText -Force))
1615
Assert-AreEqual $serverName $actual.ServerName
1716
Assert-AreEqual $rgName $actual.ResourceGroupName
1817
# Get created Sql Server
@@ -23,11 +22,11 @@ Invoke-LiveTestScenario -Name "Create, get, update and remove a new SQL Server"
2322
$secureString = ConvertTo-SecureString $updatedPassword -AsPlainText -Force
2423
$null = Set-AzSqlServer -ResourceGroupName $rgName -ServerName $serverName -PublicNetworkAccess Disabled
2524
$actual = Get-AzSqlServer -ResourceGroupName $rgName -ServerName $serverName
26-
Assert-AreEqual "Disabled" $actual.PublicNetworkAccess
25+
Assert-AreEqual "Disabled" $actual.PublicNetworkAccess
2726
# Remove a Sql server
2827
$null = Remove-AzSqlServer -ResourceGroup $rgName -ServerName $serverName
2928
$actual = Get-AzSqlServer -ResourceGroup $rgName
30-
Assert-False { $actual.ServerName -contains $serverName}
29+
Assert-False { $actual.ServerName -contains $serverName }
3130
}
3231
# After testing the cmdlets of Sql Server, create a Sql Server for sql database testing.
3332

@@ -44,10 +43,9 @@ $ServerName = New-LiveTestResourceName
4443
$SqlServer = New-AzSqlServer -ResourceGroupName $RgName `
4544
-ServerName $ServerName `
4645
-Location $ResourceGroupLocation `
47-
-SqlAdministratorCredentials `
48-
$(New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList $AdminSqlLogin, $(ConvertTo-SecureString -String $Password -AsPlainText -Force))
46+
-SqlAdministratorCredentials $(New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList $AdminSqlLogin, $(ConvertTo-SecureString -String $Password -AsPlainText -Force))
4947

50-
Invoke-LiveTestScenario -Name "Create a Sql Database" -Description "Test New-AzSqlDatabase" -NoResourceGroup -ScenarioScript `
48+
Invoke-LiveTestScenario -Name "Create a Sql Database" -Description "Test New-AzSqlDatabase" -PowerShellVersion "5.1", "Latest" -NoResourceGroup -ScenarioScript `
5149
{
5250
$dbName = New-LiveTestResourceName
5351

@@ -59,19 +57,19 @@ Invoke-LiveTestScenario -Name "Create a Sql Database" -Description "Test New-AzS
5957
Remove-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
6058
}
6159

62-
Invoke-LiveTestScenario -Name "Get a Sql Database" -Description "Test Get-AzSqlDatabase" -NoResourceGroup -ScenarioScript `
60+
Invoke-LiveTestScenario -Name "Get a Sql Database" -Description "Test Get-AzSqlDatabase" -PowerShellVersion "5.1", "Latest" -NoResourceGroup -ScenarioScript `
6361
{
6462
$dbName = New-LiveTestResourceName
6563

6664
$null = New-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
67-
$actual = Get-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
65+
$actual = Get-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
6866
Assert-AreEqual $serverName $actual.ServerName
6967
Assert-AreEqual $rgName $actual.ResourceGroupName
7068
Assert-AreEqual $dbName $actual.DatabaseName
7169
Remove-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
7270
}
7371

74-
Invoke-LiveTestScenario -Name "Update a Sql Database" -Description "Test Set-AzSqlDatabase" -NoResourceGroup -ScenarioScript `
72+
Invoke-LiveTestScenario -Name "Update a Sql Database" -Description "Test Set-AzSqlDatabase" -PowerShellVersion "5.1", "Latest" -NoResourceGroup -ScenarioScript `
7573
{
7674
$dbName = New-LiveTestResourceName
7775

@@ -80,19 +78,19 @@ Invoke-LiveTestScenario -Name "Update a Sql Database" -Description "Test Set-AzS
8078
$actual = Get-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
8179
Assert-AreEqual $dbName $actual.DatabaseName
8280
Assert-AreEqual "S0" $actual.RequestedServiceObjectiveName
83-
Assert-AreEqual "Standard" $actual.Edition
81+
Assert-AreEqual "Standard" $actual.Edition
8482
Remove-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
8583
}
8684

87-
Invoke-LiveTestScenario -Name "Remove a Sql Database" -Description "Test Remove-AzSqlDatabase" -NoResourceGroup -ScenarioScript `
85+
Invoke-LiveTestScenario -Name "Remove a Sql Database" -Description "Test Remove-AzSqlDatabase" -PowerShellVersion "5.1", "Latest" -NoResourceGroup -ScenarioScript `
8886
{
8987
$dbName = New-LiveTestResourceName
9088

9189
$null = New-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
9290
Remove-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName -DatabaseName $dbName
9391
$actual = Get-AzSqlDatabase -ResourceGroupName $RgName -ServerName $ServerName
9492

95-
Assert-False { $actual.DatabaseName -contains $dbName}
93+
Assert-False { $actual.DatabaseName -contains $dbName }
9694
}
9795
# At the end of db test, clear the resource group
98-
Clear-LiveTestResources -Name $RgName
96+
Clear-LiveTestResources -Name $RgName

src/Synapse/Synapse.Test/LiveTests/TestLiveScenarios.ps1

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,22 @@ function GenerateDefinitionFile {
55
)
66

77
$definition = [PSCustomObject]@{
8-
name = "DataFlow"
8+
name = "DataFlow"
99
properties = [PSCustomObject]@{
10-
type = "MappingDataFlow"
10+
type = "MappingDataFlow"
1111
typeProperties = [PSCustomObject]@{
12-
sources = @()
13-
sinks = @()
12+
sources = @()
13+
sinks = @()
1414
transformations = @()
15-
scriptLines = @("")
15+
scriptLines = @("")
1616
}
1717
}
1818
}
1919

2020
ConvertTo-Json $definition -Compress -Depth 3 | Out-File -FilePath $File -Encoding utf8 -NoNewline -Force
2121
}
2222

23-
Invoke-LiveTestScenario -Name "Create synapse data flow" -Description "Test creating a synapse data flow" -ScenarioScript `
23+
Invoke-LiveTestScenario -Name "Create synapse data flow" -Description "Test creating a synapse data flow" -PowerShellVersion "5.1", "Latest" -ScenarioScript `
2424
{
2525
param ($rg)
2626

@@ -50,7 +50,7 @@ Invoke-LiveTestScenario -Name "Create synapse data flow" -Description "Test crea
5050
Assert-AreEqual $flowName $actual.Name
5151
}
5252

53-
Invoke-LiveTestScenario -Name "Remove synapse data flow" -Description "Test removing a synapse data flow" -ScenarioScript `
53+
Invoke-LiveTestScenario -Name "Remove synapse data flow" -Description "Test removing a synapse data flow" -PowerShellVersion "5.1", "Latest" -ScenarioScript `
5454
{
5555
param ($rg)
5656

0 commit comments

Comments
 (0)