[Az.Sql] Add support for cross-subscription Azure SQL Database Failover Group creation (#19027)

* Added PartnerSubscriptionId to Azure Sql Failover Group models

* Converted PartnerSubscriptionId to string

* Added Scenario Test for testing PartnerSubscriptionId parameter

* Ran Update-Markdownhelp command and added new example in
New-AzSqlDatabaseFailoverGroup.md

* Added new feature to ChangeLog.md

* Reverted unintended chagnes in src/Synapse codepath

* Fixed the test command name and added output to markdown help file

* Added ValidateNotNullOrEmpty tag to PartnerSubscriptionId

* Removed extra line from ChangeLog.md

Co-authored-by: Sharan Singh <[email protected]>

Author: SharanSingh

src/Sql/Sql.Test/ScenarioTests/FailoverGroupTests.cs

@@ -82,6 +82,13 @@ public void TestCreateFailoverGroup_Overflow()
             TestRunner.RunTestScript("Test-CreateFailoverGroup-Overflow");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestCreateFailoverGroup_CrossSubscription()
+        {
+            TestRunner.RunTestScript("Test-CreateFailoverGroup-CrossSubscription");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestSetFailoverGroup_Named()

src/Sql/Sql.Test/ScenarioTests/FailoverGroupTests.ps1

@@ -50,6 +50,7 @@ function Validate-FailoverGroup($server, $partnerServer, $name, $role, $failover
 	Assert-NotNull $fg.Id "`$fg.Id ($message)"
 	Assert-NotNull $fg.PartnerServers "`$fg.PartnerServers ($message)"
 	Assert-AreEqual $name $fg.FailoverGroupName "`$fg.FailoverGroupName ($message)"
+	# Assert-AreEqual $true $partnerServer.ResourceId.Contains($fg.PartnerSubscriptionId) "`$fg.PartnerSubscriptionId ($message)"
 	Assert-AreEqual $server.ResourceGroupName $fg.ResourceGroupName "`$fg.ResourceGroupName ($message)"
 	Assert-AreEqual $partnerServer.ResourceGroupName $fg.PartnerResourceGroupName "`$fg.PartnerResourceGroupName ($message)"
 	Assert-AreEqual $server.ServerName $fg.ServerName "`$fg.ServerName ($message)"
@@ -236,6 +237,19 @@ function Test-CreateFailoverGroup-Overflow()
 	}
 }
 
+function Test-CreateFailoverGroup-CrossSubscription()
+{
+	Handle-FailoverGroupTest {
+		Param($server, $partnerServer)
+
+		$fgName = Get-FailoverGroupName
+		$partnerSubscriptionId = $partnerServer.ResourceId.Split('/')[2]
+		$fg = $server | New-AzSqlDatabaseFailoverGroup -FailoverGroupName $fgName -PartnerSubscriptionId $partnerSubscriptionId -PartnerResourceGroupName $partnerServer.ResourceGroupName -PartnerServerName $partnerServer.ServerName -FailoverPolicy Manual
+		Validate-FailoverGroup $server $partnerServer $fgName Primary Manual $null Disabled @() $fg
+		Validate-FailoverGroupWithGet $fg
+	}
+}
+
 function Test-SetFailoverGroup-Named()
 {
 	Handle-FailoverGroupTestWithFailoverGroup {