Skip to content

Commit 7be018a

Browse files
Nickcandywyunchi-ms
Nickcandy
and
wyunchi-ms
authored
update to Changed-module build (#23331)
* revise build process * Update code-sign.yml for Azure Pipelines * Update code-sign.yml for Azure Pipelines * Update code-sign.yml for Azure Pipelines * fix build module process * Update build.proj Co-authored-by: Yunchi Wang <[email protected]> * fix buildmodules script * fix buildmodules script * fix buildmodules script * Update code-oob.yml for Azure Pipelines --------- Co-authored-by: Yunchi Wang <[email protected]>
1 parent 4fd4461 commit 7be018a

File tree

14 files changed

+344
-112
lines changed

14 files changed

+344
-112
lines changed

‎.azure-pipelines/code-oob.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ stages:
2424
inputs:
2525
command: custom
2626
custom: msbuild
27-
arguments: 'build.proj "/t:Clean;Build" /p:Configuration=Release'
27+
arguments: 'build.proj "/t:Clean;Build" /p:Configuration=Release;TargetModule=${{ parameters.ServiceName }}'
2828
- pwsh: |
2929
.\tools\RunVersionController.ps1 -ModuleName "Az.${{ parameters.ServiceName }}”
3030
displayName: 'Bump up version'
@@ -140,6 +140,8 @@ stages:
140140
- template: ./code-sign.yml
141141
parameters:
142142
OOBBranch: $(BumpUpBranch)
143+
TargetModule: ${{ parameters.ServiceName }}
144+
BuildInstaller: false
143145
- job: PulishForTest
144146
dependsOn: Release
145147
steps:

‎.azure-pipelines/code-sign.yml

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@ parameters:
33
displayName: Branch for OOB pipeline
44
type: string
55
default: 'none'
6+
- name: TargetModule
7+
displayName: Build Module List(Split by ':')
8+
type: string
9+
default: 'none'
10+
- name: BuildInstaller
11+
displayName: Build Installer
12+
type: boolean
13+
default: true
614
jobs:
715
- job: Release
816
timeoutInMinutes: 180
@@ -31,10 +39,19 @@ jobs:
3139

3240
- task: DotNetCoreCLI@2
3341
displayName: Build
42+
condition: ne('${{ parameters.TargetModule }}', 'none')
43+
inputs:
44+
command: custom
45+
custom: msbuild
46+
arguments: 'build.proj /t:"Build;CopyAboutTopics;GenerateHelp" /p:"Configuration=Release;GenerateDocumentationFile=true;TargetModule=${{ parameters.TargetModule }}"'
47+
- task: DotNetCoreCLI@2
48+
displayName: Build
49+
condition: eq('${{ parameters.TargetModule }}', 'none')
3450
inputs:
3551
command: custom
3652
custom: msbuild
37-
arguments: 'build.proj /t:"Build;CopyAboutTopics;GenerateHelp" /p:"Configuration=Release;GenerateDocumentationFile=true"'
53+
arguments: 'build.proj /t:"Build;CopyAboutTopics;GenerateHelp" /p:"Configuration=Release;GenerateDocumentationFile=true;ModifiedModuleBuild=true"'
54+
3855

3956
- task: AzureArtifacts.manifest-generator-task.manifest-generator-task.ManifestGeneratorTask@0
4057
displayName: 'Manifest Generator '
@@ -359,9 +376,11 @@ jobs:
359376
./setup/generate.ps1 -repository MSIcreationrepository
360377
Unregister-PSRepository -Name MSIcreationrepository
361378
displayName: 'Build Installer'
379+
condition: eq(${{ parameters.buildInstaller }}, true)
362380
363381
- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@4
364382
displayName: 'Installer Signing [Authenticode]'
383+
condition: eq(${{ parameters.buildInstaller }}, true)
365384
inputs:
366385
ConnectedServiceName: 'ESRP Signing Service'
367386
FolderPath: setup
@@ -404,9 +423,11 @@ jobs:
404423
Get-ChildItem $Env:RepoArtifacts/$folderName
405424
Copy-Item $Env:RepoArtifacts/$Env:Configuration/InstallModule.ps1 -Destination $Env:RepoArtifacts/$folderName
406425
displayName: 'Gather nuget packages and install script'
426+
condition: eq(${{ parameters.buildInstaller }}, true)
407427
408428
- task: ArchiveFiles@2
409429
displayName: 'Pack nuget packages as Az-Cmdlets-latest.tar.gz'
430+
condition: eq(${{ parameters.buildInstaller }}, true)
410431
inputs:
411432
rootFolderOrFile: 'artifacts/$(LocalRepoName)'
412433
includeRootFolder: false
@@ -432,9 +453,11 @@ jobs:
432453
" - "+$sha256.Hash+"`n"
433454
New-Item -Path "setup" -Name "ReleaseNotes.txt" -ItemType File -Force -Value $value
434455
displayName: 'Rename Az-Cmdlets-latest.tar.gz and Calculate SHA256'
456+
condition: eq(${{ parameters.buildInstaller }}, true)
435457
436458
- task: PublishBuildArtifacts@1
437459
displayName: 'Publish Artifact: installer'
460+
condition: eq(${{ parameters.buildInstaller }}, true)
438461
inputs:
439462
PathtoPublish: setup
440463
ArtifactName: setup
@@ -468,4 +491,4 @@ jobs:
468491
Get-ChildItem -Path $Env:RepoArtifacts -Filter Az.*.0.*.*.nupkg | Compress-Archive -DestinationPath "$buildName-preview.zip" -PassThru | Set-AzStorageBlobContent -Container $(ContainerName) -Context $context -Force
469492
azurePowerShellVersion: LatestVersion
470493
pwsh: true
471-
condition: and(succeeded(), eq(variables['PushPackageToStorageAccount'], 'true'))
494+
condition: and(succeeded(), eq(variables['PushPackageToStorageAccount'], 'true'), eq(${{ parameters.buildInstaller }}, true))

‎.azure-pipelines/daily-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
inputs:
7575
command: custom
7676
custom: msbuild
77-
arguments: 'build.proj /t:Build /p:Configuration=Release;TurnOnTestCoverage=true'
77+
arguments: 'build.proj /t:Build /p:Configuration=Release;TurnOnTestCoverage=true;ModifiedModuleBuild=true'
7878

7979
- task: EsrpCodeSigning@4
8080
inputs:

‎build.proj

Lines changed: 25 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,12 @@
2020
/p:Scope
2121
'Subfolder under src': An individual cmdlet module
2222
By default, it builds everything
23-
/p:TargetModule
24-
Just focus on one module and its dependency such as Az.Account. Module name doesn't need to lead with Az.
2523
/p:SkipHelp=True
2624
Skips help generation, mainly for local builds to save time.
25+
/p:ModifiedModuleBuild=True
26+
Only build changed module according to the changelog in root folder or according to another property "TargetModule"
27+
/p:TargetModule
28+
Just focus on modules and its dependency such as Az.Account. Module name doesn't need to lead with Az. Split by ":"
2729
-->
2830
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
2931

@@ -36,7 +38,9 @@
3638
<TestFramework Condition="'$(TestFramework)' == ''">netcoreapp2.2</TestFramework>
3739
<IsGenerateBased Condition="'$(IsGenerateBased)' != 'true'">false</IsGenerateBased>
3840
<IsSecurityCheck Condition="'$(IsSecurityCheck)' != 'true'">false</IsSecurityCheck>
41+
<ModifiedModuleBuild Condition="'$(ModifiedModuleBuild)' != 'true'">false</ModifiedModuleBuild>
3942

43+
4044
<!-- Flags -->
4145
<CodeSign Condition ="'$(CodeSign)' == ''">false</CodeSign>
4246
<SkipHelp Condition ="'$(SkipHelp)' != 'true'">false</SkipHelp>
@@ -61,7 +65,7 @@
6165
<!-- Testing related -->
6266
<TestsToRun Condition="$(TestsToRun) == ''" >All</TestsToRun>
6367
<CoreTests Condition="'$(TestsToRun)' != 'All'">$(RepoRoot)src/Compute/Compute.Test/Compute.Test.csproj;$(RepoRoot)src/Network/Network.Test/Network.Test.csproj;$(RepoRoot)src/Resources/Resources.Test/Resources.Test.csproj;$(RepoRoot)src/Sql/Sql.Test/Sql.Test.csproj;$(RepoRoot)src/Websites/Websites.Test/Websites.Test.csproj;</CoreTests>
64-
<Net472TestExclude Condition="'$(TestFramework)' == 'net472'">$(RepoRoot)src/**/Automation.Test.csproj;$(RepoRoot)src/**/Storage.Test.csproj;</Net472TestExclude>
68+
<CoreTests Condition="'$(CoreTests)' == ''">null</CoreTests>
6569

6670
<!-- CI build related -->
6771
<CIToolsPath>$(OnPremiseBuildTasks)</CIToolsPath>
@@ -116,23 +120,23 @@
116120
<Exec Command="dotnet publish $(RepoTools)StaticAnalysis/StaticAnalysis.Netcore.csproj -c $(Configuration)" />
117121
</Target>
118122

119-
<Target Name="FilterBuild" Condition="$(PullRequestNumber) != '' OR $(TargetModule) != ''" DependsOnTargets="BuildTools">
123+
<Target Name="FilterBuild" Condition="$(PullRequestNumber) != ''" DependsOnTargets="BuildTools">
120124
<Message Importance="high" Text="Filtering projects and modules..." />
121125

122126
<Message Text="$(IsGenerateBased)" />
123127
<!-- Build the Microsoft.Azure.Build.Tasks project -->
124128
<Exec Command="dotnet publish $(RepoTools)BuildPackagesTask/Microsoft.Azure.Build.Tasks/Microsoft.Azure.Build.Tasks.csproj -c $(Configuration)" />
125129

126130
<!-- Get all of the files changed in the given pull request -->
127-
<FilesChangedTask RepositoryOwner="Azure" RepositoryName="azure-powershell" PullRequestNumber="$(PullRequestNumber)" TargetModule="$(TargetModule)" OutputFile="$(RepoArtifacts)/FilesChanged.txt">
131+
<FilesChangedTask RepositoryOwner="Azure" RepositoryName="azure-powershell" PullRequestNumber="$(PullRequestNumber)" OutputFile="$(RepoArtifacts)/FilesChanged.txt">
128132
<Output TaskParameter="FilesChanged" ItemName="FilesChanged" />
129133
</FilesChangedTask>
130134

131135
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;$(RepoTools)PrepareAutorestModule.ps1&quot;" Condition="'$(IsGenerateBased)' == 'true'"/>
132136
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;$(RepoTools)/CreateFilterMappings.ps1&quot;" />
133137
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;$(RepoTools)/PrepareForSecurityCheck.ps1&quot;" Condition="'$(IsSecurityCheck)' == 'true'"/>
134138

135-
<CIFilterTask FilesChanged="@(FilesChanged)" TargetModule="$(TargetModule)" Mode="$(Configuration)" CsprojMapFilePath="./CsprojMappings.json">
139+
<CIFilterTask FilesChanged="@(FilesChanged)" Mode="$(Configuration)" CsprojMapFilePath="./CsprojMappings.json">
136140
<Output TaskParameter="BuildCsprojList" ItemName="BuildCsprojList" />
137141
<Output TaskParameter="TestCsprojList" ItemName="TestCsprojList" />
138142
<Output TaskParameter="SubTasks" PropertyName="SubTasks" />
@@ -149,33 +153,24 @@
149153
<Copy SourceFiles="$(RepoTools)after.Azure.PowerShell.sln.targets" DestinationFolder="$(RepoArtifacts)" />
150154

151155
<!-- Build and create package content -->
152-
<Exec Command="dotnet --version" />
153-
<Exec Command="dotnet new sln -n Azure.PowerShell -o $(RepoArtifacts) --force" />
154156
<CallTarget Targets="BuildNormalModules" />
155157
<CallTarget Targets="AzToolsPredictor" Condition="$(SubTasks.Contains('Predictor')) OR $(SubTasks.Contains('all'))" />
156158
<CallTarget Targets="AzToolsInstaller" Condition="$(SubTasks.Contains('Installer')) OR $(SubTasks.Contains('all'))" />
157159
</Target>
158160

159161
<Target Name="BuildNormalModules">
160-
<ItemGroup Condition="$(PullRequestNumber) == '' AND $(TargetModule) == ''">
161-
<CsprojFiles Include="$(RepoRoot)src/**/*.csproj" Exclude="$(RepoRoot)src/**/*.Test.csproj;$(RepoRoot)src/**/Authenticators.csproj" />
162-
<CsprojFiles Include="$(RepoRoot)src/**/*.Test.csproj" Exclude="$(Net472TestExclude)" Condition="'$(Configuration)' != 'Release' and '$(TestsToRun)' == 'All'" />
163-
<CsprojFiles Include="$(RepoRoot)src/**/*.Test.csproj" Exclude="$(CoreTests)$(Net472TestExclude)" Condition="'$(Configuration)' != 'Release' and '$(TestsToRun)' == 'NonCore'" />
164-
<CsprojFiles Include="$(CoreTests)" Exclude="$(Net472TestExclude)" Condition="'$(Configuration)' != 'Release' and '$(TestsToRun)' == 'Core'" />
165-
<CsprojFiles Include="$(RepoRoot)src/**/Authenticators.csproj" Condition="'$([MSBuild]::IsOsPlatform(&quot;Windows&quot;))' == 'true' and '$(TestFramework)' != 'net472'" />
166-
</ItemGroup>
167-
<ItemGroup Condition="$(PullRequestNumber) != ''">
168-
<!-- Always build and test common code -->
169-
<CsprojFiles Include="@(BuildCsprojList)" />
170-
<CsprojFiles Include="@(TestCsprojList)" />
171-
</ItemGroup>
172-
<ItemGroup Condition="$(TargetModule) != ''">
173-
<!-- Add test projects only if Configuration is not Release -->
174-
<CsprojFiles Include="@(BuildCsprojList)" />
175-
<CsprojFiles Include="@(TestCsprojList)" Condition="'$(Configuration)' != 'Release'" />
176-
</ItemGroup>
177-
<!-- https://github.com/dotnet/cli/issues/6295#issuecomment-346973582 -->
178-
<Exec Command="dotnet sln $(RepoArtifacts)Azure.PowerShell.sln add &quot;%(CsprojFiles.FullPath)&quot;" Condition="'@(CsprojFiles)' != ''" />
162+
<Exec Condition="$(PullRequestNumber) == '' AND $(TargetModule) == '' AND $(ModifiedModuleBuild) == 'false'"
163+
Command="$(PowerShellCoreCommandPrefix) &quot;.\tools\BuildScripts\BuildModules.ps1 -RepoRoot $(RepoRoot) -Configuration $(Configuration) -TestsToRun $(TestsToRun) -CoreTests $(CoreTests) -RepoArtifacts $(RepoArtifacts) &quot;"
164+
/>
165+
<Exec Condition="$(PullRequestNumber) != ''"
166+
Command="$(PowerShellCoreCommandPrefix) &quot;.\tools\BuildScripts\BuildModules.ps1 -RepoRoot $(RepoRoot) -Configuration $(Configuration) -TestsToRun $(TestsToRun) -CoreTests $(CoreTests) -RepoArtifacts $(RepoArtifacts) -BuildCsprojList '@(BuildCsprojList)' -TestCsprojList '@(TestCsprojList)'&quot;"
167+
/>
168+
<Exec Condition="$(ModifiedModuleBuild) != 'false'"
169+
Command="$(PowerShellCoreCommandPrefix) &quot;.\tools\BuildScripts\BuildModules.ps1 -RepoRoot $(RepoRoot) -Configuration $(Configuration) -TestsToRun $(TestsToRun) -CoreTests $(CoreTests) -RepoArtifacts $(RepoArtifacts) -ModifiedModuleBuild $(ModifiedModuleBuild) &quot;"
170+
/>
171+
<Exec Condition="$(TargetModule) != ''"
172+
Command="$(PowerShellCoreCommandPrefix) &quot;.\tools\BuildScripts\BuildModules.ps1 -RepoRoot $(RepoRoot) -Configuration $(Configuration) -TestsToRun $(TestsToRun) -CoreTests $(CoreTests) -RepoArtifacts $(RepoArtifacts) -TargetModule $(TargetModule)&quot;"
173+
/>
179174
<PropertyGroup>
180175
<BuildAction Condition="'$(Configuration)' != 'Release'">build</BuildAction>
181176
<BuildAction Condition="'$(Configuration)' == 'Release'">publish</BuildAction>
@@ -251,11 +246,6 @@
251246
<Error Text="StaticAnalysis has failed. Please follow the instructions on this doc: https://github.com/Azure/azure-powershell/blob/master/documentation/Debugging-StaticAnalysis-Errors.md" />
252247
</Target>
253248

254-
<Target Name="ChangeLogCheck">
255-
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(RepoTools)/CheckChangeLog.ps1 -FilesChanged '@(FilesChanged)'&quot;" Condition=" '$(Scope)' == 'All' or '$(Scope)' == 'Latest' " />
256-
<OnError ExecuteTargets="ChangeLogErrorMessage" />
257-
</Target>
258-
259249
<Target Name="AzToolsInstaller">
260250
<Exec Command='dotnet msbuild $(RepoTools)/Az.Tools.Installer/build.proj /t:"clean;build;test"' />
261251
</Target>
@@ -264,22 +254,18 @@
264254
<Exec Command='dotnet msbuild $(RepoTools)/Az.Tools.Predictor/build.proj /t:"clean;build;test"' />
265255
</Target>
266256

267-
<Target Name="ChangeLogErrorMessage">
268-
<Error Text="Modified files were found with no update to their change log. Please add a snippet to the affected modules' change log." />
269-
</Target>
270-
271257
<Target Name="Publish" Condition="'$(Configuration)' == 'Release'">
272258
<Message Importance="high" Text="Publishing Cmdlets using $(Scope) scope" />
273-
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(RepoTools)/NewOutputTypeIndex.ps1 -OutputFile $(RepoArtifacts)/outputtypes.json -BuildConfig $(Configuration)&quot;" Condition="'$(TargetModule)' == ''"/>
274-
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(RepoTools)/NewHelpIndex.ps1 -OutputFile $(RepoArtifacts)/index.json -BuildConfig $(Configuration)&quot;" Condition="'$(TargetModule)' == ''"/>
259+
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(RepoTools)/NewOutputTypeIndex.ps1 -OutputFile $(RepoArtifacts)/outputtypes.json -BuildConfig $(Configuration)&quot;"/>
260+
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(RepoTools)/NewHelpIndex.ps1 -OutputFile $(RepoArtifacts)/index.json -BuildConfig $(Configuration)&quot;"/>
275261

276262
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(RepoTools)/CleanupBuild.ps1 -BuildConfig $(Configuration) -GenerateDocumentationFile $(GenerateDocumentationFile) &quot;" />
277263

278264
<Error Condition="'$(NuGetKey)' == ''" Text="You must provide the NuGetKey parameter to the build: /p:NuGetKey=YOUR_PUBLISHING_KEY" />
279265
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(RepoTools)/PublishModules.ps1 -IsNetCore:$$(NetCore) -BuildConfig $(Configuration) -Scope $(Scope) -ApiKey $(NuGetKey) -RepositoryLocation \&quot;$(NuGetPublishingSource)\&quot;&quot; -NugetExe $(NuGetCommand)" />
280266
</Target>
281267

282-
<Target Name="BuildInstaller" AfterTargets="Publish" Condition="('$(Scope)' == 'All' or '$(Scope)' == 'Latest' or '$(Scope)' == 'Netcore') and '$(TargetModule)' == ''">
268+
<Target Name="BuildInstaller" AfterTargets="Publish" Condition="('$(Scope)' == 'All' or '$(Scope)' == 'Latest' or '$(Scope)' == 'Netcore')">
283269
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. Register-PSRepository -Name MSIcreationrepository -SourceLocation $(RepoArtifacts) -InstallationPolicy Trusted &quot;" />
284270
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(RepoRoot)/setup/generate.ps1 -repository MSIcreationrepository &quot;" />
285271
<Exec Command="$(PowerShellCoreCommandPrefix) &quot;. Unregister-PSRepository -Name MSIcreationrepository &quot;" />
@@ -301,20 +287,6 @@
301287
<OnError ExecuteTargets="TestFailureErrorMessage" />
302288
</Target>
303289

304-
<Target Name="TestNet472" Condition="'$(TestFramework)' == 'net472'">
305-
<PropertyGroup>
306-
<PowerShellCommandPrefix>powershell -NonInteractive -NoLogo -NoProfile -Command</PowerShellCommandPrefix>
307-
</PropertyGroup>
308-
<Message Importance="high" Text="Running check in tests..." />
309-
<MakeDir Directories="$(TestOutputDirectory)" ContinueOnError="false" />
310-
<Exec Command="dotnet build $(RepoArtifacts)Azure.PowerShell.sln -c $(Configuration)" />
311-
<Exec Command="dotnet new console -n Net472Tests" />
312-
<Exec Command="dotnet add Net472Tests package xunit.runner.console --version 2.4.0" />
313-
<Exec Command="dotnet restore --packages $(RepoArtifacts)/xUnit -f --no-cache Net472Tests" />
314-
<Exec Command="$(PowerShellCommandPrefix) &quot;$(RepoTools)/TestNet472Modules.ps1 -TestExecPath '$(RepoArtifacts)/xUnit/xunit.runner.console/2.4.0/tools/net472/xunit.console.exe'&quot;" />
315-
<OnError ExecuteTargets="TestFailureErrorMessage" />
316-
</Target>
317-
318290
<Target Name="TestFailureErrorMessage">
319291
<Error Text="Test failures occurred, check the files in artifacts/TestResults" />
320292
</Target>

‎tools/AzPreview/ChangeLog.md

Whitespace-only changes.

‎tools/BuildPackagesTask/Microsoft.Azure.Build.Tasks/CIFilterTask.cs

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ public class CIFilterTask : Task
3737
[Required]
3838
public string[] FilesChanged { get; set; }
3939

40-
/// <summary>
41-
/// Gets or set the TargetModule, e.g. Storage
42-
/// </summary>
43-
public string TargetModule { get; set; }
44-
4540
/// <summary>
4641
/// Gets or set the Mode, e.g. Release
4742
/// </summary>
@@ -183,27 +178,6 @@ private List<string> GetTestCsprojList(string moduleName, Dictionary<string, str
183178
return csprojList;
184179
}
185180

186-
private bool ProcessTargetModule(Dictionary<string, string[]> csprojMap)
187-
{
188-
Dictionary<string, HashSet<string>> influencedModuleInfo = new Dictionary<string, HashSet<string>>
189-
{
190-
[BUILD_PHASE] = new HashSet<string>(GetBuildCsprojList(TargetModule, csprojMap).ToList()),
191-
[TEST_PHASE] = new HashSet<string>(GetTestCsprojList(TargetModule, csprojMap).ToList())
192-
};
193-
194-
Console.WriteLine("----------------- InfluencedModuleInfo TargetModule -----------------");
195-
foreach (string phaseName in influencedModuleInfo.Keys)
196-
{
197-
Console.WriteLine(string.Format("{0}: [{1}]", phaseName, string.Join(", ", influencedModuleInfo[phaseName].ToList())));
198-
}
199-
Console.WriteLine("--------------------------------------------------------");
200-
201-
BuildCsprojList = influencedModuleInfo[BUILD_PHASE].ToArray();
202-
TestCsprojList = influencedModuleInfo[TEST_PHASE].ToArray();
203-
204-
return true;
205-
}
206-
207181
private string ProcessSinglePattern(string pattern)
208182
{
209183
return pattern.Replace(".", "\\.").Replace("*", ".*").Replace("{ModuleName}", "(?<ModuleName>[^/]+)");
@@ -446,11 +420,7 @@ public override bool Execute()
446420
var csprojMap = ReadMapFile(CsprojMapFilePath, "CsprojMapFilePath");
447421

448422
Console.WriteLine(string.Format("FilesChanged: {0}", FilesChanged.Length));
449-
if (!string.IsNullOrWhiteSpace(TargetModule))
450-
{
451-
return ProcessTargetModule(csprojMap);
452-
}
453-
else if (FilesChanged != null)
423+
if (FilesChanged != null)
454424
{
455425
if (FilesChanged.Length <= 0)
456426
{

‎tools/BuildPackagesTask/Microsoft.Azure.Build.Tasks/FilesChangedTask.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,6 @@ public class FilesChangedTask : Task
4444
/// </summary>
4545
public string PullRequestNumber { get; set; }
4646

47-
/// <summary>
48-
/// Gets or set the TargetModule, e.g. Storage
49-
/// </summary>
50-
public string TargetModule { get; set; }
51-
5247
/// <summary>
5348
/// Gets or set the OutputFile, store FilesChanged.txt in 'artifacts' folder
5449
/// </summary>

0 commit comments

Comments
 (0)