[Compute] Adding MaxSurge to Set-AzVmssRollingUpgrade And Changes to Get-AzVmImage (#20811)

* Changing Set-AzVmssRollingUpgrade

* Adding help

* Update changelog.md

* resolve conflict

* Supporting latest Version in Get-AzVMimage

* removing extra line

* fixing help

* Updating to nullable

Author: haagha

src/Compute/Compute/ChangeLog.md

@@ -22,6 +22,8 @@
 ## Upcoming Release
 * Added breaking change message for `New-AzVmss`.
 * Added `-PerformancePlus` parameter to `New-AzDiskConfig`
+* Added 'MaxSurge' to Set-AzVmssRollingUpgradePolicyCommand
+* Added support for 'latest' in 'Get-AzvmImage' '-Version' parameter
 * Added `CompletionPercent` property to PSDisk object.
 
 ## Version 5.4.0

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/SetAzureRmVmssRollingUpgradePolicyCommand.cs

@@ -74,6 +74,13 @@ public partial class SetAzureRmVmssRollingUpgradePolicyCommand : Microsoft.Azure
             ValueFromPipelineByPropertyName = true)]
         public bool PrioritizeUnhealthyInstance { get; set; }
 
+        [Parameter(
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "If enabled, VMSS will create new virtual machines to upgrade the scale set, rather than updating the existing virtual machines. Existing virtual machines will be deleted once the new virtual machines are created for each batch.")]
+        public bool? MaxSurge { get; set; }
+
+
         protected override void ProcessRecord()
         {
             if (ShouldProcess("VirtualMachineScaleSet", "Set"))
@@ -174,6 +181,21 @@ private void Run()
                 this.VirtualMachineScaleSet.UpgradePolicy.RollingUpgradePolicy.PrioritizeUnhealthyInstances = this.PrioritizeUnhealthyInstance;
             }
 
+            if (this.IsParameterBound(c => c.MaxSurge))
+            {
+                // UpgradePolicy
+                if (this.VirtualMachineScaleSet.UpgradePolicy == null)
+                {
+                    this.VirtualMachineScaleSet.UpgradePolicy = new UpgradePolicy();
+                }
+                // Rolling Upgrade 
+                if (this.VirtualMachineScaleSet.UpgradePolicy.RollingUpgradePolicy == null)
+                {
+                    this.VirtualMachineScaleSet.UpgradePolicy.RollingUpgradePolicy = new RollingUpgradePolicy();
+                }
+                this.VirtualMachineScaleSet.UpgradePolicy.RollingUpgradePolicy.MaxSurge = this.MaxSurge;
+            }
+
             WriteObject(this.VirtualMachineScaleSet);
         }
     }

src/Compute/Compute/Images/GetAzureVMImageCommand.cs

@@ -79,7 +79,8 @@ public class GetAzureVMImageCommand : VirtualMachineImageBaseCmdlet
 
         [Parameter(ParameterSetName = GetVMImageDetailParamSetName,
             Mandatory = true,
-            ValueFromPipelineByPropertyName = true)]
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage ="Specifies the version of the image. Use 'latest' to get the latest image")]
         [ValidateNotNullOrEmpty]
         [SupportsWildcards]
         public string Version { get; set; }
@@ -190,6 +191,32 @@ public override void ExecuteCmdlet()
 
                     WriteObject(SubResourceWildcardFilter(Version, images), true);
                 }
+                else if (this.ParameterSetName.Equals(GetVMImageDetailParamSetName) && this.Version.ToLower() == "latest")
+                {
+                    var result = this.VirtualMachineImageClient.ListWithHttpMessagesAsync(
+                        this.Location.Canonicalize(),
+                        this.PublisherName,
+                        this.Offer,
+                        this.Skus,
+                        top: 1,
+                        orderby: "name desc"
+                        ).GetAwaiter().GetResult();
+
+                    var images = from r in result.Body
+                                 select new PSVirtualMachineImage
+                                 {
+                                     RequestId = result.RequestId,
+                                     StatusCode = result.Response.StatusCode,
+                                     Id = r.Id,
+                                     Location = r.Location,
+                                     Version = r.Name,
+                                     PublisherName = this.PublisherName,
+                                     Offer = this.Offer,
+                                     Skus = this.Skus
+                                 };
+
+                    WriteObject(images);
+                }
                 else
                 {
                     var response = this.VirtualMachineImageClient.GetWithHttpMessagesAsync(

src/Compute/Compute/help/Set-AzVmssRollingUpgradePolicy.md

@@ -16,7 +16,7 @@ Sets the VMSS rolling upgrade policy properties.
 Set-AzVmssRollingUpgradePolicy [-VirtualMachineScaleSet] <PSVirtualMachineScaleSet>
  [[-MaxBatchInstancePercent] <Int32>] [[-MaxUnhealthyInstancePercent] <Int32>]
  [[-MaxUnhealthyUpgradedInstancePercent] <Int32>] [-PauseTimeBetweenBatches <String>]
- [-EnableCrossZoneUpgrade <Boolean>] [-PrioritizeUnhealthyInstance <Boolean>]
+ [-EnableCrossZoneUpgrade <Boolean>] [-PrioritizeUnhealthyInstance <Boolean>] [-MaxSurge <Boolean>]
  [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
@@ -81,6 +81,21 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -MaxSurge
+If enabled, VMSS will create new virtual machines to upgrade the scale set, rather than updating the existing virtual machines. Existing virtual machines will be deleted once the new virtual machines are created for each batch.
+
+```yaml
+Type: System.Boolean
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: True (ByPropertyName)
+Accept wildcard characters: False
+```
+
 ### -MaxUnhealthyInstancePercent
 The maximum percentage of the total virtual machine instances in the scale set that can be simultaneously unhealthy, either as a result of being upgraded, or by being found in an unhealthy state by the virtual machine health checks before the rolling upgrade aborts.
 This constraint will be checked prior to starting any batch.