[Az.ServiceFabric] Set-AzServiceFabricManagedClusterApplication: Fix bug where -RecreateApplication flag did not overwrite existing upgrade policy (#28310)

Co-authored-by: NoriZC <[email protected]>

Author: iliu816

src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersApplicationTests.cs

@@ -48,6 +48,13 @@ public void TestManagedApp()
             TestRunner.RunTestScript("Test-ManagedApp");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestManagedAppUpgradeRecreate()
+        {
+            TestRunner.RunTestScript("Test-ManagedAppUpgrade-Recreate");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestManagedService()

src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersApplicationTests.ps1

@@ -207,6 +207,74 @@ function Test-ManagedApp
 	Assert-ThrowsContains { Get-AzServiceFabricManagedClusterApplication -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name $appName } "NotFound"
 }
 
+function Test-ManagedAppUpgrade-Recreate
+{
+	# Cluster Setup
+	$resourceGroupName = "sfmcps-rg-" + (getAssetname)
+	$clusterName = "sfmcps-" + (getAssetname)
+	$location = "southcentralus"
+	$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
+	$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
+	$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-ManagedApp-RecreateApplication"}
+
+	Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"
+
+	$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Location $location `
+		-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
+	Assert-AreEqual  "Succeeded" $cluster.ProvisioningState
+	Assert-AreEqual  "WaitingForNodes" $cluster.ClusterState
+
+	New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary -AsJob
+
+	#wait for nodetypes
+	WaitForAllJob
+
+	# Wait for clusterState
+	WaitForManagedClusterReadyStateIfRecord $clusterName $resourceGroupName
+
+	$appName = getAssetName "testApp"
+	$serviceName = getAssetName "testStatelessService"
+
+	$apps = Get-AzServiceFabricManagedClusterApplication -ResourceGroupName $resourceGroupName -ClusterName $clusterName
+	Assert-Null $apps
+
+	$app = New-AzServiceFabricManagedClusterApplication -ResourceGroupName $resourceGroupName -ClusterName $clusterName -ApplicationTypeName $appTypeName -ApplicationTypeVersion $v1 -Name $appName -PackageUrl $packageV1 -Verbose
+	Assert-AreEqual "Succeeded" $app.ProvisioningState
+
+	$appFromGet = Get-AzServiceFabricManagedClusterApplication -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name $appName
+	Assert-NotNull $appFromGet
+	Assert-AreEqual $app.Id $appFromGet.Id
+
+	$service = New-AzServiceFabricManagedClusterService -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Stateless -InstanceCount -1 -ApplicationName $appName -Name $serviceName -Type $statelessServiceTypeName -PartitionSchemeSingleton -Verbose
+	Assert-AreEqual "Succeeded" $service.ProvisioningState
+
+	$serviceFromGet = Get-AzServiceFabricManagedClusterService -ResourceGroupName $resourceGroupName -ClusterName $clusterName -ApplicationName $appName -Name $serviceName
+	Assert-NotNull $serviceFromGet
+	Assert-AreEqual $service.Id $serviceFromGet.Id
+
+	$appTypeVersion = New-AzServiceFabricManagedClusterApplicationTypeVersion -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name $appTypeName -Version $v2 -PackageUrl $packageV2 -Verbose
+	Assert-AreEqual "Succeeded" $appTypeVersion.ProvisioningState
+
+	# Test upgrade with recreate policy
+	$app = $appFromGet | Set-AzServiceFabricManagedClusterApplication -ApplicationTypeVersion $v2 -RecreateApplication -Verbose
+	Assert-AreEqual "Succeeded" $app.ProvisioningState
+	Assert-EndsWith $v2 $app.Version
+	Assert-True { $app.UpgradePolicy.RecreateApplication }
+
+	# Test noop
+	$appNoop = $app | Set-AzServiceFabricManagedClusterApplication
+	Assert-AreEqual "Succeeded" $appNoop.ProvisioningState
+	Assert-AreEqualObjectProperties $app $appNoop
+
+	$removeResponse = Remove-AzServiceFabricManagedClusterApplication -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name $appName -Force -PassThru -Verbose
+	Assert-True { $removeResponse }
+
+	$removeResponse = Remove-AzServiceFabricManagedClusterApplicationType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name $appTypeName -Force -PassThru -Verbose
+	Assert-True { $removeResponse }
+
+	Assert-ThrowsContains { Get-AzServiceFabricManagedClusterApplication -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name $appName } "NotFound"
+}
+
 function Test-ManagedService
 {
 	# Cluster Setup