Revert [Compute] Support new ElasticSan parameters in DiskRP cmdlets (#23094) (#23274)

blueww · web-flow · commit 836320b252ca · 2023-11-07T20:59:30.000+08:00
diff --git a/src/Compute/Compute/ChangeLog.md b/src/Compute/Compute/ChangeLog.md
@@ -25,8 +25,6 @@
 * [Breaking change] Removed unversioned and outdated linux image aliases of `CentOS`, `RHEL`, `UbuntuLTS` and `Debian`.
 * [Breaking Change] Added defaulting logic for VM and VMSS creation to set SecurityType to TrustedLaunch and SecureBootEnabled and VTpmEnalbed to true when those are not set by the user.
 * [Breaking Change] Added defaulting logic for Disk creation to default to TrustedLaunch when able. Allows the user to turn this off by setting the SecurityType to Standard.
-* Added new parameters `-ElasticSanResourceId` and `-OptimizedForFrequentAttach` to `New-AzDiskConfig` cmdlet.
-* Added new parameter `-ElasticSanResourceId` to `New-AzSnapshotConfig` cmdlet.
 * Fixed `New-AzVmss` and `New-Azvm` to use `SharedGalleryImageId` parameter.
 
 ## Version 6.3.0
diff --git a/src/Compute/Compute/Generated/Disk/Config/NewAzureRmDiskConfigCommand.cs b/src/Compute/Compute/Generated/Disk/Config/NewAzureRmDiskConfigCommand.cs
@@ -248,18 +248,6 @@ public partial class NewAzureRmDiskConfigCommand : Microsoft.Azure.Commands.Reso
             HelpMessage = "Set this flag to true to get a boost on the performance target of the disk deployed, see here on the respective performance target. This flag can only be set on disk creation time and cannot be disabled after enabled.")]
         public bool? PerformancePlus { get; set; }
 
-        [Parameter(
-            Mandatory = false,
-            ValueFromPipelineByPropertyName = true,
-            HelpMessage = "Required if createOption is CopyFromSanSnapshot. this is the ARM id of the source elastic san volume snapshot.")]
-        public string ElasticSanResourceId { get; set; }
-
-        [Parameter(
-            Mandatory = false,
-            ValueFromPipelineByPropertyName = true,
-            HelpMessage = "Setting this property to true improves reliability and performance of data disks that are frequently (more than 5 times a day) by detached from one virtual machine and attached to another. This property should not be set for disks that are not detached and attached frequently as it causes the disks to not align with the fault domain of the virtual machine.")]
-        public bool? OptimizedForFrequentAttach { get; set; }
-
         protected override void ProcessRecord()
         {
             if (ShouldProcess("Disk", "New"))
@@ -351,15 +339,6 @@ private void Run()
                 vCreationData.SourceResourceId = this.SourceResourceId;
             }
 
-            if (this.IsParameterBound(c => c.ElasticSanResourceId))
-            {
-                if (vCreationData == null)
-                {
-                    vCreationData = new CreationData();
-                }
-                vCreationData.ElasticSanResourceId = this.ElasticSanResourceId;
-            }
-
             if (this.IsParameterBound(c => c.UploadSizeInBytes))
             {
                 if (vCreationData == null)
@@ -503,8 +482,7 @@ private void Run()
                 SupportsHibernation = this.IsParameterBound(c => c.SupportsHibernation) ? SupportsHibernation : null,
                 SupportedCapabilities = vSupportedCapabilities,
                 PublicNetworkAccess = this.IsParameterBound(c => c.PublicNetworkAccess) ? PublicNetworkAccess : null,
-                DataAccessAuthMode = this.IsParameterBound(c => c.DataAccessAuthMode) ? DataAccessAuthMode : null,
-                OptimizedForFrequentAttach = this.IsParameterBound(c => c.OptimizedForFrequentAttach) ? OptimizedForFrequentAttach : null
+                DataAccessAuthMode = this.IsParameterBound(c => c.DataAccessAuthMode) ? DataAccessAuthMode : null
             };
 
             WriteObject(vDisk);
diff --git a/src/Compute/Compute/Generated/Models/PSDisk.cs b/src/Compute/Compute/Generated/Models/PSDisk.cs
@@ -78,6 +78,5 @@ public string ResourceGroupName
         public SupportedCapabilities SupportedCapabilities { get; set; }
         public string DataAccessAuthMode { get; set; }
         public double? CompletionPercent { get; set; }
-        public bool? OptimizedForFrequentAttach { get; set; }
     }
 }
diff --git a/src/Compute/Compute/Generated/Snapshot/Config/NewAzureRmSnapshotConfigCommand.cs b/src/Compute/Compute/Generated/Snapshot/Config/NewAzureRmSnapshotConfigCommand.cs
@@ -186,12 +186,6 @@ public partial class NewAzureRmSnapshotConfigCommand : Microsoft.Azure.Commands.
         [PSArgumentCompleter("X64", "Arm64")]
         public string Architecture { get; set; }
 
-        [Parameter(
-            Mandatory = false,
-            ValueFromPipelineByPropertyName = true,
-            HelpMessage = "Required if createOption is CopyFromSanSnapshot. this is the ARM id of the source elastic san volume snapshot.")]
-        public string ElasticSanResourceId { get; set; }
-
         protected override void ProcessRecord()
         {
             if (ShouldProcess("Snapshot", "New"))
@@ -274,15 +268,6 @@ private void Run()
                 vCreationData.SourceResourceId = this.SourceResourceId;
             }
 
-            if (this.IsParameterBound(c => c.ElasticSanResourceId))
-            {
-                if (vCreationData == null)
-                {
-                    vCreationData = new CreationData();
-                }
-                vCreationData.ElasticSanResourceId = this.ElasticSanResourceId;
-            }
-
             if (this.IsParameterBound(c => c.EncryptionSettingsEnabled))
             {
                 if (vEncryptionSettingsCollection == null)
diff --git a/src/Compute/Compute/help/New-AzDiskConfig.md b/src/Compute/Compute/help/New-AzDiskConfig.md
@@ -25,8 +25,8 @@ New-AzDiskConfig [[-SkuName] <String>] [-Tier <String>] [-LogicalSectorSize <Int
  [-DiskEncryptionSetId <String>] [-EncryptionType <String>] [-DiskAccessId <String>]
  [-NetworkAccessPolicy <String>] [-BurstingEnabled <Boolean>] [-PublicNetworkAccess <String>]
  [-AcceleratedNetwork <Boolean>] [-DataAccessAuthMode <String>] [-Architecture <String>]
- [-PerformancePlus <Boolean>] [-ElasticSanResourceId <String>] [-OptimizedForFrequentAttach <Boolean>]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-PerformancePlus <Boolean>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
+ [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -313,21 +313,6 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
-### -ElasticSanResourceId
-Required if createOption is CopyFromSanSnapshot. this is the ARM id of the source elastic san volume snapshot.
-
-```yaml
-Type: System.String
-Parameter Sets: (All)
-Aliases:
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: True (ByPropertyName)
-Accept wildcard characters: False
-```
-
 ### -EncryptionSettingsEnabled
 Enable encryption settings.
 
@@ -484,21 +469,6 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
-### -OptimizedForFrequentAttach
-Setting this property to true improves reliability and performance of data disks that are frequently (more than 5 times a day) by detached from one virtual machine and attached to another. This property should not be set for disks that are not detached and attached frequently as it causes the disks to not align with the fault domain of the virtual machine.
-
-```yaml
-Type: System.Nullable`1[System.Boolean]
-Parameter Sets: (All)
-Aliases:
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: True (ByPropertyName)
-Accept wildcard characters: False
-```
-
 ### -OsType
 Specifies the OS type.
 
diff --git a/src/Compute/Compute/help/New-AzSnapshotConfig.md b/src/Compute/Compute/help/New-AzSnapshotConfig.md
@@ -21,8 +21,8 @@ New-AzSnapshotConfig [[-SkuName] <String>] [[-OsType] <OperatingSystemTypes>] [[
  [-DiskEncryptionKey <KeyVaultAndSecretReference>] [-KeyEncryptionKey <KeyVaultAndKeyReference>]
  [-DiskEncryptionSetId <String>] [-EncryptionType <String>] [-DiskAccessId <String>]
  [-NetworkAccessPolicy <String>] [-PublicNetworkAccess <String>] [-AcceleratedNetwork <Boolean>]
- [-DataAccessAuthMode <String>] [-Architecture <String>] [-ElasticSanResourceId <String>]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-DataAccessAuthMode <String>] [-Architecture <String>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
+ [-Confirm] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -209,21 +209,6 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
-### -ElasticSanResourceId
-Required if createOption is CopyFromSanSnapshot. this is the ARM id of the source elastic san volume snapshot.
-
-```yaml
-Type: System.String
-Parameter Sets: (All)
-Aliases:
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: True (ByPropertyName)
-Accept wildcard characters: False
-```
-
 ### -EncryptionSettingsEnabled
 Enable encryption settings.
 

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,5 @@ public string ResourceGroupName`
`78`	`78`	`public SupportedCapabilities SupportedCapabilities { get; set; }`
`79`	`79`	`public string DataAccessAuthMode { get; set; }`
`80`	`80`	`public double? CompletionPercent { get; set; }`
`81`		`- public bool? OptimizedForFrequentAttach { get; set; }`
`82`	`81`	`}`
`83`	`82`	`}`