Lnx/sign (#22278)

* Fixed issue in live test and added more error details (#22249)

* Fixed the error when source was PSGallery

* Added detailed error info to debug a concurrent issue

* prevent eol issue (#22259)

* suppress static analysis issue (#22260)

* Uncommented assertions in gateway test with admin state (#22236)

* Update code-oob.yml for Azure Pipelines

* Lnx/sign (#22276)

* Fixed issue in live test and added more error details (#22249)

* Fixed the error when source was PSGallery

* Added detailed error info to debug a concurrent issue

* prevent eol issue (#22259)

* suppress static analysis issue (#22260)

* Uncommented assertions in gateway test with admin state (#22236)

* Update code-oob.yml for Azure Pipelines

---------

Co-authored-by: Vincent Dai <[email protected]>
Co-authored-by: NoriZC <[email protected]>

* Update code-oob.yml for Azure Pipelines

* Update code-oob.yml for Azure Pipelines

---------

Co-authored-by: Vincent Dai <[email protected]>
Co-authored-by: NoriZC <[email protected]>

Author: 3 people

.azure-pipelines/code-oob.yml

@@ -7,27 +7,38 @@ parameters:
   displayName: Service to OOB release
   type: string
   default: Databricks
+- name: BumpUpVersion
+  displayName: Need BumpUpVersion
+  type: boolean
+  default: true
+- name: PreviewSuffix
+  displayName: Add "-Preview" Suffix after version number
+  type: boolean
+  default: false
 - name: Preview
-  displayName: Is preview version
+  displayName: Is preview version(Including < 1.0.0)
   type: boolean
   default: false
 stages:
 - stage: OOBRelease
   displayName: OOBRelease
   jobs:
-  - job: OOBRelease
+  - job: BumpUpVersion
     timeoutInMinutes: 180
     pool: pool-windows-2019
+    condition: and(succeeded(), eq('${{ parameters.BumpUpVersion }}', 'true'))
     steps:
     - task: DotNetCoreCLI@2
       displayName: Build
+      condition: and(succeeded(), eq('${{ parameters.BumpUpVersion }}', 'true'))
       inputs:
         command: custom
         custom: msbuild
         arguments: 'build.proj "/t:Clean;Build" /p:Configuration=Release'
     - pwsh: |
           .\tools\RunVersionController.ps1 -ModuleName "Az.${{ parameters.ServiceName }}”
       displayName: 'Bump up version'
+      condition: and(succeeded(), eq('${{ parameters.BumpUpVersion }}', 'true'))
     - task: AzurePowerShell@5
       inputs:
           azureSubscription: '$(AzureSubscription)'
@@ -52,6 +63,7 @@ stages:
               $Description = "Migrate ${{ parameters.ServiceName }} from oob to ${{parameters.TargetBranch}}"
               ./tools/Github/CreatePR.ps1 -Title $Title -HeadBranch $HeadBranch -BaseBranch $BaseBranch -BotAccessToken $Token -Description $Description -Draft $true
       displayName: Create PR to main branch
+      condition: and(succeeded(), eq('${{ parameters.BumpUpVersion }}', 'true'))
     - task: PowerShell@2
       displayName: get changelog info
       inputs:
@@ -65,6 +77,9 @@ stages:
               $versionNumber = $matches.Groups[1].Value
               $versionChanges = $matches.Groups[2].Value.Trim()
           }
+          if ($PreviewSuffix) {
+            $versionNumber += $PreviewSuffix
+          }
           $jsonData = @{
             ModuleName = "${{ parameters.ServiceName }}"
             VersionNumber = "$versionNumber"
@@ -98,6 +113,11 @@ stages:
           "@
           $readmePath = "OOB/README.md"
           $content | Out-File -FilePath $readmePath
+          if (${{ parameters.BumpUpVersion }} -eq $true) {
+              echo "##vso[task.setvariable variable=BumpUpBranch]codeoob/${{ parameters.ServiceName }}"
+          } else {
+              echo "##vso[task.setvariable variable=BumpUpBranch]none"
+          }
 
     - task: PowerShell@2
       displayName: publish oob tools
@@ -116,7 +136,7 @@ stages:
   jobs:
   - template: ./code-sign.yml
     parameters:
-      OOBBranch: codeoob/${{ parameters.ServiceName }}
+      OOBBranch: $(BumpUpBranch)
   - job: PulishForTest
     dependsOn: Release
     steps:

src/Network/Network.Test/ScenarioTests/VirtualNetworkGatewayTests.ps1

@@ -1612,7 +1612,7 @@ function Test-VirtualNetworkExpressRouteGatewayCRUDwithAdminState
       Assert-AreEqual $expected.ResourceGroupName $actual.ResourceGroupName	
       Assert-AreEqual $expected.Name $actual.Name	
       Assert-AreEqual "ExpressRoute" $expected.GatewayType
-	  # Assert-AreEqual "Enabled" $expected.AdminState
+	  Assert-AreEqual "Enabled" $expected.AdminState
 
       # Create a second gateway
       $vnet = Get-AzVirtualNetwork -Name $vnetName -ResourceGroupName $rgname
@@ -1625,15 +1625,15 @@ function Test-VirtualNetworkExpressRouteGatewayCRUDwithAdminState
       Assert-AreEqual $expected.ResourceGroupName $actual.ResourceGroupName	
       Assert-AreEqual $expected.Name $actual.Name	
       Assert-AreEqual "ExpressRoute" $expected.GatewayType
-	  # Assert-AreEqual "Enabled" $expected.AdminState
+	  Assert-AreEqual "Enabled" $expected.AdminState
 
       # Update second gw to disabled Adminstate
       $vng2 = Get-AzVirtualNetworkGateway -ResourceGroupName $rgname -name $rname2
       $vng2.Adminstate = "Disabled";
       Set-AzVirtualNetworkGateway -VirtualNetworkGateway $vng2
 
       $vng2 = Get-AzVirtualNetworkGateway -ResourceGroupName $rgname -name $rname2	
-	  # Assert-AreEqual "Disabled" $vng2.AdminState
+	  Assert-AreEqual "Disabled" $vng2.AdminState
 
       # Delete both virtualNetworkGateways
       $delete = Remove-AzVirtualNetworkGateway -ResourceGroupName $rgname -name $rname -PassThru -Force

tools/StaticAnalysis/Exceptions/Az.App/ExampleIssues.csv

@@ -0,0 +1,2 @@
+"Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
+"Az.App","New-AzContainerAppManagedEnvCert","1","1","Invalid_Cmdlet","5000","1","New-SelfSignedCertificate is not a valid command name.","New-SelfSignedCertificate -DnsName 'www.fabrikam.com', 'www.contoso.com' -CertStoreLocation 'cert:\LocalMachine\My'","Check the spell of New-SelfSignedCertificate."

tools/StaticAnalysis/Exceptions/Az.Cdn/SignatureIssues.csv

@@ -64,3 +64,13 @@
 "Az.Cdn","Test-AzCdnNameAvailability","Test-AzCdnNameAvailability","1","8700","Parameter set 'CheckExpanded1', '__AllParameterSets' of cmdlet 'Test-AzCdnNameAvailability' have the same mandatory parameters, and both of them are not default parameter set which may cause confusion.","Merge these parameter sets into one parameter set."
 "Az.Cdn","Update-AzCdnEndpoint","Update-AzCdnEndpoint","1","8410","Parameter ContentTypesToCompress of cmdlet Update-AzCdnEndpoint does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
 "Az.Cdn","Update-AzFrontDoorCdnRoute","Update-AzFrontDoorCdnRoute","1","8410","Parameter CompressionSettingContentTypesToCompress of cmdlet Update-AzFrontDoorCdnRoute does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
+"Az.Cdn","New-AzCdnDeliveryRuleCacheExpirationActionObject","New-AzCdnDeliveryRuleCacheExpirationActionObject","1","8100","New-AzCdnDeliveryRuleCacheExpirationActionObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzCdnDeliveryRuleCacheKeyQueryStringActionObject","New-AzCdnDeliveryRuleCacheKeyQueryStringActionObject","1","8100","New-AzCdnDeliveryRuleCacheKeyQueryStringActionObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzCdnLoadParametersObject","New-AzCdnLoadParametersObject","1","8100","New-AzCdnLoadParametersObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzCdnOriginGroupOverrideActionObject","New-AzCdnOriginGroupOverrideActionObject","1","8100","New-AzCdnOriginGroupOverrideActionObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzCdnPurgeParametersObject","New-AzCdnPurgeParametersObject","1","8100","New-AzCdnPurgeParametersObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzFrontDoorCdnMigrationParametersObject","New-AzFrontDoorCdnMigrationParametersObject","1","8100","New-AzFrontDoorCdnMigrationParametersObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzFrontDoorCdnMigrationWebApplicationFirewallMappingObject","New-AzFrontDoorCdnMigrationWebApplicationFirewallMappingObject","1","8100","New-AzFrontDoorCdnMigrationWebApplicationFirewallMappingObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzFrontDoorCdnProfileChangeSkuWafMappingObject","New-AzFrontDoorCdnProfileChangeSkuWafMappingObject","1","8100","New-AzFrontDoorCdnProfileChangeSkuWafMappingObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzFrontDoorCdnProfileUpgradeParametersObject","New-AzFrontDoorCdnProfileUpgradeParametersObject","1","8100","New-AzFrontDoorCdnProfileUpgradeParametersObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
+"Az.Cdn","New-AzFrontDoorCdnPurgeParametersObject","New-AzFrontDoorCdnPurgeParametersObject","1","8100","New-AzFrontDoorCdnPurgeParametersObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"

tools/StaticAnalysis/Exceptions/Az.Databricks/SignatureIssues.csv

@@ -13,3 +13,4 @@
 "Az.Databricks","Update-AzDatabricksVNetPeering","Update-AzDatabricksVNetPeering","1","8410","Parameter ProxyUseDefaultCredentials of cmdlet Update-AzDatabricksVNetPeering does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
 "Az.Databricks","Update-AzDatabricksWorkspace","Update-AzDatabricksWorkspace","1","8100","Update-AzDatabricksWorkspace Does not support ShouldProcess but the cmdlet verb Update indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
 "Az.Databricks","Update-AzDatabricksWorkspace","Update-AzDatabricksWorkspace","1","8410","Parameter ProxyUseDefaultCredentials of cmdlet Update-AzDatabricksWorkspace does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
+"Az.Databricks","New-AzDatabricksWorkspaceProviderAuthorizationObject","New-AzDatabricksWorkspaceProviderAuthorizationObject","1","8100","New-AzDatabricksWorkspaceProviderAuthorizationObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"

tools/StaticAnalysis/GeneratedSdkAnalyzer/SDKGeneratedCodeVerify.ps1

@@ -74,6 +74,8 @@ try{
                     Remediation = "Make sure that the ReadMe file of Sdk is loaded."
             }
         }
+        # Prevent EOL changes detected
+        git config --global core.autocrlf false
         # See if the code is completely the same as we generated
         $changes = git status ".\Generated" --porcelain
         if ($changes -ne $null){

tools/TestFx/Live/InstallLiveTestAzModules.ps1

@@ -11,7 +11,7 @@ switch ($Source) {
     "PSGallery" {
         Set-PSRepository -Name $Source -InstallationPolicy Trusted
     }
-    { "DailyBuild" -or "Sign" } {
+    { $_ -in "DailyBuild", "Sign" } {
         Register-PSRepository -Name $Source -SourceLocation $AzPackagesLocation -PackageManagementProvider NuGet -InstallationPolicy Trusted
     }
 }

tools/TestFx/Live/InvokeLiveTestScenarios.ps1

@@ -112,7 +112,9 @@ while ($queuedJobs.Count -gt 0) {
                 }
 
                 if ("" -ne $liveJobStreams.Error) {
-                    $liveJobStreams.Error
+                    $liveJobStreams.Error | ForEach-Object {
+                        $_ | Format-List * -Force
+                    }
                 }
             }
         }