Merge pull request #6552 from cormacpayne/enable-static-analysis

Fail build on Static Analysis failure

Author: Maddie Clayton

build.proj

@@ -587,9 +587,8 @@
 
     <Message Importance="high" Text="Running dependency analysis..." />
 
-    <Exec Command="$(MSBuildProjectDirectory)\src\Package\StaticAnalysis.exe $(MSBuildProjectDirectory)\src\Package\$(Configuration) $(MSBuildProjectDirectory)\src\Package true $(SkipHelp)"
-          Condition="'$(Scope)' != 'Stack'"
-          ContinueOnError="True"/>
+    <Exec Command="$(MSBuildProjectDirectory)\src\Package\StaticAnalysis.exe $(MSBuildProjectDirectory)\src\Package\$(Configuration) $(MSBuildProjectDirectory)\src\Package true $(SkipHelp) @(ModulesChanged)"
+          Condition="'$(Scope)' != 'Stack'"/>
 
     <Exec Command="$(PackageDirectory)\StaticAnalysis.exe $(StackPackageFolder)\$(Configuration) $(StackPackageFolder)"
           Condition="'$(Scope)' == 'All' or '$(Scope)' == 'Stack'"

tools/StaticAnalysis/Exceptions/AzureRM.RecoveryServices.SiteRecovery/BreakingChangeIssues.csv

@@ -1 +1,18 @@
 "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrAlertSetting","Get-AzureRmRecoveryServicesAsrAlertSetting","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrAlertSetting' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRAlertSetting]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrAlertSetting' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRAlertSetting]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrEvents","Get-AzureRmRecoveryServicesAsrEvent","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrEvent' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASREvent]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrEvent' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASREvent]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrFabric","Get-AzureRmRecoveryServicesAsrFabric","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrFabric' no longer has output type 'System.Collections.Generic.List`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRFabric]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrFabric' return type 'System.Collections.Generic.List`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRFabric]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrNetworkMapping","Get-AzureRmRecoveryServicesAsrNetworkMapping","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrNetworkMapping' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRNetworkMapping]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrNetworkMapping' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRNetworkMapping]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrNetwork","Get-AzureRmRecoveryServicesAsrNetwork","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrNetwork' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRNetwork]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrNetwork' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRNetwork]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrProtectableItem","Get-AzureRmRecoveryServicesAsrProtectableItem","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrProtectableItem' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRProtectableItem]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrProtectableItem' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRProtectableItem]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrProtectionContainerMapping","Get-AzureRmRecoveryServicesAsrProtectionContainerMapping","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrProtectionContainerMapping' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRProtectionContainerMapping]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrProtectionContainerMapping' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRProtectionContainerMapping]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrProtectionContainer","Get-AzureRmRecoveryServicesAsrProtectionContainer","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrProtectionContainer' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRProtectionContainer]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrProtectionContainer' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRProtectionContainer]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrRecoveryPoint","Get-AzureRmRecoveryServicesAsrRecoveryPoint","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrRecoveryPoint' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRRecoveryPoint]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrRecoveryPoint' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRRecoveryPoint]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrReplicationProtectedItem","Get-AzureRmRecoveryServicesAsrReplicationProtectedItem","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrReplicationProtectedItem' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRReplicationProtectedItem]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrReplicationProtectedItem' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRReplicationProtectedItem]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrRecoveryPlan","Get-AzureRmRecoveryServicesAsrRecoveryPlan","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrRecoveryPlan' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRRecoveryPlan]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrRecoveryPlan' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRRecoveryPlan]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrServicesProvider","Get-AzureRmRecoveryServicesAsrServicesProvider","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrServicesProvider' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRRecoveryServicesProvider]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrServicesProvider' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRRecoveryServicesProvider]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrJob","Get-AzureRmRecoveryServicesAsrJob","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrJob' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRJob]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrJob' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRJob]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrPolicy","Get-AzureRmRecoveryServicesAsrPolicy","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrPolicy' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRPolicy]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrPolicy' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRPolicy]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrStorageClassification","Get-AzureRmRecoveryServicesAsrStorageClassification","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrStorageClassification' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRStorageClassification]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrStorageClassification' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRStorageClassification]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrStorageClassificationMapping","Get-AzureRmRecoveryServicesAsrStorageClassificationMapping","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrStorageClassificationMapping' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRStorageClassificationMapping]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrStorageClassificationMapping' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRStorageClassificationMapping]'."
+"Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.dll","Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.GetAzureRmRecoveryServicesAsrvCenter","Get-AzureRmRecoveryServicesAsrvCenter","0","1020","The cmdlet 'Get-AzureRmRecoveryServicesAsrvCenter' no longer has output type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRvCenter]'.","Make cmdlet 'Get-AzureRmRecoveryServicesAsrvCenter' return type 'System.Collections.Generic.IEnumerable`1[Microsoft.Azure.Commands.RecoveryServices.SiteRecovery.ASRvCenter]'."