Skip to content

Commit 8fdb2b5

Browse files
authored
[Storage] Remove track1 SDK from Queue cmdlets (#24414)
* remove track1 sdk from queue cmdlets * ignore case for sas protocol parameter * Add breaking change exceptions. Remove more Track1 Queue references * Update format and tests; fix context issue * temp * update display group rule and value * Update format
1 parent 964dcc3 commit 8fdb2b5

28 files changed

+45
-1004
lines changed

src/Storage/Storage.Management.Test/ScenarioTests/StorageDataPlaneTests.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -470,8 +470,8 @@ function Test-Queue
470470
Assert-AreEqual $queue.Count 1
471471
Assert-AreEqual $queue[0].Name $queueName
472472

473-
$queueMessage = New-Object -TypeName "Microsoft.Azure.Storage.Queue.CloudQueueMessage" -ArgumentList "This is message 1"
474-
$queue.CloudQueue.AddMessageAsync($QueueMessage)
473+
$queueMessage = "This is message 1"
474+
$queue.QueueClient.SendMessage($queueMessage)
475475

476476
$queueCount1 = (Get-AzStorageQueue -Context $storageContext).Count
477477
Remove-AzStorageQueue -Name $queueName -Force -Context $storageContext

src/Storage/Storage.Management/ChangeLog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121
* Upgraded Azure.Core to 1.37.0.
2222
* Fixed upload file with OAuth authentication issue [#24289]
2323
- `Set-AzStorageFileContent`
24+
* Removed references to "Microsoft.Azure.Storage.Queue" in Queue cmdlets
25+
- Get-AzStorageQueue
26+
- New-AzStorageQueue
27+
- New-AzStorageQueueSASToken
2428

2529
## Version 6.1.2
2630
* Fixed parser logic when downloading blob from managed disk account with Sas Uri and bearer token on Linux and MacOS

src/Storage/Storage.Management/Models/PSObjectReplicationPolicy.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
using Microsoft.WindowsAzure.Commands.Common.Attributes;
1717
using System;
1818
using System.Collections.Generic;
19+
using System.Globalization;
1920

2021
namespace Microsoft.Azure.Commands.Management.Storage.Models
2122
{
@@ -178,7 +179,7 @@ public PSObjectReplicationPolicyFilter(ObjectReplicationPolicyFilter filter)
178179
{
179180
filter.MinCreationTime = filter.MinCreationTime + "Z";
180181
}
181-
this.MinCreationTime = Convert.ToDateTime(filter.MinCreationTime);
182+
this.MinCreationTime = Convert.ToDateTime(filter.MinCreationTime, CultureInfo.GetCultureInfo("en-US"));
182183
}
183184
}
184185
}

src/Storage/Storage.Management/help/Get-AzStorageQueueStoredAccessPolicy.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
111111
112112
## OUTPUTS
113113
114-
### Microsoft.Azure.Storage.Queue.SharedAccessQueuePolicy
114+
### System.Management.Automation.PSObject
115115
116116
## NOTES
117117

src/Storage/Storage.Management/help/New-AzStorageQueueSASToken.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ Generates a shared access signature token for an Azure storage queue.
1515

1616
### SasPolicy
1717
```
18-
New-AzStorageQueueSASToken [-Name] <String> -Policy <String> [-Protocol <SharedAccessProtocol>]
18+
New-AzStorageQueueSASToken [-Name] <String> -Policy <String> [-Protocol <String>]
1919
[-IPAddressOrRange <String>] [-StartTime <DateTime>] [-ExpiryTime <DateTime>] [-FullUri]
2020
[-Context <IStorageContext>] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
2121
```
2222

2323
### SasPermission
2424
```
25-
New-AzStorageQueueSASToken [-Name] <String> [-Permission <String>] [-Protocol <SharedAccessProtocol>]
25+
New-AzStorageQueueSASToken [-Name] <String> [-Permission <String>] [-Protocol <String>]
2626
[-IPAddressOrRange <String>] [-StartTime <DateTime>] [-ExpiryTime <DateTime>] [-FullUri]
2727
[-Context <IStorageContext>] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
2828
```
@@ -172,7 +172,7 @@ The acceptable values for this parameter are:
172172
The default value is HttpsOrHttp.
173173

174174
```yaml
175-
Type: System.Nullable`1[Microsoft.Azure.Storage.SharedAccessProtocol]
175+
Type: System.String
176176
Parameter Sets: (All)
177177
Aliases:
178178
Accepted values: HttpsOnly, HttpsOrHttp

src/Storage/Storage.Management/help/Set-AzStorageQueueStoredAccessPolicy.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ Accept wildcard characters: False
111111
112112
### -Permission
113113
Specifies permissions in the stored access policy to access the storage queue.
114-
It is important to note that this is a string, like `rwd` (for Read, Write and Delete).
114+
It is important to note that this is a string, like `raup` (for Read, Add, Update, and ProcessMessages).
115115

116116
```yaml
117117
Type: System.String

src/Storage/Storage.Test/Common/AccessPolicyHelperTest.cs

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,11 @@
1313
// ----------------------------------------------------------------------------------
1414

1515
using System;
16-
using System.Collections.Generic;
1716
using Microsoft.VisualStudio.TestTools.UnitTesting;
1817
using Microsoft.WindowsAzure.Commands.Storage.Common;
1918
using Microsoft.Azure.Storage.Blob;
2019
using Microsoft.Azure.Cosmos.Table;
2120
using Microsoft.Azure.Storage.File;
22-
using Microsoft.Azure.Storage.Queue;
2321

2422
namespace Microsoft.WindowsAzure.Commands.Storage.Test.Common
2523
{
@@ -48,14 +46,6 @@ public void ValidateSetupAccessPolicyPermissionTest()
4846
AccessPolicyHelper.SetupAccessPolicyPermission(tableAccessPolicy, "ar");
4947
Assert.AreEqual(tableAccessPolicy.Permissions, SharedAccessTablePermissions.Add | SharedAccessTablePermissions.Query);
5048

51-
SharedAccessQueuePolicy queueAccessPolicy = new SharedAccessQueuePolicy();
52-
AccessPolicyHelper.SetupAccessPolicyPermission(queueAccessPolicy, null);
53-
Assert.AreEqual(queueAccessPolicy.Permissions, SharedAccessQueuePermissions.None);
54-
AccessPolicyHelper.SetupAccessPolicyPermission(queueAccessPolicy, "");
55-
Assert.AreEqual(queueAccessPolicy.Permissions, SharedAccessQueuePermissions.None);
56-
AccessPolicyHelper.SetupAccessPolicyPermission(queueAccessPolicy, "p");
57-
Assert.AreEqual(queueAccessPolicy.Permissions, SharedAccessQueuePermissions.ProcessMessages);
58-
5949
SharedAccessFilePolicy fileAccessPolicy = new SharedAccessFilePolicy();
6050
AccessPolicyHelper.SetupAccessPolicyPermission(fileAccessPolicy, null);
6151
Assert.AreEqual(fileAccessPolicy.Permissions, SharedAccessFilePermissions.None);
@@ -97,17 +87,11 @@ public void SetupAccessPolicyTest()
9787
Assert.AreEqual(tableAccessPolicy.SharedAccessExpiryTime.Value.UtcDateTime.ToString(), end.Value.ToUniversalTime().ToString());
9888
Assert.AreEqual(tableAccessPolicy.Permissions, SharedAccessTablePermissions.Delete);
9989

100-
SharedAccessQueuePolicy queueAccessPolicy = new SharedAccessQueuePolicy();
101-
AccessPolicyHelper.SetupAccessPolicy(queueAccessPolicy, start, null, "", noExpiryTime: true);
102-
Assert.AreEqual(queueAccessPolicy.SharedAccessStartTime.Value.UtcDateTime.ToString(), start.Value.ToUniversalTime().ToString());
103-
Assert.AreEqual(queueAccessPolicy.SharedAccessExpiryTime, null);
104-
Assert.AreEqual(queueAccessPolicy.Permissions, SharedAccessQueuePermissions.None);
105-
10690
SharedAccessFilePolicy fileAccessPolicy = new SharedAccessFilePolicy();
10791
AccessPolicyHelper.SetupAccessPolicy(fileAccessPolicy, null, null, "dl", true, true);
10892
Assert.AreEqual(fileAccessPolicy.SharedAccessStartTime, null);
10993
Assert.AreEqual(fileAccessPolicy.SharedAccessExpiryTime, null);
110-
Assert.AreEqual(fileAccessPolicy.Permissions, SharedAccessFilePermissions.List| SharedAccessFilePermissions.Delete);
94+
Assert.AreEqual(fileAccessPolicy.Permissions, SharedAccessFilePermissions.List | SharedAccessFilePermissions.Delete);
11195
}
11296
}
11397
}

src/Storage/Storage.Test/Queue/GetAzureStorageQueueTest.cs

Lines changed: 0 additions & 58 deletions
This file was deleted.

src/Storage/Storage.Test/Queue/NewAzureStorageQueueTest.cs

Lines changed: 0 additions & 55 deletions
This file was deleted.

src/Storage/Storage.Test/Queue/RemoveAzureStorageQueueTest.cs

Lines changed: 0 additions & 109 deletions
This file was deleted.

0 commit comments

Comments
 (0)