Get-AzVmss bug fix (#24781)

* fix bug (breaking change)

* breaking change suppression

---------

Co-authored-by: Theodore Chang <[email protected]>

Author: grizzlytheodore

src/Compute/Compute/ChangeLog.md

@@ -25,6 +25,7 @@
 * Added cmdlet `Invoke-AzSpotPlacementRecommender`.
 * Fixed `Update-AzCapacityReservationGroup` to remove Subscriptions from SharingProfile.
 * Added new optional parameter `SecureVMGuestStateSAS` to cmdlet `Grant-AzDiskAccess`.
+* [Breaking Change] Added ValidateNotNullOrEmpty for `-ResourceGroupName` and `-VMScaleSetName` parameters to `Get-AzVmss` cmdlet. [#20095]
 
 ## Version 7.2.0
 * Added parameters `-scriptUriManagedIdentity`, `-outputBlobManagedIdentity`, `-errorBlobMangedIdentity`, and `-TreatFailureAsDeploymentFailure` to cmdlets `Set-AzVmRunCommand` and `Set-AzVmssRunCommand`. 

src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetGetMethod.cs

@@ -34,7 +34,6 @@
 
 namespace Microsoft.Azure.Commands.Compute.Automation
 {
-    [GenericBreakingChangeWithVersionAttribute("Starting in May 2024 the \"Get-AzVmss\" cmdlet will no longer allow an empty value for resource group name and virtual machine scale set name.", "12.0.0", "8.0.0")]
     [Cmdlet(VerbsCommon.Get, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "Vmss", DefaultParameterSetName = "DefaultParameter")]
     [OutputType(typeof(PSVirtualMachineScaleSet))]
     public partial class GetAzureRmVmss : ComputeAutomationBaseCmdlet
@@ -168,6 +167,7 @@ public override void ExecuteCmdlet()
             ValueFromPipelineByPropertyName = true)]
         [ResourceGroupCompleter]
         [SupportsWildcards]
+        [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
         [Parameter(
@@ -184,6 +184,7 @@ public override void ExecuteCmdlet()
             ValueFromPipelineByPropertyName = true)]
         [ResourceNameCompleter("Microsoft.Compute/virtualMachineScaleSets", "ResourceGroupName")]
         [SupportsWildcards]
+        [ValidateNotNullOrEmpty]
         [Alias("Name")]
         public string VMScaleSetName { get; set; }
 

tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv

@@ -0,0 +1,3 @@
+"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
+"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRmVmss","Get-AzVmss","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'ResourceGroupName' for cmdlet 'Get-AzVmss'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'ResourceGroupName'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRmVmss","Get-AzVmss","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'VMScaleSetName' for cmdlet 'Get-AzVmss'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'VMScaleSetName'."