[Az.RecoveryServices.Backup] Added support for setting snapshot consistency type in backup policy (#24169)

* added crash consistent snapshot

* Resolved issue with soft delete always on
Updated help docs
Updated ChangeLog
Updated resx
Added test cases

* re-recorded failed tests
Added error message while failing to fetch CRR acccess token

* removed progressAction

Author: hiaga

src/RecoveryServices/RecoveryServices.Backup.Helpers/Conversions/ConversionHelpers.cs

@@ -190,6 +190,8 @@ public static PolicyBase GetPolicyModelForAzureIaaSVM(ServiceClientModel.Protect
                 ((ServiceClientModel.AzureIaaSVMProtectionPolicy)serviceClientResponse.Properties).InstantRpDetails.AzureBackupRgNamePrefix;
             iaasPolicyModel.AzureBackupRGNameSuffix = 
                 ((ServiceClientModel.AzureIaaSVMProtectionPolicy)serviceClientResponse.Properties).InstantRpDetails.AzureBackupRgNameSuffix;
+            iaasPolicyModel.SnapshotConsistencyType =
+                ((ServiceClientModel.AzureIaaSVMProtectionPolicy)serviceClientResponse.Properties).SnapshotConsistencyType;
 
             // fetch the smart tiering details          
             if (((ServiceClientModel.AzureIaaSVMProtectionPolicy)serviceClientResponse.Properties).TieringPolicy != null &&
@@ -249,7 +251,7 @@ public static PolicyBase GetPolicyModelForAzureFileShare(ServiceClientModel.Prot
             ServiceClientModel.AzureFileShareProtectionPolicy azureFileSharePolicy =
                     (ServiceClientModel.AzureFileShareProtectionPolicy)serviceClientResponse.Properties;
 
-            if (azureFileSharePolicy.RetentionPolicy.GetType() !=
+            if (azureFileSharePolicy.RetentionPolicy != null && azureFileSharePolicy.RetentionPolicy.GetType() !=
                 typeof(ServiceClientModel.LongTermRetentionPolicy))
             {
                 Logger.Instance.WriteDebug("Unknown RetentionPolicy object received: " +
@@ -271,9 +273,14 @@ public static PolicyBase GetPolicyModelForAzureFileShare(ServiceClientModel.Prot
             AzureFileSharePolicy fileSharePolicyModel = policyModel as AzureFileSharePolicy;
             fileSharePolicyModel.WorkloadType = WorkloadType.AzureFiles;
             fileSharePolicyModel.BackupManagementType = BackupManagementType.AzureStorage;
-            fileSharePolicyModel.RetentionPolicy =
+
+            if(azureFileSharePolicy.RetentionPolicy != null)
+            {
+                fileSharePolicyModel.RetentionPolicy =
                 PolicyHelpers.GetPSLongTermRetentionPolicy((ServiceClientModel.LongTermRetentionPolicy)((ServiceClientModel.AzureFileShareProtectionPolicy)serviceClientResponse.Properties).RetentionPolicy,
                   ((ServiceClientModel.AzureFileShareProtectionPolicy)serviceClientResponse.Properties).TimeZone, backupManagementType);
+            }
+            
             fileSharePolicyModel.SchedulePolicy =
                 PolicyHelpers.GetPSSimpleSchedulePolicy((ServiceClientModel.SimpleSchedulePolicy)
                  ((ServiceClientModel.AzureFileShareProtectionPolicy)serviceClientResponse.Properties).SchedulePolicy,

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BMSPrepareDataMoveOperationResultOperations.cs

@@ -45,7 +45,8 @@ internal BmsPrepareDataMoveOperationResultOperations (RecoveryServicesBackupClie
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='operationId'>
         /// 

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BMSPrepareDataMoveOperationResultOperationsExtensions.cs

@@ -22,7 +22,8 @@ public static partial class BmsPrepareDataMoveOperationResultOperationsExtension
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='operationId'>
         /// 
@@ -42,7 +43,8 @@ public static VaultStorageConfigOperationResultResponse Get(this IBmsPrepareData
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='operationId'>
         /// 

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BackupEnginesOperations.cs

@@ -39,7 +39,8 @@ internal BackupEnginesOperations (RecoveryServicesBackupClient client)
         public RecoveryServicesBackupClient Client { get; private set; }
 
         /// <summary>
-        /// Backup management servers registered to Recovery Services Vault. Returns a pageable list of servers.
+        /// Backup management servers registered to Recovery Services Vault. Returns a
+        /// pageable list of servers.
         /// </summary>
         /// <param name='odataQuery'>
         /// 
@@ -48,7 +49,8 @@ internal BackupEnginesOperations (RecoveryServicesBackupClient client)
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='skipToken'>
         /// skipToken Filter.
@@ -283,7 +285,8 @@ internal BackupEnginesOperations (RecoveryServicesBackupClient client)
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='backupEngineName'>
         /// Name of the backup management server.
@@ -519,7 +522,8 @@ internal BackupEnginesOperations (RecoveryServicesBackupClient client)
 
         }
         /// <summary>
-        /// Backup management servers registered to Recovery Services Vault. Returns a pageable list of servers.
+        /// Backup management servers registered to Recovery Services Vault. Returns a
+        /// pageable list of servers.
         /// </summary>
         /// <param name='nextPageLink'>
         /// The NextLink from the previous successful call to List operation.

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BackupEnginesOperationsExtensions.cs

@@ -13,7 +13,8 @@ namespace Microsoft.Azure.Management.RecoveryServices.Backup
     public static partial class BackupEnginesOperationsExtensions
     {
         /// <summary>
-        /// Backup management servers registered to Recovery Services Vault. Returns a pageable list of servers.
+        /// Backup management servers registered to Recovery Services Vault. Returns a
+        /// pageable list of servers.
         /// </summary>
         /// <param name='operations'>
         /// The operations group for this extension method.
@@ -25,7 +26,8 @@ public static partial class BackupEnginesOperationsExtensions
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='skipToken'>
         /// skipToken Filter.
@@ -36,7 +38,8 @@ public static partial class BackupEnginesOperationsExtensions
         }
 
         /// <summary>
-        /// Backup management servers registered to Recovery Services Vault. Returns a pageable list of servers.
+        /// Backup management servers registered to Recovery Services Vault. Returns a
+        /// pageable list of servers.
         /// </summary>
         /// <param name='operations'>
         /// The operations group for this extension method.
@@ -48,7 +51,8 @@ public static partial class BackupEnginesOperationsExtensions
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='skipToken'>
         /// skipToken Filter.
@@ -76,7 +80,8 @@ public static partial class BackupEnginesOperationsExtensions
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='backupEngineName'>
         /// Name of the backup management server.
@@ -102,7 +107,8 @@ public static partial class BackupEnginesOperationsExtensions
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='backupEngineName'>
         /// Name of the backup management server.
@@ -121,7 +127,8 @@ public static partial class BackupEnginesOperationsExtensions
             }
         }
         /// <summary>
-        /// Backup management servers registered to Recovery Services Vault. Returns a pageable list of servers.
+        /// Backup management servers registered to Recovery Services Vault. Returns a
+        /// pageable list of servers.
         /// </summary>
         /// <param name='operations'>
         /// The operations group for this extension method.
@@ -135,7 +142,8 @@ public static Microsoft.Rest.Azure.IPage<BackupEngineBaseResource> ListNext(this
         }
 
         /// <summary>
-        /// Backup management servers registered to Recovery Services Vault. Returns a pageable list of servers.
+        /// Backup management servers registered to Recovery Services Vault. Returns a
+        /// pageable list of servers.
         /// </summary>
         /// <param name='operations'>
         /// The operations group for this extension method.

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BackupJobsOperations.cs

@@ -48,7 +48,8 @@ internal BackupJobsOperations (RecoveryServicesBackupClient client)
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='skipToken'>
         /// skipToken Filter.

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BackupJobsOperationsExtensions.cs

@@ -25,7 +25,8 @@ public static partial class BackupJobsOperationsExtensions
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='skipToken'>
         /// skipToken Filter.
@@ -48,7 +49,8 @@ public static partial class BackupJobsOperationsExtensions
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='skipToken'>
         /// skipToken Filter.

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BackupOperationResultsOperations.cs

@@ -39,16 +39,20 @@ internal BackupOperationResultsOperations (RecoveryServicesBackupClient client)
         public RecoveryServicesBackupClient Client { get; private set; }
 
         /// <summary>
-        /// Provides the status of the delete operations such as deleting backed up item. Once the operation has started, the
-        /// status code in the response would be Accepted. It will continue to be in this state till it reaches completion. On
-        /// successful completion, the status code will be OK. This method expects OperationID as an argument. OperationID is
+        /// Provides the status of the delete operations such as deleting backed up
+        /// item. Once the operation has started, the
+        /// status code in the response would be Accepted. It will continue to be in
+        /// this state till it reaches completion. On
+        /// successful completion, the status code will be OK. This method expects
+        /// OperationID as an argument. OperationID is
         /// part of the Location header of the operation response.
         /// </summary>
         /// <param name='vaultName'>
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='operationId'>
         /// OperationID which represents the operation.

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BackupOperationResultsOperationsExtensions.cs

@@ -13,9 +13,12 @@ namespace Microsoft.Azure.Management.RecoveryServices.Backup
     public static partial class BackupOperationResultsOperationsExtensions
     {
         /// <summary>
-        /// Provides the status of the delete operations such as deleting backed up item. Once the operation has started, the
-        /// status code in the response would be Accepted. It will continue to be in this state till it reaches completion. On
-        /// successful completion, the status code will be OK. This method expects OperationID as an argument. OperationID is
+        /// Provides the status of the delete operations such as deleting backed up
+        /// item. Once the operation has started, the
+        /// status code in the response would be Accepted. It will continue to be in
+        /// this state till it reaches completion. On
+        /// successful completion, the status code will be OK. This method expects
+        /// OperationID as an argument. OperationID is
         /// part of the Location header of the operation response.
         /// </summary>
         /// <param name='operations'>
@@ -25,7 +28,8 @@ public static partial class BackupOperationResultsOperationsExtensions
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='operationId'>
         /// OperationID which represents the operation.
@@ -36,9 +40,12 @@ public static void Get(this IBackupOperationResultsOperations operations, string
         }
 
         /// <summary>
-        /// Provides the status of the delete operations such as deleting backed up item. Once the operation has started, the
-        /// status code in the response would be Accepted. It will continue to be in this state till it reaches completion. On
-        /// successful completion, the status code will be OK. This method expects OperationID as an argument. OperationID is
+        /// Provides the status of the delete operations such as deleting backed up
+        /// item. Once the operation has started, the
+        /// status code in the response would be Accepted. It will continue to be in
+        /// this state till it reaches completion. On
+        /// successful completion, the status code will be OK. This method expects
+        /// OperationID as an argument. OperationID is
         /// part of the Location header of the operation response.
         /// </summary>
         /// <param name='operations'>
@@ -48,7 +55,8 @@ public static void Get(this IBackupOperationResultsOperations operations, string
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='operationId'>
         /// OperationID which represents the operation.

src/RecoveryServices/RecoveryServices.Backup.Management.Sdk/Generated/BackupOperationStatusesOperations.cs

@@ -39,15 +39,19 @@ internal BackupOperationStatusesOperations (RecoveryServicesBackupClient client)
         public RecoveryServicesBackupClient Client { get; private set; }
 
         /// <summary>
-        /// Fetches the status of an operation such as triggering a backup, restore. The status can be in progress, completed
-        /// or failed. You can refer to the OperationStatus enum for all the possible states of an operation. Some operations
-        /// create jobs. This method returns the list of jobs when the operation is complete.
+        /// Fetches the status of an operation such as triggering a backup, restore.
+        /// The status can be in progress, completed
+        /// or failed. You can refer to the OperationStatus enum for all the possible
+        /// states of an operation. Some operations
+        /// create jobs. This method returns the list of jobs when the operation is
+        /// complete.
         /// </summary>
         /// <param name='vaultName'>
         /// The name of the recovery services vault.
         /// </param>
         /// <param name='resourceGroupName'>
-        /// The name of the resource group where the recovery services vault is present.
+        /// The name of the resource group where the recovery services vault is
+        /// present.
         /// </param>
         /// <param name='operationId'>
         /// OperationID which represents the operation.