Review comments

- Administrators to Administrator
- Included AnalysisServices module in AzureRM

Author: athipp

src/ResourceManager/AnalysisServices/Commands.AnalysisServices.Test/ScenarioTests/AsTests.ps1

@@ -16,7 +16,7 @@ function Test-AnalysisServicesServer
 		$serverName = Get-AnalysisServicesServerName
 		New-AzureRmResourceGroup -Name $resourceGroupName -Location $location
 
-		$serverCreated = New-AzureRmAnalysisServicesServer -ResourceGroupName $resourceGroupName -Name $serverName -Location $location -Sku 'S1' -Administrators '[email protected],[email protected]'
+		$serverCreated = New-AzureRmAnalysisServicesServer -ResourceGroupName $resourceGroupName -Name $serverName -Location $location -Sku 'S1' -Administrator '[email protected],[email protected]'
 
 		Assert-AreEqual $serverName $serverCreated.Name
 		Assert-AreEqual $location $serverCreated.Location
@@ -42,8 +42,8 @@ function Test-AnalysisServicesServer
 		Assert-NotNull $serverUpdated.Tag "Tag do not exists"
 		Assert-NotNull $serverUpdated.Tag["TestTag"] "The updated tag 'TestTag' does not exist"
 
-		$serverUpdated = Set-AzureRmAnalysisServicesServer -ResourceGroupName $resourceGroupName -Name $serverName -Administrators '[email protected]' -PassThru
-		Assert-NotNull $serverUpdated.AsAdministrators "Server Administrators list is empty"
+		$serverUpdated = Set-AzureRmAnalysisServicesServer -ResourceGroupName $resourceGroupName -Name $serverName -Administrator '[email protected]' -PassThru
+		Assert-NotNull $serverUpdated.AsAdministrators "Server Administrator list is empty"
 		Assert-AreEqual $serverUpdated.AsAdministrators.Count 1
 
 		Assert-AreEqual $serverName $serverUpdated.Name
@@ -135,7 +135,7 @@ function Test-NegativeAnalysisServicesServer
 		$resourceGroupName = Get-ResourceGroupName
 		$serverName = Get-AnalysisServicesServerName
 		New-AzureRmResourceGroup -Name $resourceGroupName -Location $location
-		$serverCreated = New-AzureRmAnalysisServicesServer -ResourceGroupName $resourceGroupName -Name $serverName -Location $location -Sku 'S1' -Administrators '[email protected],[email protected]'
+		$serverCreated = New-AzureRmAnalysisServicesServer -ResourceGroupName $resourceGroupName -Name $serverName -Location $location -Sku 'S1' -Administrator '[email protected],[email protected]'
 
 		Assert-AreEqual $serverName $serverCreated.Name
 		Assert-AreEqual $location $serverCreated.Location

src/ResourceManager/AnalysisServices/Commands.AnalysisServices/Commands/NewAzureRmAnalysisServicesServer.cs

@@ -60,7 +60,7 @@ public class NewAnalysisServicesServer : AnalysisServicesCmdletBase
         [Parameter(ValueFromPipelineByPropertyName = true, Position = 4, Mandatory = false,
             HelpMessage = "A comma separated server names to set as administrators on the server")]
         [ValidateNotNull]
-        public string Administrators { get; set; }
+        public string Administrator { get; set; }
 
         public override void ExecuteCmdlet()
         {
@@ -92,7 +92,7 @@ public override void ExecuteCmdlet()
                     }
                 }
 
-                var createdServer = AnalysisServicesClient.CreateOrUpdateServer(ResourceGroupName, Name, Location, Sku, Tag, Administrators);
+                var createdServer = AnalysisServicesClient.CreateOrUpdateServer(ResourceGroupName, Name, Location, Sku, Tag, Administrator);
                 WriteObject(AzureAnalysisServicesServer.FromAnalysisServicesServer(createdServer));
             }
         }

src/ResourceManager/AnalysisServices/Commands.AnalysisServices/Commands/SetAzureRmAnalysisServicesServer.cs

@@ -52,7 +52,7 @@ public class SetAzureAnalysisServicesServer : AnalysisServicesCmdletBase
         [Parameter(ValueFromPipelineByPropertyName = true, Position = 4, Mandatory = false,
             HelpMessage = "A comma separated server names to set as administrators on the server")]
         [ValidateNotNull]
-        public string Administrators { get; set; }
+        public string Administrator { get; set; }
 
         [Parameter(Mandatory = false)]
         public SwitchParameter PassThru { get; set; }
@@ -78,7 +78,7 @@ public override void ExecuteCmdlet()
                     Tag = TagsConversionHelper.CreateTagHashtable(currentServer.Tags);
                 }
 
-                AnalysisServicesServer updatedServer = AnalysisServicesClient.CreateOrUpdateServer(ResourceGroupName, Name, location, Sku, Tag, Administrators, currentServer);
+                AnalysisServicesServer updatedServer = AnalysisServicesClient.CreateOrUpdateServer(ResourceGroupName, Name, location, Sku, Tag, Administrator, currentServer);
 
                 if(PassThru.IsPresent)
                 {

src/ResourceManager/AnalysisServices/Commands.AnalysisServices/Microsoft.Azure.Commands.AnalysisServices.dll-help.xml

@@ -156,7 +156,7 @@
 				<command:parameterValue required="true" variableLength="false">Hashtable</command:parameterValue>
 			</command:parameter>
 			<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="true (ByPropertyName)" position="4">
-				<maml:name>Administrators</maml:name>
+				<maml:name>Administrator</maml:name>
 				<maml:description>
 					<maml:para>A string representing a comma separated list of users or groups to be set as administrators on the server. The users or groups need to be specified UPN format e.g. [email protected] or [email protected]</maml:para>
 				</maml:description>
@@ -240,7 +240,7 @@
 			<dev:defaultValue></dev:defaultValue>
 		</command:parameter>
 		<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="true (ByPropertyName)" position="4">
-			<maml:name>Administrators</maml:name>
+			<maml:name>Administrator</maml:name>
 			<maml:description>
 				<maml:para>A string representing a comma separated list of users or groups to be set as administrators on the server. The users or groups need to be specified UPN format e.g. [email protected] or [email protected]</maml:para>
 			</maml:description>
@@ -680,7 +680,7 @@
 				<command:parameterValue required="true" variableLength="false">Hashtable</command:parameterValue>
 			</command:parameter>
 			<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="true (ByPropertyName)" position="4">
-				<maml:name>Administrators</maml:name>
+				<maml:name>Administrator</maml:name>
 				<maml:description>
 					<maml:para>A string representing a comma separated list of users or groups to be set as administrators on the server. The users or groups need to be specified UPN format e.g. [email protected] or [email protected]</maml:para>
 				</maml:description>
@@ -759,7 +759,7 @@
 			<dev:defaultValue></dev:defaultValue>
 		</command:parameter>
 		<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="true (ByPropertyName)" position="4">
-			<maml:name>Administrators</maml:name>
+			<maml:name>Administrator</maml:name>
 			<maml:description>
 				<maml:para>A string representing a comma separated list of users or groups to be set as administrators on the server. The users or groups need to be specified UPN format e.g. [email protected] or [email protected]</maml:para>
 			</maml:description>

tools/AzureRM/AzureRM.psd1

@@ -51,6 +51,7 @@ ProcessorArchitecture = 'None'
 RequiredModules = @(
     @{ ModuleName = 'AzureRM.Profile'; RequiredVersion = '2.2.0'},
     @{ ModuleName = 'Azure.Storage'; RequiredVersion = '2.2.0'},
+    @{ ModuleName = 'AzureRM.AnalysisServices'; RequiredVersion = '0.0.1'},
     @{ ModuleName = 'AzureRM.ApiManagement'; RequiredVersion = '3.0.0'},
     @{ ModuleName = 'AzureRM.Automation'; RequiredVersion = '2.2.0'},
     @{ ModuleName = 'AzureRM.Backup'; RequiredVersion = '2.2.0'},