merge main

Author: VeryEarly

.azure-pipelines/code-gen.yml

@@ -0,0 +1,96 @@
+# Variable 'BaseBranch' was defined in the Variables tab
+# Variable 'BotAccessToken' was defined in the Variables tab
+# Variable 'ServiceName' was defined in the Variables tab
+# Multi-job configuration must be converted to matrix strategy: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#multi-job-configuration
+resources:
+  repositories:
+  - repository: self
+    type: git
+    ref: refs/heads/generation
+jobs:
+- job: Job_1
+  displayName: 'Service: '
+  timeoutInMinutes: 90
+  pool:
+    name: pool-windows-2019
+  steps:
+  - checkout: self
+  - task: NodeTool@0
+    displayName: Use Node 14.15.5
+    inputs:
+      versionSpec: 14.15.5
+  - task: Npm@1
+    displayName: Install autorest
+    inputs:
+      command: custom
+      verbose: false
+      customCommand: install -g  autorest@latest
+  - task: PowerShell@2
+    displayName: Generate
+    inputs:
+      targetType: inline
+      script: >-
+        $subModuleFolders =  Get-ChildItem -Directory -Filter *.Autorest
+
+        if ($subModuleFolders -eq $null) {
+          autorest --max-memory-size=8192
+        } else {
+          $subModuleFolders | foreach-object { cd $_.FullName; autorest --max-memory-size=8192}
+        }
+      pwsh: true
+      workingDirectory: src/$(ServiceName)/
+  - task: PowerShell@2
+    displayName: Build
+    condition: eq(variables.ServiceSubmoduleName, '')
+    inputs:
+      targetType: inline
+      script: >-
+        $subModuleFolders =  Get-ChildItem -Directory -Filter *.Autorest
+
+        if ($subModuleFolders -eq $null) {
+          ./build-module.ps1
+        } else {
+          $subModuleFolders | foreach-object { cd $_.FullName; ./build-module.ps1; cd ..}
+        }
+
+        mkdir ../../artifacts/src/$env:SERVICENAME
+
+        cp -r ./* ../../artifacts/src/$env:SERVICENAME
+      pwsh: true
+      workingDirectory: src/$(ServiceName)
+  - task: PowerShell@2
+    displayName: Checkout main branch
+    inputs:
+      targetType: inline
+      script: >
+        mkdir src/$env:SERVICENAME
+        git checkout src/$env:SERVICENAME
+        git checkout -b codegen/$env:SERVICENAME origin/$env:BaseBranch
+  - task: PowerShell@2
+    displayName: Move code to main
+    condition: eq(variables.ServiceSubmoduleName, '')
+    inputs:
+      targetType: inline
+      script: >-
+        #Uninstall-Module -Name PackageManagement -AllVersions
+        Install-Module -Name PowerShellGet -RequiredVersion 2.2.3 -Force
+        Install-Module -Name platyPS -RequiredVersion 0.14.2 -Force
+        Install-Module -Name Az.Accounts -Force
+        Import-Module .\tools\Gen2Master\MoveFromGeneration2Master.ps1
+
+        $subModuleFolders = Get-ChildItem .\artifacts\src\$env:SERVICENAME -Directory -Filter *.Autorest
+        if ($subModuleFolders -eq $null) {
+          Move-Generation2Master -SourcePath .\artifacts\src\$env:SERVICENAME -DestPath .\src\$env:SERVICENAME
+        } else {
+          Move-Generation2MasterHybrid -SourcePath .\artifacts\src\$env:SERVICENAME -DestPath .\src\$env:SERVICENAME
+        }
+
+        git config user.email "[email protected]"
+        git config user.name "azure-powershell-bot"
+        git add ./src
+        git add tools/CreateMappings_rules.json
+        git commit -m "Move $env:SERVICENAME to $env:BaseBranch"
+        git remote set-url origin https://azure-powershell-bot:$(BotAccessToken)@github.com/Azure/azure-powershell.git
+        git push origin codegen/$env:SERVICENAME
+      pwsh: true
+

.azure-pipelines/daily-build.yml

@@ -132,6 +132,35 @@ jobs:
       SessionTimeout: '60'
       MaxConcurrency: '50'
       MaxRetryAttempts: '5'
+  
+  - task: EsrpCodeSigning@1
+    displayName: 'Sign 3rd Party [Strong Name]'
+    inputs:
+      ConnectedServiceName: '$(signServiceConnection)'
+      FolderPath: artifacts
+      Pattern: 'Release/**/FuzzySharp.dll'
+      UseMinimatch: true
+      signConfigType: inlineSignParams
+      inlineOperation: |
+        [
+          {
+            "KeyCode": "CP-233863-SN",
+            "OperationCode": "StrongNameSign",
+            "Parameters": {},
+            "ToolName": "sign",
+            "ToolVersion": "1.0"
+          },
+          {
+            "KeyCode": "CP-233863-SN",
+            "OperationCode": "StrongNameVerify",
+            "Parameters": {},
+            "ToolName": "sign",
+            "ToolVersion": "1.0"
+          }
+        ]
+      SessionTimeout: '60'
+      MaxConcurrency: '50'
+      MaxRetryAttempts: '5'
 
   - task: DotNetCoreCLI@2
     displayName: Publish

.azure-pipelines/security-tools.yml

@@ -0,0 +1,76 @@
+# Variable 'IsGenerateBased' was defined in the Variables tab
+# Variable 'NugetSecurityAnalysisWarningLevel' was defined in the Variables tab
+# Variable 'OCTOKITPAT' was defined in the Variables tab
+# Cron Schedules have been converted using UTC Time Zone and may need to be updated for your location
+schedules:
+- cron: 0 4 * * 1,2,3,4,5
+  branches:
+    include:
+    - main
+resources:
+  repositories:
+  - repository: self
+    type: git
+    ref: refs/heads/main
+jobs:
+- job: Job_1
+  displayName: Main
+  timeoutInMinutes: 120
+  pool:
+    name: pool-windows-2019
+  steps:
+  - checkout: self
+    fetchTags: false
+  - task: PowerShell@2
+    displayName: Install platyPS
+    inputs:
+      targetType: inline
+      script: Install-Module platyPS -Force -Confirm:$false -Scope CurrentUser
+      pwsh: true
+  - task: NodeTool@0
+    displayName: Install Node 14.17.1
+    condition: eq(variables.IsGenerateBased, true)
+    inputs:
+      versionSpec: 14.17.1
+  - task: PowerShell@2
+    displayName: Install autorest
+    condition: eq(variables.IsGenerateBased, true)
+    inputs:
+      targetType: inline
+      script: npm install autorest@latest;$env:NODE_OPTIONS="--max-old-space-size=65536"
+  - task: PowerShell@2
+    displayName: Build
+    inputs:
+      targetType: inline
+      script: dotnet msbuilc build.proj /t:"Build;GenerateHelp" /p:"PullRequestNumber=$(System.PullRequest.PullRequestNumber);IsSecurityCheck=true"
+    env:
+        OCTOKITPAT: $(OCTOKITPAT)
+  - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@2
+    displayName: Run CredScan
+    condition: in(variables['system.pullRequest.targetBranch'], 'generation', 'main')
+    inputs:
+      toolMajorVersion: V2
+      outputFormat: sarif
+      scanFolder: SecurityTmp
+      suppressionsFile: tools/SecurityTools/CredScanSuppressions.json
+      debugMode: false
+      folderSuppression: false
+  - task: PowerShell@2
+    displayName: Cleanup Build
+    inputs:
+      targetType: inline
+      script: ./tools/CleanupBuild.ps1
+      pwsh: true
+  - task: PoliCheck@1
+    displayName: Run PoliCheck
+    inputs:
+      targetArgument: $(Build.SourcesDirectory)/artifacts/Debug
+      result: $(Build.SourcesDirectory)/artifacts/result/PoliCheck.xml
+      optionsFTPATH: tools/SecurityTools/PoliCheckFileExtensions.xml
+  - task: PublishPipelineArtifact@0
+    displayName: Save artifacts
+    condition: succeededOrFailed()
+    inputs:
+      artifactName: artifacts
+      targetPath: artifacts
+...

.azure-pipelines/util/analyze-steps.yml

@@ -49,13 +49,17 @@ steps:
     command: custom
     custom: msbuild
     arguments: 'build.proj /t:GenerateHelp /p:Configuration=${{ parameters.configuration }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
+  env:
+      OCTOKITPAT: $(OCTOKITPAT)
 
 - task: DotNetCoreCLI@2
   displayName: 'Static Analysis'
   inputs:
     command: custom
     custom: msbuild
     arguments: 'build.proj /t:StaticAnalysis /p:Configuration=${{ parameters.configuration }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
+  env:
+      OCTOKITPAT: $(OCTOKITPAT)
 
 - template: publish-artifacts-steps.yml
   parameters:

.azure-pipelines/util/build-steps.yml

@@ -49,6 +49,8 @@ steps:
     command: custom
     custom: msbuild
     arguments: 'build.proj /t:Build /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
+  env:
+      OCTOKITPAT: $(OCTOKITPAT)
 
 - task: PowerShell@2
   displayName: Build-AzPredictor

.azure-pipelines/util/test-steps.yml

@@ -36,6 +36,8 @@ steps:
     command: custom
     custom: msbuild
     arguments: 'build.proj /t:${{ parameters.testTarget }} /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
+  env:
+      OCTOKITPAT: $(OCTOKITPAT)
 
 - powershell: |
    Install-Module -Name Pester -RequiredVersion 4.10.1 -Force -SkipPublisherCheck

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,7 +2,7 @@
 
 ## Description
 
-<!-- Please add a brief description of the changes made in this PR -->
+<!-- Please add a brief description of the changes made in this PR. If you have an ongoing or finished cmdlet design, please paste the link below. -->
 
 ## Checklist
 
@@ -15,11 +15,11 @@
     * A snippet outlining the change(s) made in the PR should be written under the `## Upcoming Release` header in the past tense. Add changelog in description section if PR goes into [`generation`](https://github.com/Azure/azure-powershell/tree/generation) branch.
     * Should **not** change `ChangeLog.md` if no new release is required, such as fixing test case only.
 * **SHOULD** have approved design review for the changes in [this repository](https://github.com/Azure/azure-powershell-cmdlet-review-pr) ([_Microsoft internal only_](../blob/main/CONTRIBUTING.md#onboarding)) with following situations
-    * Create new module from the scratch
+    * Create new module from scratch
     * Create new resource types which are not easy to conform to [Azure PowerShell Design Guidelines](../blob/main/documentation/development-docs/design-guidelines)
     * Create new resource type which name doesn't use module name as prefix
     * Have design question before implementation
 * **SHOULD** regenerate markdown help files if there is cmdlet API change. [Instruction](../blob/main/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module)
 * **SHOULD** have proper test coverage for changes in pull request.
 * **SHOULD NOT** introduce [breaking changes](../blob/main/documentation/breaking-changes/breaking-changes-definition.md) in Az minor release except preview version.
-* **SHOULD NOT** change version of module in pull request
+* **SHOULD NOT** adjust version of module manually in pull request