Fix bug where New-AzBatchApplicationPackage wouldn't work if allowUpdates was False (#24941)

* Fix logical error in GetStorageUri Function of BatchClient.ApplicationPackages

* Update Changelog

* Update ChangeLog.md

We usaully put the latest changelog to the head of Upcoming session to avoid mismerge

---------

Co-authored-by: Kenneth Harmon <[email protected]>
Co-authored-by: NoriZC <[email protected]>

Author: 3 people

src/Batch/Batch/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fixed a bug where `New-AzBatchApplicationPackage` wouldn't work if the application `AllowUpdates` parameter was set to `$false`.
 
 ## Version 3.6.1
 * Removed the out-of-date breaking change message for `Get-AzBatchCertificate` and `New-AzBatchCertificate`.

src/Batch/Batch/Models/BatchClient.ApplicationPackages.cs

@@ -189,7 +189,7 @@ private void ActivateApplicationPackage(string resourceGroupName, string account
             }
         }
 
-        private string GetStorageUrl(string resourceGroupName, string accountName, string applicationName, string version, out bool didCreateAppPackage)
+        private string GetStorageUrl(string resourceGroupName, string accountName, string applicationName, string version, out bool appPackageAlreadyExists)
         {
             try
             {
@@ -200,7 +200,7 @@ private string GetStorageUrl(string resourceGroupName, string accountName, strin
                     applicationName,
                     version);
 
-                didCreateAppPackage = false;
+                appPackageAlreadyExists = true;
                 return response.StorageUrl;
             }
             catch (CloudException exception)
@@ -221,8 +221,8 @@ private string GetStorageUrl(string resourceGroupName, string accountName, strin
                     applicationName,
                     version);
 
-                // If Application was created we need to return a flag.
-                didCreateAppPackage = true;
+                //Package didn't exist before we created it
+                appPackageAlreadyExists = false;
                 return addResponse.StorageUrl;
             }
             catch (Exception exception)