Merge pull request #4060 from hyonholee/warnings

Set obsolete parameters and cmdlets for upcoming Compute breaking change.

Author: markcowl

src/ResourceManager/Compute/Commands.Compute/AvailabilitySets/NewAzureAvailabilitySetCommand.cs

@@ -16,6 +16,7 @@
 using Microsoft.Azure.Commands.Compute.Common;
 using Microsoft.Azure.Commands.Compute.Models;
 using Microsoft.Azure.Management.Compute.Models;
+using System;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.Compute
@@ -72,6 +73,7 @@ public class NewAzureAvailabilitySetCommand : AvailabilitySetBaseCmdlet
         [Parameter(
             ValueFromPipelineByPropertyName = true,
             HelpMessage = "Managed Availability Set")]
+        [Obsolete("This parameter is obsolete.  Please use Sku parameter instead.", false)]
         public SwitchParameter Managed { get; set; }
 
         public override void ExecuteCmdlet()

src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj

@@ -25,7 +25,7 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <RunCodeAnalysis>true</RunCodeAnalysis>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'">

src/ResourceManager/Compute/Commands.Compute/Generated/Disk/Config/NewAzureRmDiskUpdateConfigCommand.cs

@@ -59,26 +59,41 @@ public class NewAzureRmDiskUpdateConfigCommand : Microsoft.Azure.Commands.Resour
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  CreateOption cannot be changed during updating a disk." +
+            "To set CreateOption of a disk, use New-AzureRmDiskConfig command.",
+            false)]
         public DiskCreateOption? CreateOption { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  StorageAccountId cannot be changed during updating a disk." +
+            "To set StorageAccountId of a disk, use New-AzureRmDiskConfig command.",
+            false)]
         public string StorageAccountId { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  ImageReference cannot be changed during updating a disk." +
+            "To set ImageReference of a disk, use New-AzureRmDiskConfig command.",
+            false)]
         public ImageDiskReference ImageReference { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  SourceUri cannot be changed during updating a disk." +
+            "To set SourceUri of a disk, use New-AzureRmDiskConfig command.",
+            false)]
         public string SourceUri { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  SourceResourceId cannot be changed during updating a disk." +
+            "To set SourceResourceId of a disk, use New-AzureRmDiskConfig command.",
+            false)]
         public string SourceResourceId { get; set; }
 
         [Parameter(

src/ResourceManager/Compute/Commands.Compute/Generated/Disk/Config/SetAzureRmDiskUpdateImageReferenceCommand.cs

@@ -28,6 +28,8 @@
 
 namespace Microsoft.Azure.Commands.Compute.Automation
 {
+    [Obsolete("This cmdlet will be removed in an upcoming release.  Updating the image reference of a disk is not supported." +
+        "To set the image reference of a disk, please use Set-AzureRmDiskImageReference command." )]
     [Cmdlet("Set", "AzureRmDiskUpdateImageReference", SupportsShouldProcess = true)]
     [OutputType(typeof(DiskUpdate))]
     public class SetAzureRmDiskUpdateImageReferenceCommand : Microsoft.Azure.Commands.ResourceManager.Common.AzureRMCmdlet

src/ResourceManager/Compute/Commands.Compute/Generated/Snapshot/Config/NewAzureRmSnapshotUpdateConfigCommand.cs

@@ -59,26 +59,41 @@ public class NewAzureRmSnapshotUpdateConfigCommand : Microsoft.Azure.Commands.Re
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  CreateOption cannot be changed during updating a snapshot." +
+            "To set the CreateOption of a snapshot, use New-AzureRmSnapshotConfig command.",
+            false)]
         public DiskCreateOption? CreateOption { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  StorageAccountId cannot be changed during updating a snapshot." +
+            "To set the StorageAccountId of a snapshot, use New-AzureRmSnapshotConfig command.",
+            false)]
         public string StorageAccountId { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  ImageReference cannot be changed during updating a snapshot." +
+            "To set the ImageReference of a snapshot, use New-AzureRmSnapshotConfig command.",
+            false)]
         public ImageDiskReference ImageReference { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  SourceUri cannot be changed during updating a snapshot." +
+            "To set the SourceUri of a snapshot, use New-AzureRmSnapshotConfig command.",
+            false)]
         public string SourceUri { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true)]
+        [Obsolete("This parameter is obsolete.  SourceResourceId cannot be changed during updating a snapshot." +
+            "To set the SourceResourceId of a snapshot, use New-AzureRmSnapshotConfig command.",
+            false)]
         public string SourceResourceId { get; set; }
 
         [Parameter(

src/ResourceManager/Compute/Commands.Compute/Generated/Snapshot/Config/SetAzureRmSnapshotUpdateImageReferenceCommand.cs

@@ -28,6 +28,8 @@
 
 namespace Microsoft.Azure.Commands.Compute.Automation
 {
+    [Obsolete("This cmdlet will be removed in the upcoming release.  Updating the image reference of a snapshot is not supported." +
+        "To set image reference of a snapshot, please use Set-AzureRmSnapshotImageReference command.")]
     [Cmdlet("Set", "AzureRmSnapshotUpdateImageReference", SupportsShouldProcess = true)]
     [OutputType(typeof(SnapshotUpdate))]
     public class SetAzureRmSnapshotUpdateImageReferenceCommand : Microsoft.Azure.Commands.ResourceManager.Common.AzureRMCmdlet