Skip to content

Commit ac01552

Browse files
[tools] Fix issue when RequiredModules in psd1 are empty (#19357)
Co-authored-by: Yeming Liu <[email protected]>
1 parent bf5de68 commit ac01552

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tools/VersionController/Models/VersionBumper.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,11 @@ private void UpdateOutputModuleManifest(List<string> releaseNotes)
461461
script += getRequiredModulesScript;
462462
script += $"$env:PSModulePath+=\";{_fileHelper.OutputResourceManagerDirectory}\";";
463463
script += "Set-ExecutionPolicy -ExecutionPolicy Unrestricted -Scope Process;";
464-
script += "Update-ModuleManifest -Path " + tempModuleManifestPath + " -ModuleVersion " + _newVersion + " -ReleaseNotes $releaseNotes" + " -RequiredModules $requiredmodules;";
464+
script += "if ($requiredModules.Count -gt 0){" +
465+
"Update-ModuleManifest -Path " + tempModuleManifestPath + " -ModuleVersion " + _newVersion + " -ReleaseNotes $releaseNotes" + " -RequiredModules $requiredModules" +
466+
"}else {" +
467+
"Update-ModuleManifest -Path " + tempModuleManifestPath + " -ModuleVersion " + _newVersion + " -ReleaseNotes $releaseNotes" +
468+
"};";
465469
script += "$?";
466470

467471
using (PowerShell powershell = PowerShell.Create())
@@ -472,7 +476,9 @@ private void UpdateOutputModuleManifest(List<string> releaseNotes)
472476
if (result.Count > 0 &&
473477
(!bool.TryParse(result.Last()?.ToString(), out exitcode)) || !exitcode)
474478
{
475-
Console.WriteLine($"Found error in updating module {_fileHelper.ModuleName}: {powershell.Streams.Error.First()?.ToString()}");
479+
var errorMsg = $"Found error in updating module {_fileHelper.ModuleName}: {powershell.Streams.Error.First()?.ToString()}";
480+
_logger.LogError(errorMsg);
481+
throw new Exception(errorMsg);
476482
}
477483
}
478484

0 commit comments

Comments
 (0)