Skip to content

Commit b049ef1

Browse files
authored
If only bump one module, only remove its minimal version from MinimalVersion.csv (#18919)
* If only bump one module, only remove its minimal version from MinimalVersion.csv * polish code * update
1 parent 005035e commit b049ef1

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

tools/VersionController/Program.cs

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ public class Program
3434
private static List<string> _projectDirectories, _outputDirectories;
3535
private static string _rootDirectory, _moduleNameFilter;
3636

37+
private const string Psd1NameExtension = ".psd1";
38+
3739
private static IList<string> ExceptionFileNames = new List<string>()
3840
{
3941
"AssemblyVersionConflict.csv",
@@ -70,7 +72,7 @@ public static void Main(string[] args)
7072
_moduleNameFilter = string.Empty;
7173
if (args != null && args.Length > 1)
7274
{
73-
_moduleNameFilter = args[1] + ".psd1";
75+
_moduleNameFilter = args[1] + Psd1NameExtension;
7476
}
7577

7678
ConsolidateExceptionFiles(exceptionsDirectory);
@@ -175,6 +177,10 @@ private static void BumpVersions()
175177
var file = File.ReadAllLines(miniVersionFile);
176178
var header = file.First();
177179
var lines = file.Skip(1).Where(c => !string.IsNullOrEmpty(c));
180+
181+
var bumpingModule = _moduleNameFilter.Replace(Psd1NameExtension, "");
182+
List<string> _minimalVersionContent = new List<string>() { header };
183+
178184
foreach (var line in lines)
179185
{
180186
var cols = line.Split(",").Select(c => c.StartsWith("\"") ? c.Substring(1) : c)
@@ -183,11 +189,17 @@ private static void BumpVersions()
183189
if (cols.Length >= 2)
184190
{
185191
_minimalVersion.Add(cols[0], new AzurePSVersion(cols[1]));
192+
193+
// Bump one module, only remove its minimal version from MinimalVersion.csv content
194+
if (!string.IsNullOrEmpty(bumpingModule) && !cols[0].Equals(bumpingModule))
195+
{
196+
_minimalVersionContent.Add(line);
197+
}
186198
}
187199
}
188200

189201
// Clean MinimalVersion.csv
190-
File.WriteAllLines(Path.Combine(_rootDirectory, @"tools\VersionController", "MinimalVersion.csv"), new string[]{ header});
202+
File.WriteAllLines(Path.Combine(_rootDirectory, @"tools\VersionController", "MinimalVersion.csv"), _minimalVersionContent.ToArray());
191203
}
192204

193205
//Make Az.Accounts as the last module to calculate

0 commit comments

Comments
 (0)