Skip to content

Commit b1c6fc8

Browse files
author
Nori Zhang
committed
Polished code.
1 parent 408f714 commit b1c6fc8

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/Accounts/Accounts/Models/RMProfileClient.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -425,20 +425,22 @@ public bool TryGetSubscriptionListByName(string tenantId, string subscriptionNam
425425
{
426426
subscriptions = ListSubscriptions(tenantId).Where(s => s.Name.Equals(subscriptionName, StringComparison.OrdinalIgnoreCase));
427427
List<IAzureSubscription> subscriptionList = new List<IAzureSubscription>();
428-
HashSet<Guid> subscriptionIds = new HashSet<Guid>();
428+
HashSet<Guid> existedSubscriptionIds = new HashSet<Guid>();
429+
430+
// Consider subscription in Home tenant first, exclude duplicate subscriptions by id.
429431
foreach(IAzureSubscription subscription in subscriptions)
430432
{
431-
432-
if(subscription is PSAzureSubscription && subscription.GetTenant() != null
433-
&& subscription.GetHomeTenant().Equals(subscription.GetTenant()) && subscriptionIds.Add(subscription.GetId()))
433+
if (subscription is PSAzureSubscription && subscription.GetTenant() != null
434+
&& subscription.GetHomeTenant().Equals(subscription.GetTenant()) && existedSubscriptionIds.Add(subscription.GetId()))
434435
{
435436
subscriptionList.Add(subscription);
436437
}
437438

438439
}
440+
// Consider other subscriptions.
439441
foreach (IAzureSubscription subscription in subscriptions)
440442
{
441-
if (subscriptionIds.Add(subscription.GetId()))
443+
if (existedSubscriptionIds.Add(subscription.GetId()))
442444
{
443445
subscriptionList.Add(subscription);
444446
}

0 commit comments

Comments
 (0)