Fix secure string conversion (#12678)

isra-fel · web-flow · commit b702324d759b · 2020-08-18T09:44:27.000+08:00
diff --git a/src/HanaOnAzure/custom/New-AzSapMonitorProviderInstance.ps1 b/src/HanaOnAzure/custom/New-AzSapMonitorProviderInstance.ps1
@@ -203,7 +203,8 @@ function New-AzSapMonitorProviderInstance {
                     hanaDbName     = $HanaDatabaseName
                     hanaDbSqlPort  = $HanaDatabaseSqlPort
                     hanaDbUsername = $HanaDatabaseUsername
-                    hanaDbPassword = ConvertFrom-SecureString $HanaDatabasePassword -AsPlainText
+                    # cannot use `ConvertFrom-SecureString -AsPlainText`, requires powershell >= 7
+                    hanaDbPassword = [System.Runtime.InteropServices.marshal]::PtrToStringAuto([System.Runtime.InteropServices.marshal]::SecureStringToBSTR($HanaDatabasePassword))
                 }
             }
             'ByKeyVault' {

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,8 @@ function New-AzSapMonitorProviderInstance {`
`203`	`203`	`hanaDbName = $HanaDatabaseName`
`204`	`204`	`hanaDbSqlPort = $HanaDatabaseSqlPort`
`205`	`205`	`hanaDbUsername = $HanaDatabaseUsername`
`206`		`- hanaDbPassword = ConvertFrom-SecureString $HanaDatabasePassword -AsPlainText`
	`206`	+ # cannot use `ConvertFrom-SecureString -AsPlainText`, requires powershell >= 7
	`207`	`+ hanaDbPassword = [System.Runtime.InteropServices.marshal]::PtrToStringAuto([System.Runtime.InteropServices.marshal]::SecureStringToBSTR($HanaDatabasePassword))`
`207`	`208`	`}`
`208`	`209`	`}`
`209`	`210`	`'ByKeyVault' {`