Adding probeTreshold property to Load Balancer probe (#19575)

* initial commit for adding probeTreshold property to lb probe

* adding description to changeLog.md

* ensuring UTs pass, and the probeThreshold parameter gets passed in during creation of LB probe

* removing UTs which are not neccessary

* spelling errors

* adding file specification for ChangeLog.md

* adjusting cmdlet to handle null entry for ProbeThreshold parameter

Author: bhavanabheem

src/Network/Network.Test/ScenarioTests/LoadBalancerTests.cs

@@ -89,6 +89,14 @@ public void TestLoadBalancerCRUDPublicUsingId()
             TestRunner.RunTestScript("Test-LoadBalancerCRUD-PublicUsingId");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        [Trait(Category.Owner, NrpTeamAlias.slbdev)]
+        public void TestLoadBalancerProbes_ProbeThresholdParameter()
+        {
+            TestRunner.RunTestScript("Test-LoadBalancerProbes_ProbeThresholdParameter");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         [Trait(Category.Owner, NrpTeamAlias.slbdev)]

src/Network/Network.Test/ScenarioTests/LoadBalancerTests.ps1

@@ -33,6 +33,10 @@
     - `New-AzApplicationGatewayClientAuthConfiguration`
     - `Set-AzApplicationGatewayClientAuthConfiguration`
 * Added Uppercase Transform in New-AzApplicationGatewayFirewallCondition
+* Added ProbeThreshold parameter to Load Balancer Probe 
+    - `AddAzureRmLoadBalancerProbeConfigCommmand.cs`
+    - `NewAzureRmLoadBalancerProbeConfigCommand.cs`
+    - `SetAzureRmLoadBalancerProbeConfigCommand.cs`
 * Updated commandlet to support specifying an action for a managed rule override in Application Gateway WAF Policy.
     - `New-AzApplicationGatewayFirewallPolicyManagedRuleOverride`
 

src/Network/Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.LoadBalancerTests/TestLoadBalancerCRUDPublic.json

@@ -47,6 +47,9 @@ public partial class PSProbe : PSChildResource
         public int NumberOfProbes { get; set; }
         [JsonProperty(Order = 1)]
         [Ps1Xml(Target = ViewControl.Table)]
+        public int? ProbeThreshold { get; set; }
+        [JsonProperty(Order = 1)]
+        [Ps1Xml(Target = ViewControl.Table)]
         public string RequestPath { get; set; }
         [JsonProperty(Order = 1)]
         [Ps1Xml(Target = ViewControl.Table)]
@@ -75,6 +78,11 @@ public bool ShouldSerializeNumberOfProbes()
             return !string.IsNullOrEmpty(this.Name);
         }
 
+        public bool ShouldSerializeProbeThreshold()
+        {
+            return !string.IsNullOrEmpty(this.Name);
+        }
+
         public bool ShouldSerializeLoadBalancingRules()
         {
             return !string.IsNullOrEmpty(this.Name);