Update template utility to throw exception on uri download failure. (#24731)

* Update template utility to throw exception on uri download failure.

Update to the template utility caused download failures of a template uri (or template parameter uri) to be suppressed. Update throws argument exception so uri can be fixed before proceeding. Update throws argument exception so uri can be fixed before proceeding.

* Update failing test.

* Updated changelog.

Author: dantedallag

src/Resources/ResourceManager/Utilities/TemplateUtility.cs

@@ -86,6 +86,10 @@ private static string GetTemplateContentFromFile(string templateFilePath)
                 if (Uri.IsWellFormedUriString(templateFilePath, UriKind.Absolute))
                 {
                     templateContent = GeneralUtilities.DownloadFile(templateFilePath);
+                    if (templateContent == null)
+                    {
+                        throw new PSArgumentException("Unable to download template file from provided uri.");
+                    }
                 }
                 else if (FileUtilities.DataStore.FileExists(templateFilePath))
                 {
@@ -158,7 +162,12 @@ private static Hashtable GetTemplateParameterContentFromFile(string templatePara
             {
                 if (Uri.IsWellFormedUriString(templateParameterFilePath, UriKind.Absolute))
                 {
-                    templateParameterContent = new Hashtable(ParseTemplateParameterContent(GeneralUtilities.DownloadFile(templateParameterFilePath)));
+                    var fileContent = GeneralUtilities.DownloadFile(templateParameterFilePath);
+                    if (fileContent == null)
+                    {
+                        throw new PSArgumentException("Unable to download template parameter file from provided uri.");
+                    }
+                    templateParameterContent = new Hashtable(ParseTemplateParameterContent(fileContent));
                 }
                 else if (FileUtilities.DataStore.FileExists(templateParameterFilePath))
                 {

src/Resources/Resources.Test/ScenarioTests/ResourceGroupTests.ps1

@@ -243,16 +243,14 @@ function Test-RemoveDeployment
 {
     # Setup
     $deploymentName = "Test"
-    $templateUri = "https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/101-storage-account-create/azuredeploy.json"
+    $templateUri = "https://raw.githubusercontent.com/Azure/azure-quickstart-templates/b5a68ce5005bc186070506b8d42a25b865f047a6/100-blank-template/azuredeploy.json"
     $rgName = "TestSDK0123"
 
     try
     {
         # First create new resource group deployment
         New-AzResourceGroup -Name $rgName -Location "East US"
-        $job = New-AzResourceGroupDeployment -ResourceGroupName $rgName -Name $deploymentName -TemplateUri $templateUri -AsJob
-		Wait-Job $job
-		$deployment = Receive-Job $job
+        $deployment = New-AzResourceGroupDeployment -ResourceGroupName $rgName -Name $deploymentName -TemplateUri $templateUri
 
         # Test
         $res = Remove-AzResourceGroupDeployment -ResourceGroupName $deployment.ResourceGroupName -Name $deployment.DeploymentName