Skip to content

Commit b974a3c

Browse files
authored
[Storage] Add user agent for dataplane cmdlets (#12255)
1 parent 360dfad commit b974a3c

22 files changed

+38
-31
lines changed

src/Storage/Storage.Management/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Fixed the issue that UserAgent not added for some dataplane cmdlets.
2122
* Supported create/update Storage account with MinimumTlsVersion and AllowBlobPublicAccess
2223
- `New-AzStorageAccount`
2324
- `Set-AzStorageAccount`

src/Storage/Storage/Blob/Cmdlet/GetAzureStorageContainerStoredAccessPolicy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ internal async Task GetAzureContainerStoredAccessPolicyAsync(long taskId, IStora
8686
internal async Task<SharedAccessBlobPolicies> GetPoliciesAsync(IStorageBlobManagement localChannel, string containerName, string policyName)
8787
{
8888
CloudBlobContainer container = localChannel.GetContainerReference(containerName);
89-
BlobContainerPermissions blobContainerPermissions = await localChannel.GetContainerPermissionsAsync(container, null, null, null, CmdletCancellationToken).ConfigureAwait(false);
89+
BlobContainerPermissions blobContainerPermissions = await localChannel.GetContainerPermissionsAsync(container, null, null, OperationContext, CmdletCancellationToken).ConfigureAwait(false);
9090
return blobContainerPermissions.SharedAccessPolicies;
9191
}
9292

src/Storage/Storage/Blob/Cmdlet/NewAzureStorageContainerStoredAccessPolicy.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ internal string CreateAzureContainerStoredAccessPolicy(IStorageBlobManagement lo
7777

7878
//Get existing permissions
7979
CloudBlobContainer container = localChannel.GetContainerReference(containerName);
80-
BlobContainerPermissions blobContainerPermissions = localChannel.GetContainerPermissions(container);
80+
BlobContainerPermissions blobContainerPermissions = localChannel.GetContainerPermissions(container, null, null, OperationContext);
8181

8282
//Add new policy
8383
if (blobContainerPermissions.SharedAccessPolicies.Keys.Contains(policyName))
@@ -90,7 +90,7 @@ internal string CreateAzureContainerStoredAccessPolicy(IStorageBlobManagement lo
9090
blobContainerPermissions.SharedAccessPolicies.Add(policyName, policy);
9191

9292
//Set permissions back to container
93-
localChannel.SetContainerPermissions(container, blobContainerPermissions);
93+
localChannel.SetContainerPermissions(container, blobContainerPermissions, null, null, OperationContext);
9494
return policyName;
9595
}
9696

src/Storage/Storage/Blob/Cmdlet/RemoveAzureStorageContainerStoredAccessPolicy.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ internal bool RemoveAzureContainerStoredAccessPolicy(IStorageBlobManagement loca
6969

7070
//Get existing permissions
7171
CloudBlobContainer container = localChannel.GetContainerReference(containerName);
72-
BlobContainerPermissions blobContainerPermissions = localChannel.GetContainerPermissions(container);
72+
BlobContainerPermissions blobContainerPermissions = localChannel.GetContainerPermissions(container, null, null, OperationContext);
7373

7474
//remove the specified policy
7575
if (!blobContainerPermissions.SharedAccessPolicies.Keys.Contains(policyName))
@@ -80,7 +80,7 @@ internal bool RemoveAzureContainerStoredAccessPolicy(IStorageBlobManagement loca
8080
if (ShouldProcess(policyName, "Remove policy"))
8181
{
8282
blobContainerPermissions.SharedAccessPolicies.Remove(policyName);
83-
localChannel.SetContainerPermissions(container, blobContainerPermissions);
83+
localChannel.SetContainerPermissions(container, blobContainerPermissions, null, null, OperationContext);
8484
success = true;
8585
}
8686

src/Storage/Storage/Blob/Cmdlet/SetAzureStorageContainerAcl.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ internal async Task SetContainerAcl(long taskId, IStorageBlobManagement localCha
8787
BlobContainerPermissions permissions;
8888
try
8989
{
90-
permissions = localChannel.GetContainerPermissions(container);
90+
permissions = localChannel.GetContainerPermissions(container, null, requestOptions, OperationContext);
9191
}
9292
catch (StorageException e) when (e.IsNotFoundException())
9393
{

src/Storage/Storage/Blob/Cmdlet/SetAzureStorageContainerStoredAccessPolicy.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ internal string SetAzureContainerStoredAccessPolicy(IStorageBlobManagement local
7878
{
7979
//Get existing permissions
8080
CloudBlobContainer container = localChannel.GetContainerReference(containerName);
81-
BlobContainerPermissions blobContainerPermissions = localChannel.GetContainerPermissions(container);
81+
BlobContainerPermissions blobContainerPermissions = localChannel.GetContainerPermissions(container, null, null, OperationContext);
8282

8383
//Set the policy with new value
8484
if (!blobContainerPermissions.SharedAccessPolicies.Keys.Contains(policyName))
@@ -91,7 +91,7 @@ internal string SetAzureContainerStoredAccessPolicy(IStorageBlobManagement local
9191
blobContainerPermissions.SharedAccessPolicies[policyName] = policy;
9292

9393
//Set permission back to container
94-
localChannel.SetContainerPermissions(container, blobContainerPermissions);
94+
localChannel.SetContainerPermissions(container, blobContainerPermissions, null, null, OperationContext);
9595
WriteObject(AccessPolicyHelper.ConstructPolicyOutputPSObject<SharedAccessBlobPolicy>(blobContainerPermissions.SharedAccessPolicies, policyName));
9696
return policyName;
9797
}

src/Storage/Storage/Common/CmdletOperationContext.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
namespace Microsoft.WindowsAzure.Commands.Storage.Common
1616
{
1717
using Microsoft.Azure.Storage;
18+
using Microsoft.WindowsAzure.Commands.Common;
1819
using System;
1920
using System.Threading;
2021
using XTable = Microsoft.Azure.Cosmos.Table;
@@ -148,6 +149,9 @@ public static OperationContext GetStorageOperationContext(Action<string> outputW
148149
}
149150
};
150151

152+
context.CustomUserAgent = ApiConstants.UserAgentHeaderValue;
153+
154+
151155
return context;
152156
}
153157

@@ -207,6 +211,8 @@ public static XTable.OperationContext GetStorageTableOperationContext(Action<str
207211
}
208212
};
209213

214+
context.CustomUserAgent = ApiConstants.UserAgentHeaderValue;
215+
210216
return context;
211217
}
212218

src/Storage/Storage/Common/Util.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,10 @@ private static CloudBlob GetBlobReferenceFromServer(
108108
return null;
109109
}
110110

111-
return GetCorrespondingTypeBlobReference(blob);
111+
return GetCorrespondingTypeBlobReference(blob, operationContext);
112112
}
113113

114-
public static CloudBlob GetCorrespondingTypeBlobReference(CloudBlob blob)
114+
public static CloudBlob GetCorrespondingTypeBlobReference(CloudBlob blob, OperationContext operationContext)
115115
{
116116
CloudBlob targetBlob;
117117
switch (blob.Properties.BlobType)
@@ -135,7 +135,7 @@ public static CloudBlob GetCorrespondingTypeBlobReference(CloudBlob blob)
135135

136136
try
137137
{
138-
Task.Run(() => targetBlob.FetchAttributesAsync()).Wait();
138+
Task.Run(() => targetBlob.FetchAttributesAsync(null, null, operationContext)).Wait();
139139
}
140140
catch (AggregateException e) when (e.InnerException is StorageException)
141141
{

src/Storage/Storage/File/Cmdlet/GetAzureStorageShareStoredAccessPolicy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ internal async Task GetAzureShareStoredAccessPolicyAsync(long taskId, IStorageFi
7070
internal async Task<SharedAccessFilePolicies> GetPoliciesAsync(IStorageFileManagement localChannel, string shareName, string policyName)
7171
{
7272
CloudFileShare share = localChannel.GetShareReference(shareName);
73-
FileSharePermissions permissions = await localChannel.GetSharePermissionsAsync(share, null, null, null, CmdletCancellationToken).ConfigureAwait(false);
73+
FileSharePermissions permissions = await localChannel.GetSharePermissionsAsync(share, null, null, OperationContext, CmdletCancellationToken).ConfigureAwait(false);
7474
return permissions.SharedAccessPolicies;
7575
}
7676

src/Storage/Storage/File/Cmdlet/NewAzureStorageShareStoredAccessPolicy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public override void ExecuteCmdlet()
9393
//Set permissions back to container
9494
try
9595
{
96-
Task.Run(() => fileShare.SetPermissionsAsync(fileSharePermissions)).Wait();
96+
Task.Run(() => fileShare.SetPermissionsAsync(fileSharePermissions, null, null, OperationContext)).Wait();
9797
}
9898
catch (AggregateException e) when (e.InnerException is StorageException)
9999
{

0 commit comments

Comments
 (0)